Nathan Sobo
d50c8f2d0e
Merge branch 'master' of github.com:github/atom into edit-session-refactor
2012-06-07 11:40:01 -06:00
Corey Johnson
481ec16485
meta-w closes edit sessions until there are none left, then it closes the editor
2012-06-07 10:21:16 -07:00
Nathan Sobo
7387c553c3
Start introducing Cursor model in EditSession
...
The old cursor view still does most of the work, but to add a new cursor view we now must add a cursor model to the edit session at the correct position. The editor watches the 'add-cursor' event on edit session and add a corresponding CursorView to the CompositeCursor whenever a model is added. Next step: have the cursor view observe the cursor model and shadow its changes in position.
2012-06-06 21:52:19 -06:00
Nathan Sobo
ff52993c9e
Fix bugs when switching between EditSessions
2012-06-06 17:00:02 -06:00
Nathan Sobo
1344d42061
Add spec to ensure we unsubscribe from every buffer when we remove editor
2012-06-06 12:48:45 -06:00
Nathan Sobo
e6af7a9515
Adjust the width of rendered lines to account for the longest line
2012-06-05 14:26:06 -06:00
Nathan Sobo
e433d106b8
Remove unnecessary construction of new editor
2012-06-05 14:25:32 -06:00
Nathan Sobo
3a776347ff
Avoid leaking window resize subscriptions in editor spec
2012-06-05 14:25:08 -06:00
Nathan Sobo
e7ffaa1757
Merge branch 'master' of github.com:github/atom
2012-06-05 12:48:16 -06:00
Nathan Sobo
911a417cb8
Rename maxLineLength to softWrapColumn
2012-06-05 12:47:39 -06:00
Corey Johnson
4f364e8cd8
Add newline-below event
2012-06-05 11:30:29 -07:00
Nathan Sobo
4dc41dcc21
💄
2012-06-05 11:09:40 -06:00
Nathan Sobo
c24b8a90b2
If lines are removed after a renderer change, update padding appropriately
2012-06-05 10:59:11 -06:00
Nathan Sobo
9cfbce826d
WIP: Don't allow impossibly high scroll top values.
...
It fixes the move to bottom issues, but breaks some other tests. Not sure why yet...
2012-06-04 21:57:10 -06:00
Nathan Sobo
3c2facc7be
Add a disabled failing spec for text rendering when moving to the end of the file
2012-06-04 21:11:32 -06:00
Nathan Sobo
de1086639d
Add failing spec for folding more than a screen of text to less than a screen
2012-06-04 20:45:28 -06:00
Nathan Sobo
c3a157a544
Revert "Use renderTo and renderFrom (instead of firstVisible/lastVisible) to adjust visible lines."
...
This reverts commit 419d7b1dec
2012-06-04 20:29:40 -06:00
Corey Johnson
0cfb2e9ef4
Rename Editor.visibleLines to Editor.renderedLines
2012-06-04 17:53:58 -07:00
Corey Johnson
419d7b1dec
Use renderTo and renderFrom (instead of firstVisible/lastVisible) to adjust visible lines.
...
Fix specs that had wrong assumptions,
2012-06-04 17:48:11 -07:00
Corey Johnson
2f6dd085ee
Editor toggle-fold event toggles the largest fold at the cursor position
2012-06-04 09:44:20 -07:00
Corey Johnson
30d07fd1a0
Rename Buffer.numLines to Buffer.getLineCount
2012-06-01 11:25:58 -07:00
Corey Johnson
5a0eb5814d
We are using scrollTop instead of -wekbit-transform, update specs to reflect this.
2012-06-01 11:06:14 -07:00
Corey Johnson
6952e09646
Moved font-size back to 'px' and fixed specs
2012-06-01 11:06:13 -07:00
Corey Johnson
2623724fd4
Add fold-all event to editor
2012-06-01 11:06:13 -07:00
Nathan Sobo
9cb067f162
Enable auto-indent for 1 more spec + 💄
2012-05-31 18:22:54 -06:00
Nathan Sobo
502208dcf4
Enable auto-indent for spec
2012-05-31 18:17:39 -06:00
Nathan Sobo
9f5a7ceefe
Merge branch 'master' into structural-folding
2012-05-31 18:05:13 -06:00
Nathan Sobo
acb01bba37
Correctly render lines when destroying a fold forces an autoscroll
2012-05-31 17:48:50 -06:00
Corey Johnson
b03230cc6c
Move auto indent/outdent to selection spec
2012-05-31 13:57:04 -07:00
Corey Johnson
516de1ede1
Merge branch 'master' into structural-folding
2012-05-31 11:46:23 -07:00
Nathan Sobo
fdb8ba8a2b
Remove redundant gutter spec. Corey's is in a better spot.
2012-05-31 12:13:36 -06:00
Nathan Sobo
06fffe6c4b
Merge branch 'master' of github.com:github/atom
...
Conflicts:
src/app/editor.coffee
2012-05-31 12:11:07 -06:00
Nathan Sobo
c901417a19
When lines are added, remove any that get pushed down to exceed the max allowed row
...
This fixes issues where unfolding or pasting caused rendering artifacts below the last visible row.
2012-05-31 12:06:00 -06:00
Corey Johnson
17c0526bc3
Add test for gutter rendering of fold lines
2012-05-31 10:26:34 -07:00
Nathan Sobo
39fb14e5f5
Add a spec for line number updates after folding/unfolding
2012-05-31 10:57:04 -06:00
Nathan Sobo
6c64d2a13b
spec 💄
2012-05-31 10:46:00 -06:00
Corey Johnson
17b50ee8dc
Folds include their first line
2012-05-30 16:55:15 -07:00
Corey Johnson
42e743f44a
Renderer.toggleFold works for folded, foldable and non-foldable lines
...
When a line is not foldable, we search upward for a suggested fold that contains it and apply that fold instead. If called with a row that is already folded, it unfolds it.
2012-05-30 16:29:45 -07:00
Corey Johnson
76f5d35eb9
Add toggle-fold event to editor
2012-05-30 15:43:21 -07:00
Nathan Sobo
0ef4c7e172
Only re-render the gutter when we render new lines
2012-05-29 15:12:11 -06:00
Nathan Sobo
3e26386f98
Always re-render gutter from the first rendered to the last rendered screen row
2012-05-29 14:51:19 -06:00
Nathan Sobo
0700aba67f
All specs pass again with overdraw
2012-05-29 13:39:13 -06:00
Nathan Sobo
6e34124f12
Overdraw gutter line numbers in addition to editor lines
2012-05-29 13:07:24 -06:00
Nathan Sobo
a9c9a854ac
Only truncate change ranges to the last visible row if the last rendered row is smaller
...
This happens, for example, when the entire buffer is shorter than the number of rows on screen. In this case, the last rendered row is not smaller than the last possible visible row.
2012-05-29 13:03:29 -06:00
Nathan Sobo
c00c3317f0
Down to 2 failures by truncating change ranges to the range of the current rendered lines
2012-05-29 12:52:39 -06:00
Nathan Sobo
e9a67208e6
Adjust otherwise-passing spec for overflow
2012-05-29 11:50:54 -06:00
Nathan Sobo
8fba4ff935
Fix some off by one errors in the overdraw calculations
2012-05-26 13:52:48 -07:00
Nathan Sobo
328aa3ba6b
WIP: Redoing overdraw code… it's broken
2012-05-26 13:05:25 -07:00
Nathan Sobo
351c283ed6
Merge branch 'master' into overdraw
2012-05-25 13:13:06 -07:00
Nathan Sobo
e2ca3814a9
Hide the cursor when it is on a fold line
2012-05-25 12:35:32 -07:00
