Joe Fitzgerald
b2ff95caf4
Run shell as detached process
...
- Implement timeout
- Clean up running process if window is reloaded or Atom exits
2016-11-24 10:39:16 -07:00
Joe Fitzgerald
f73aa46cef
Fix lint errors
2016-11-14 17:09:01 -07:00
Joe Fitzgerald
c83e71cb9d
Don’t detach child process, cleanup code
2016-11-14 17:02:12 -07:00
Joe Fitzgerald
3123a92687
🎨 Fix spec, cleanup
2016-11-14 16:29:13 -07:00
Joe Fitzgerald
d0a011e93a
Fix specs, rename cp > child_process
2016-11-14 16:23:10 -07:00
Joe Fitzgerald
1b2d2f0299
Use child_process.spawn instead of execFile
...
- Fixes #13084
- Kill child process on process exit, if it is running
- Ensure env is set correctly when new windows are launched
2016-11-14 10:06:26 -07:00
Antonio Scandurra
e34bc188d0
Make updateProcessEnv asynchronous
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-11-11 18:39:18 +01:00
Joe Fitzgerald
7dfc99989f
Timeout when invoking the shell, log information to the console
...
- Partially addresses #13084
2016-11-10 14:23:24 -07:00
Joe Fitzgerald
d4d05244b3
ATOM_SUPPRESS_ENV_PATCHING > ATOM_DISABLE_SHELLING_OUT_FOR_ENVIRONMENT
2016-09-08 12:24:33 -06:00
Joe Fitzgerald
36291f6a8f
Combine Check
...
- The additional (!process.env[key] && envToAssign[key]) check allows “preserved” variables to be set for the first time if they are currently unset
2016-09-08 11:18:28 -06:00
Joe Fitzgerald
10270609d8
Use ATOM_SUPPRESS_ENV_PATCHING Environment Variable
...
- Stop using shell whitelist
2016-09-08 10:56:01 -06:00
Joe Fitzgerald
c570e14420
Get Environment From Shell On Linux
2016-09-08 10:56:01 -06:00
Max Brunsfeld
8018dc9d57
Allow ATOM_HOME to be reassigned if the new value is valid
2016-08-15 17:05:18 -07:00
Joe Fitzgerald
485cb71be7
🎨 envShouldBePatched > shouldGetEnvFromShell
2016-08-11 17:07:21 -06:00
Joe Fitzgerald
9ec63a8ffc
🎨 Cleanup
...
* shellShouldBePatched > envShouldBePatched
2016-08-11 16:45:19 -06:00
Joe Fitzgerald
b7a48967fa
Fix Regression In #12317 For zsh
...
In Atom 1.7 and 1.8, the environment would be patched for users of the zsh shell on OS X. A whitelist of shells was established in #12317 , which is extended here.
2016-08-11 12:45:02 -06:00
Max Brunsfeld
29096bde31
Don't update ATOM_HOME env var after launch
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-09 14:38:19 -07:00
Max Brunsfeld
3103682efd
Bypass aliases when running env shell command
2016-08-09 14:25:25 -07:00
Max Brunsfeld
c0e94aac5e
Handle null env load setting
2016-08-04 15:54:15 -07:00
Max Brunsfeld
4634091e9b
Don't update the NODE_PATH when updating the environment on launch
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-03 15:50:21 -07:00
