Commit Graph

8 Commits

Author SHA1 Message Date
Antonio Scandurra
8249dbbb79 Fix release channel detection on Travis
In the previous build scripts, we were considering all the builds
triggered by a pull-request to be part of the dev channel. We adopted
the same heuristic for the new build scripts, but didn't notice that
Travis always sets the `TRAVIS_PULL_REQUEST` variable to "false" (which
causes the `process.env.TRAVIS_PULL_REQUEST` expression to be evaluated
as truthy).

In the past, this wasn't a problem because we were building artifacts
via Janky, but after switching to Travis this makes it generate the
wrong assets on stable and beta.

To fix this, it seems reasonable to remove the conditional that checks
if we are building a pull-request: in the past this could have been
problematic because assets could be uploaded inadvertently to S3 or
GitHub, but this should be safe now that we rely on the release
publisher to perform that task.
2016-09-01 09:49:37 +02:00
Antonio Scandurra
14611926ac Ensure script/bootstrap works after cleaning dependencies up 2016-08-29 13:40:17 +02:00
Antonio Scandurra
5fc2405801 Compile CSON, Babel and Coffeescript files using CompileCache 2016-08-13 12:49:46 +02:00
Antonio Scandurra
65b0f7d70f Rename cachePath to electronDownloadPath 2016-08-11 12:18:33 +02:00
Nathan Sobo
e949984fe8 Add API docs generation to new build script
Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-08-03 09:45:43 -06:00
Antonio Scandurra
748e61c88f Fix apm bin path on AppVeyor 2016-08-02 14:55:34 +02:00
Antonio Scandurra
cf85bd032d Reimplement script/bootstrap 2016-08-02 14:04:45 +02:00
Antonio Scandurra
aa63162aed Move build to script 2016-08-02 09:24:02 +02:00