github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-28 03:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity
22,386 Commits 140 Branches 571 Tags
f9e80439d0c9caa40c2bd2070b236af1a13c20f7
Commit Graph

151 Commits

Author SHA1 Message Date
Kevin Sawicki
d9a5aff919 Add explicit return after for loop 2015-03-19 11:48:40 -07:00
Antonio Scandurra
0940c9216f Update also @startRow and @endRow on getState 2015-03-09 09:11:39 +01:00
Nathan Sobo
1e1eae4758 🎨 2015-02-28 10:57:32 -07:00
Antonio Scandurra
d05fe8a7d8 🎨 Remove repetitive batching code 2015-02-28 12:34:58 +01:00
Antonio Scandurra
ac01d3ec45 Remove newline 2015-02-28 10:10:42 +01:00
Antonio Scandurra
436322fc41 Call it onDidUpdateState 2015-02-28 09:36:56 +01:00
Antonio Scandurra
0dca5a5fcd Encapsulate state update inside TextEditorPresenter#getState 2015-02-28 09:25:53 +01:00
Antonio Scandurra
290acb356c 🎨 Remove unnecessary newlines 2015-02-27 21:01:46 +01:00
Antonio Scandurra
fbec9e31c4 Let's call it needsUpdate 😉 2015-02-27 20:54:00 +01:00
Antonio Scandurra
bcc99c163f Rename applyChanges to update 2015-02-27 20:42:04 +01:00
Antonio Scandurra
a4fe18abd5 🎨 Extract helpers and make code simpler 2015-02-27 19:53:54 +01:00
Antonio Scandurra
bf16287b16 🎨 Avoid entering/exiting from the outside 2015-02-27 16:59:59 +01:00
Antonio Scandurra
2f00d3e361 Batch on @requestUpdate 2015-02-27 15:10:17 +01:00
Antonio Scandurra
0948f1abdf Merge branch 'master' into batch-updates 2015-02-27 12:46:25 +01:00
Antonio Scandurra
af65849880 Move batching management down into presentation layer 2015-02-27 12:17:34 +01:00
Nathan Sobo
6a9abd1f66 🐎 Don’t blink cursors when editor isn’t focused 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2015-02-26 15:23:11 -07:00
Nathan Sobo
cd310dbe58 Rename ‘blinkCursorsOff’ to ‘cursorsVisible’ in presenter state 2015-02-26 15:21:47 -07:00
Antonio Scandurra
50f2aded3a Better batching 2015-02-26 11:26:48 +01:00
Antonio Scandurra
cbfbf84990 🐎 Introduce batching, and update UI accordingly 2015-02-25 17:40:39 +01:00
Antonio Scandurra
8f2df60eab 🎨 Refactor batchMode 2015-02-25 17:06:35 +01:00
Antonio Scandurra
ce8a5a210c Detect batch cursor move 2015-02-25 17:06:35 +01:00
Antonio Scandurra
b2bed7cea8 Detect batch selections 2015-02-25 17:06:34 +01:00
Antonio Scandurra
cc9ed043c7 🐎 Update needed cursors only 2015-02-24 16:39:39 +01:00
Nathan Sobo
2e8c5855d4 Don’t attempt to preserve mouseWheelScreenRow if it’s deleted 
Fixes #5527
 2015-02-23 10:51:16 -08:00
Nathan Sobo
e244aae7c0 Cache ::showIndentGuide config setting 2015-02-19 17:14:56 -07:00
Nathan Sobo
5ecefe7213 Update scoped config values in presenter when grammar changes 2015-02-19 17:14:56 -07:00
Nathan Sobo
156569f19e Add TextEditorPresenter::state.gutter.visible 2015-02-19 17:14:55 -07:00
Nathan Sobo
4654bad543 Add .focused to presenter state 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2015-02-19 17:14:55 -07:00
Nathan Sobo
8e27d8215a Store hidden input data in TextEditorPresenter::state 2015-02-19 17:14:54 -07:00
Nathan Sobo
c06e100fae Make LinesComponent a normal object instead of a React component 
Also, remove ability to disable hardware acceleration since there’s
no longer a need for it and it complicated this conversion.
 2015-02-19 17:14:53 -07:00
Nathan Sobo
55a70da3cf Hide scrollbars on mini editors 
Fixes #5548
 2015-02-13 19:37:27 -07:00
Max Brunsfeld
9517410ef4 Incrementally initialize presenter in random mutation spec 
Fix resulting failures

Signed-off-by: Nathan Sobo <nathan@github.com>
 2015-02-13 18:05:05 -08:00
Nathan Sobo
6a36bdda25 Replace ::hasRequiredMeasurements() with specific criteria in presenter 
Now each update method requires a list of specific variables to be
defined before running.
 2015-02-12 19:48:06 -07:00
Nathan Sobo
5b6990f14c Don’t update state in presenter unless prerequisites are defined 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2015-02-12 19:39:11 -07:00
Nathan Sobo
e739444800 Add an assertion when line is null in presenter 
Refs #5527
 2015-02-12 13:23:42 -07:00
Nathan Sobo
b3d03d032a 🐎 Read TextEditor::cursors directly to avoid allocation 2015-02-12 11:34:45 -07:00
Nathan Sobo
205d1df7b4 Precompute ::startRow and ::endRow in presenter 2015-02-12 11:34:45 -07:00
Nathan Sobo
cc80378b29 Precompute ::scrollTop in presenter 2015-02-12 09:36:44 -07:00
Nathan Sobo
54fcaa6132 Precompute ::scrollHeight and cache ::scrollPastEnd config value 2015-02-11 23:01:08 -07:00
Nathan Sobo
05554d03e4 Precompute ::scrollWidth 2015-02-11 22:53:38 -07:00
Nathan Sobo
fc603aaa0d Precompute ::clientHeight and ::clientWidth 2015-02-11 22:42:32 -07:00
Nathan Sobo
cf958ffeac Don’t cascade computed values unless upstream values change 2015-02-11 22:34:42 -07:00
Nathan Sobo
a3f902104c Precompute ::horizontalScrollbarHeight and ::verticalScrollbarWidth 2015-02-11 22:25:10 -07:00
Nathan Sobo
b6908b18b4 Precompute contentWidth 2015-02-11 22:06:11 -07:00
Nathan Sobo
be691b6a54 Precompute contentHeight and height 2015-02-11 22:04:05 -07:00
Nathan Sobo
6524da6594 🐎 Skip decoration marker changes if caused by text changes 
We’re already updating all decorations when text changes anyway, so
marker changes caused by text changes don’t need to perform updates
again.
 2015-02-11 19:41:39 -07:00
Nathan Sobo
e4168d70b7 Use computed clientWidth instead of contentFrameWidth as max scrollWidth 2015-02-11 11:47:18 -07:00
Nathan Sobo
7f0110f49e Update cursors as soon as all required measurements are assigned 2015-02-10 15:16:58 -07:00
Nathan Sobo
f5294454e6 Keep a minimum of 3 lines on screen when scrolling past end 2015-02-10 14:38:20 -07:00
Nathan Sobo
3e9b48ef71 Expand computed scrollHeight when editor.scrollPastEnd is enabled 2015-02-10 14:19:06 -07:00