github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-06 03:02:13 -04:00
Code Issues Packages Projects Releases Wiki Activity
19,710 Commits 140 Branches 571 Tags
fa96adc2ce1362a2b92b463fa5cfb0ac8242c21d
Commit Graph

10395 Commits

Author SHA1 Message Date
Nathan Sobo
d48719ab1c Ignore jQuery and duplicates in CommandRegistry::findCommands 
Now that jQuery has been patched to add inline listeners and inline
listeners are reported from findCommands, there’s no reason to include
commands based on $.fn.events. Also, we need to ensure the same command
doesn’t get added to the list twice since it could get added by both
inline and selector-based listeners.
 2014-11-10 10:09:24 -07:00
Max Brunsfeld
0c40a1ef92 Include inline commands in command palette 2014-11-10 10:09:24 -07:00
Nathan Sobo
bad0504e1d Attach active pane item view before showing/hiding 
Fixes #4112
 2014-11-10 10:06:12 -07:00
Nathan Sobo
0a92b6b681 Add Workspace::paneForItem 2014-11-10 08:20:59 -07:00
Nathan Sobo
efd3329c50 Prompt to save modified items when closing a pane via pane:close 
Fixes #4094
 2014-11-10 07:55:37 -07:00
Lee Dohm
d09c4010f6 Remove obsolete jQuery reference 
Noticed that "soon" is now
 2014-11-07 22:23:12 -08:00
Nathan Sobo
481e444ffe Reassign context to undefined because CoffeeScript needs a var keyword 
Fixes #4100
 2014-11-07 18:00:38 -07:00
Nathan Sobo
b8d2bd6c30 Disallow activation of panes that aren't in the PaneContainer 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2014-11-07 15:46:47 -07:00
Nathan Sobo
33fde29acb Disallow activation of destroyed panes 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2014-11-07 15:45:21 -07:00
Nathan Sobo
6934b83acc Fall back to first pane if activePaneId is invalid 
When deserializing PaneContainer.

Fixes #4069

Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2014-11-07 15:44:59 -07:00
Max Brunsfeld
003c101f14 W/o shadow-dom, don't add global atom-styles element for text editor 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2014-11-07 13:05:46 -08:00
Max Brunsfeld
98d602628a Render all stylesheets in atom-styles elements without contexts 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2014-11-07 12:56:32 -08:00
Nathan Sobo
ab395952a9 Dispose of ::scopedConfigSubscriptions when Editor is destroyed 2014-11-07 10:13:38 -07:00
Nathan Sobo
6e55c80d3c Dispose of ::scopedConfigSubscriptions when DisplayBuffer is destroyed 2014-11-07 10:09:55 -07:00
Ben Ogle
b29a61ec87 Update deprecation warning test 2014-11-06 15:19:49 -08:00
Ben Ogle
1ed927f213 Remove getPath() deprecation in project::scan 2014-11-06 14:49:13 -08:00
Nathan Sobo
baea6fcb49 Don’t assume SpacePen views implement ::unsubscribe 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2014-11-06 15:28:20 -07:00
Nathan Sobo
0bcfa591f6 Always throw exceptions when translating rows on destroyed DisplayBuffer 
Previously we only threw exceptions on non-release builds, but we
haven’t seen bundled packages cause issues in a while. Time to see what
third party packages cause problems.

Refs #3192
 2014-11-06 12:56:01 -07:00
Ben Ogle
50c705fea4 Remove unnecessary code 
cc @nathansobo as you meant to remove this originally
 2014-11-06 10:16:11 -08:00
Max Brunsfeld
26983adbdf Reduce ambiguity in config description 2014-11-06 09:42:20 -08:00
Max Brunsfeld
d97c81bf6a Make undo grouping interval configurable 2014-11-06 09:25:10 -08:00
Max Brunsfeld
d85c07e7e2 Don't wrap undo/redo calls in transactions 2014-11-05 16:59:06 -08:00
Max Brunsfeld
4077e791c9 Update signature of calls to TextBuffer::transact 2014-11-05 15:58:13 -08:00
Max Brunsfeld
e7eef89fa5 Remove TextEditor::withGroupingInterval 
Just use ::transact
 2014-11-05 15:58:13 -08:00
Max Brunsfeld
5437236304 Use undo grouping in editor command listeners 2014-11-05 15:58:13 -08:00
Max Brunsfeld
b7aa421e4e Add TextEditor::withGroupingInterval 
This method temporarily instructs the editor to apply undo grouping with
a given interval. This way, undo grouping can be made optional without
adding optional arguments to every buffer manipulation method.
 2014-11-05 15:58:12 -08:00
Ben Ogle
9458db0c1f Fix issue removing panels 2014-11-05 15:37:47 -08:00
Ben Ogle
80c15513bb Fix typos 2014-11-05 15:36:39 -08:00
Nathan Sobo
670b44f250 Only set both height and width of editor when shadow DOM is used 
These work inside a shadow root, but break the flexbox behavior when
the shadow DOM is disabled.
 2014-11-05 11:21:29 -07:00
Kevin Sawicki
8bd2650d01 Merge pull request #4064 from atom/pass-path-env 
Pass $PATH by command line
 2014-11-05 09:40:04 -08:00
Nathan Sobo
39cc463e24 Add .editor and .editor-colors classes regardless of shadow DOM setting 2014-11-05 09:57:13 -07:00
Nathan Sobo
2c83c3fe17 Merge pull request #3943 from atom/ns-text-editor-shadow-dom 
Render text editor contents inside shadow DOM
 2014-11-05 09:42:07 -07:00
Nathan Sobo
07505ea82a Support any instance of jQuery in view registry logic 2014-11-05 09:33:31 -07:00
Nathan Sobo
47d3b3edf3 Add jQueryTrigger: true to command detail in $.fn.trigger patch 
Attention: @benogle
References: atom/metrics#32
 2014-11-05 09:28:35 -07:00
Cheng Zhao
6a58f6054a Pass $PATH by command line 2014-11-05 12:11:42 +08:00
Nathan Sobo
badf1725fa Handle focus on hidden input when shadow DOM is disabled 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2014-11-04 16:37:29 -07:00
Nathan Sobo
2b2149bca1 Add config schema for editor.useShadowDOM 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2014-11-04 16:37:28 -07:00
Nathan Sobo
100af7d27d Fix corner cases related to lifecycle state of EditorComponent on events 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2014-11-04 16:37:28 -07:00
Nathan Sobo
9b70cf2044 Make blur event on text editor element work with shadow DOM disabled 
When the shadow DOM is enabled, this happens organically because the
focus is abstracted across the shadow boundary. Without that abstraction
boundary, we need to pretend that a blur of the hidden input is actually
a blur of the entire editor.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2014-11-04 16:37:28 -07:00
Nathan Sobo
7fe9c14772 💄 2014-11-04 16:37:28 -07:00
Nathan Sobo
9690e44ffe Correctly handle focus when shadow DOM is disabled 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2014-11-04 16:37:27 -07:00
Nathan Sobo
0e57ede712 Only create a shadow root if editor.useShadowDOM config setting is true 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2014-11-04 16:37:27 -07:00
Nathan Sobo
dd7335c30b Simplify focus/blur handling 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2014-11-04 16:37:27 -07:00
Nathan Sobo
160bb29034 Null-guard component in blur handler 2014-11-04 16:37:27 -07:00
Nathan Sobo
497b4a4e24 Toggle quotes back 2014-11-04 16:37:27 -07:00
Nathan Sobo
d060ecdc24 Assign package stylesheet context based on double-extension in file name 
If stylesheet files are named with 2 extensions, the first extension is
used as the context argument when the package’s stylesheets are loaded.
This allows people to target the text editor by naming their stylesheet
`index.atom-text-editor.less`.
 2014-11-04 16:37:26 -07:00
Nathan Sobo
6f3c53a17a Only cancel focus events if the editor is or contains the related target 2014-11-04 16:37:26 -07:00
Nathan Sobo
dd17e8f018 Replace focusout event handlers on hiddenInput shim with blur handlers 
The focusout event doesn’t seem to work for elements in the shadow DOM.
Other people seem to share this experience:

https://code.google.com/p/chromium/issues/detail?id=378163#c7
 2014-11-04 16:37:26 -07:00
Nathan Sobo
cf3f1aa2eb Don’t handle text editor focus when it already has focus 2014-11-04 16:37:26 -07:00
Nathan Sobo
adaf1829da Determine focus using document.activeElement instead of component state 2014-11-04 16:37:26 -07:00