391 Commits

Author SHA1 Message Date
Kevin Sawicki
4bb7e0f323 === not !== for no-quiet check 2014-07-02 13:55:58 -07:00
Kevin Sawicki
7b09fc04da Don't ignore stdout when --no-quiet is set 2014-07-02 13:51:52 -07:00
Kevin Sawicki
1090746cb1 Add --no-quiet option to script/bootstrap
This will run apm/npm commands without the --quiet flag to get more
output on failures.
2014-07-02 13:46:12 -07:00
Kevin Sawicki
4bade1c976 💄 2014-06-13 15:40:46 -07:00
Kevin Sawicki
858e7b62a3 Remove logging 2014-06-13 15:25:13 -07:00
Kevin Sawicki
28015339d9 Add some logging 2014-06-13 15:19:20 -07:00
Kevin Sawicki
ca86e0258f Only log error code 2014-06-13 15:12:06 -07:00
Kevin Sawicki
87fcc39045 Add missing path segment 2014-06-13 15:11:16 -07:00
Kevin Sawicki
b78ff8c3a9 Load atomcredentials on Windows 2014-06-13 15:05:36 -07:00
Kevin Sawicki
34be92b5b0 Log message for all commands
The first time you bootstrap, all the build modules and apm are
installed. Previously this was showing no output so it was unclear
whether things are hung or now.

This will also help easily identify which stage of the build
npm and node-gyp errors are occurring.
2014-06-13 10:06:45 -07:00
Corey Johnson
01b4ff24b9 Dedupe grim 2014-06-11 16:50:45 -07:00
Kevin Sawicki
31cf907b48 💄 2014-06-10 16:54:25 -07:00
James R Sconfitto
f5a70da6f0 🏁 Use "npm.cmd" to verify npm 2014-06-10 17:26:57 -04:00
Kevin Sawicki
fe088ba16a Use local npm version when available 2014-06-10 11:45:47 -07:00
Kevin Sawicki
634c995a71 Verify npm version
This will end up in log output when people report build issues and now
the bootstrap will error when the npm version is <1.4.
2014-06-10 11:05:29 -07:00
Kevin Sawicki
389b5c7891 Remove script/install-cli
The CommandInstaller class now has native module dependencies that are
compiled with apm so invoking it directly from node is no longer possible.

This can still be done using the grunt install task.

Closes #2555
2014-06-09 11:02:26 -07:00
Cheng Zhao
35c2ef09a0 Support generating i386 deb file. 2014-06-07 14:09:03 +08:00
Kevin Sawicki
f31cc1b0da Return early when skipping remove command 2014-06-06 08:58:34 -07:00
Kevin Sawicki
3b6711d83d Only spawn removed command for paths that exist
Prevents errors being logged when trying to remove folders that
don't exist on Windows.
2014-06-06 08:56:13 -07:00
Radu Micu
8e6dcf43b0 better script/clean removal for windows
Now `script/clean` uses `del /F /Q /S` to cleanup the folders but `del /S` deletes specified files from all subdirectories, so if we pass a folder as a parameter it will only delete the files within the folder and all subfolders recursively but not the actual folders. And this can cause problems, see Issue #2487

A better way is to use `rmdir /S /Q` as it takes care of the folder itself and it's contents.
/S - removes all directories and files in the specified directory in addition to the directory itself. (removes the directory tree)
/Q - obvious this is quite mode

I tested this approach on a couple machines that needed a clean before building and works OK with `rmdir`. It might give a warning in the console like `The system cannot find the file specified.` because not all of them are there but it can be ignored as the script will finish running.
2014-06-06 11:26:43 +01:00
Kevin Sawicki
0c0f143f91 Only print python version when checked 2014-06-05 08:53:02 -07:00
onkrot
c1ce1e624d Changing mkdeb script 2014-06-05 09:29:01 +06:00
Corey Johnson
c167166add Merge pull request #2457 from atom/cj-add-python-check
Create requirement verifier for script/bootstrap
2014-06-04 14:43:30 -07:00
probablycorey
fbcb152107 Reorder if/else check 2014-06-04 14:07:59 -07:00
probablycorey
51183f4be5 Use process.exit 2014-06-04 13:14:00 -07:00
probablycorey
2e5c844d46 Use childProcess directly 2014-06-04 12:44:51 -07:00
probablycorey
0b088e8b72 💄 2014-06-04 12:34:18 -07:00
probablycorey
1479197ffb Add better python error message 2014-06-04 12:32:14 -07:00
probablycorey
c79c7b7a98 Make all verify requirements methods take callbacks
This moves the error handling to bootstrap and also allows us to 
display a success message.
2014-06-04 12:16:16 -07:00
probablycorey
3ead596a5d Assume the PYTHON env points to python.exe 2014-06-04 11:44:52 -07:00
probablycorey
99af9e2c33 Update error messages 2014-06-04 11:10:14 -07:00
probablycorey
b7bd11a883 Reuse pythonExecutable variable 2014-06-04 11:09:50 -07:00
probablycorey
1ac40b2673 Mimic Atom’s if/else style convention 2014-06-04 10:55:10 -07:00
probablycorey
5434a26636 Rename postVerification method to bootstrap 2014-06-04 10:53:05 -07:00
James R Sconfitto
3f8d7d54cf 🏁 Verify python version for build
References:
56dcb88909/lib/configure.js
2014-06-03 22:20:33 -04:00
Kevin Sawicki
6e1efdf2ee Check for that grunt command exists before spawning 2014-06-03 12:10:37 -07:00
probablycorey
57531d75fe Add better python path description 2014-05-30 11:01:22 -07:00
probablycorey
0fdceb8474 Update bootstrap requires 2014-05-30 09:36:29 -07:00
probablycorey
041ec8c7cf Use verifyRequirements in script/bootstrap 2014-05-30 09:31:53 -07:00
probablycorey
07e64152be Add verify-requirements util 2014-05-30 09:31:42 -07:00
Kevin Sawicki
5f359a4271 💄 2014-05-28 18:36:42 -07:00
Kevin Sawicki
ae1dd6e876 Add missing comma 2014-05-28 18:31:20 -07:00
Kevin Sawicki
d1bd2113bf Install npm into build/ folder 2014-05-28 18:30:27 -07:00
Corey Johnson
b9753a0785 Force npm to be installed on cibuilds 2014-05-27 10:34:11 -07:00
probablycorey
6f0882a098 Merge remote-tracking branch 'origin/master' into cj-windows-build-instructions-update
Conflicts:
	docs/build-instructions/windows.md
2014-05-20 09:51:08 -07:00
Pritam Baral
25d2206471 Consolidate redundant code 2014-05-19 23:57:48 +05:30
Pritam Baral
f5c3bdb845 Use os.tmpdir() on Linux
/tmp isn't always available, is on precious RAM-backed fs or simply not
what the user has set his $TMPDIR to. According to the specification, we
should use $TMPDIR, which node lets us find through os.tmpdir().

Also, contributing.md isn't in favour of using platform-dependent code.

This commit focusses only on Linux, and leaves OS X as is with /tmp for
discussion.
2014-05-19 23:57:48 +05:30
Kevin Sawicki
a83a6e5127 Explicitly set permissions on temp folder
Refs #2129
2014-05-16 14:47:55 -07:00
Kevin Sawicki
7f442d045b Check for errors in script/mkdeb
Refs #2129
2014-05-16 12:54:24 -07:00
Corey Johnson
f30c56c237 Don't require 32bit node 2014-05-15 14:55:58 -07:00