16 Commits

Author SHA1 Message Date
Kevin Sawicki
f31cc1b0da Return early when skipping remove command 2014-06-06 08:58:34 -07:00
Kevin Sawicki
3b6711d83d Only spawn removed command for paths that exist
Prevents errors being logged when trying to remove folders that
don't exist on Windows.
2014-06-06 08:56:13 -07:00
Radu Micu
8e6dcf43b0 better script/clean removal for windows
Now `script/clean` uses `del /F /Q /S` to cleanup the folders but `del /S` deletes specified files from all subdirectories, so if we pass a folder as a parameter it will only delete the files within the folder and all subfolders recursively but not the actual folders. And this can cause problems, see Issue #2487

A better way is to use `rmdir /S /Q` as it takes care of the folder itself and it's contents.
/S - removes all directories and files in the specified directory in addition to the directory itself. (removes the directory tree)
/Q - obvious this is quite mode

I tested this approach on a couple machines that needed a clean before building and works OK with `rmdir`. It might give a warning in the console like `The system cannot find the file specified.` because not all of them are there but it can be ignored as the script will finish running.
2014-06-06 11:26:43 +01:00
Pritam Baral
25d2206471 Consolidate redundant code 2014-05-19 23:57:48 +05:30
Pritam Baral
f5c3bdb845 Use os.tmpdir() on Linux
/tmp isn't always available, is on precious RAM-backed fs or simply not
what the user has set his $TMPDIR to. According to the specification, we
should use $TMPDIR, which node lets us find through os.tmpdir().

Also, contributing.md isn't in favour of using platform-dependent code.

This commit focusses only on Linux, and leaves OS X as is with /tmp for
discussion.
2014-05-19 23:57:48 +05:30
Kevin Sawicki
950964eee3 Remove directory that no longer exists 2014-04-24 15:43:35 -07:00
Kevin Sawicki
fea958c8e4 Clean ~/.atom/compile-cache 2014-04-17 18:32:22 -07:00
Cheng Zhao
645fc1511a Do not add parameter in shebang string.
On Linux "#!/usr/bin/env node --harmony_collections" is unfortunately
not recognized by system.
2014-03-25 15:40:43 +08:00
Kevin Sawicki
71abe66b8f Put npm cache in ~/.atom/.npm 2014-03-04 10:19:20 -08:00
Kevin Sawicki
12bf0f5381 Delete apm's node_modules folders on clean 2014-01-13 14:51:24 -08:00
Kevin Sawicki
401ef87bb2 Clean build/node_modules folder 2014-01-03 08:32:23 -08:00
Kevin Sawicki
902406c572 Enable harmony collections in all scripts 2013-12-31 14:40:45 -08:00
Kyle Robinson Young
ed4b50e3b4 Rename removeCommand and set tmpdir to /tmp on osx/linux. 2013-12-16 17:51:20 -08:00
Kyle Robinson Young
d526cfcba0 Change .node-type to .node-gyp in clean script 2013-12-16 17:51:20 -08:00
Kyle Robinson Young
0cf2cdceea Ability to delete without node_modules 2013-12-16 17:51:20 -08:00
Kyle Robinson Young
8239bb7e05 Add clean script 2013-12-16 17:51:20 -08:00