Kevin Sawicki
a2eb4d9303
Keep Packages submenu sorted
...
This ensures packages are in a predictable order regardless of whether
they are bundled or installed to ~/.atom/packages
Closes #3155
2014-08-12 18:16:00 -07:00
Kevin Sawicki
c0a845bc56
Don't run ~/.atom/packages specs when in safe mode
...
Closes #3215
2014-08-12 17:49:33 -07:00
Ben Ogle
6632a1c63d
Merge pull request #3244 from atom/bo-stop-propagation
...
Stop propagation on all commands in the editor
2014-08-12 17:08:22 -07:00
Ben Ogle
ce5eff100c
Stop propagation on all commands
2014-08-12 16:54:43 -07:00
Nathan Sobo
94f40f0ed9
Only allow ReactEditorView::beforeRemove to run once
2014-08-12 17:40:53 -06:00
Nathan Sobo
640881a15e
Destroy the editor when an EditorComponent is unmounted
...
Fixes #3222
2014-08-12 17:40:53 -06:00
Kevin Sawicki
ee6c4d7b65
Merge pull request #3243 from kaiserfro/remove-unnecessary-getScrollWidth-params
...
Remove unnecessary params from Editor::getScrollWidth
2014-08-12 16:35:54 -07:00
Jeffrey Oliver
a37aeba909
Remove unnecessary params from Editor::getScrollWidth
2014-08-12 16:33:22 -07:00
Kevin Sawicki
2449fda01d
Merge pull request #3230 from atom/ks-really-kill-buffered-process-on-windows
...
Really kill buffered processes on windows
2014-08-12 16:30:30 -07:00
Kevin Sawicki
b572594f92
Ignore errors from process object
2014-08-12 16:15:42 -07:00
Kevin Sawicki
fbde059748
Ignore errors killing child processes
2014-08-12 16:15:42 -07:00
Kevin Sawicki
6084ef52e7
Ensure pid is positive
2014-08-12 16:15:42 -07:00
Kevin Sawicki
a9f4dfc6b7
Split on whitespace when parsing pids
2014-08-12 16:15:42 -07:00
Kevin Sawicki
8032d6dab2
Return undefined from BufferedProcess::kill
2014-08-12 16:15:42 -07:00
Kevin Sawicki
01ec449fce
Kill parent process after children on Windows
2014-08-12 16:15:42 -07:00
Kevin Sawicki
e79d66497c
Remove comment about killing process
2014-08-12 16:15:41 -07:00
Kevin Sawicki
a205c6d190
Use wmic to kill child processes
2014-08-12 16:15:41 -07:00
Nathan Sobo
2911b395ee
Handle 'focus' events in ReactEditorView and transfer to the component
...
Fixes #3234
2014-08-12 17:15:19 -06:00
Nathan Sobo
64c25f17df
Shim ReactEditorView::mini property
2014-08-12 17:15:19 -06:00
Ben Ogle
f0fbdc9842
Revert "Sometimes there might not be a selection."
...
This reverts commit a73e6e5bd0
2014-08-12 15:54:32 -07:00
Ben Ogle
e2c41136f3
preventDefault -> cancel()
2014-08-12 15:35:54 -07:00
Ben Ogle
8b20e2e031
Remove duplicate getModel()
2014-08-12 15:32:18 -07:00
Ben Ogle
722d8cb48b
Need to return a range when the text is inserted
2014-08-12 15:30:19 -07:00
Ben Ogle
a73e6e5bd0
Sometimes there might not be a selection.
2014-08-12 15:30:02 -07:00
Ben Ogle
4cf68ef017
::getModel() returns the editor
2014-08-12 15:29:47 -07:00
Ben Ogle
b037395551
Add will-insert-text and did-insert-text to insertText()
2014-08-12 15:28:26 -07:00
Ben Ogle
7a26a16511
Only focus when the component is mounted
2014-08-12 15:28:13 -07:00
Ben Ogle
7de2ad34aa
Remove opaque backgrounds on mini editors
...
Fixes #3239
2014-08-12 14:53:09 -07:00
Kevin Sawicki
7de2f57088
💄
2014-08-12 09:37:48 -07:00
Kevin Sawicki
1488867063
Remove hiding of body during reload
...
This appears to no longer be needed on Chrome 36
2014-08-12 08:49:28 -07:00
Kevin Sawicki
59d62d48db
Remove views and destroy project during unload
2014-08-12 08:49:28 -07:00
Kevin Sawicki
97c2fc09f0
Only unload editor window when confirmed
2014-08-12 08:49:28 -07:00
Kevin Sawicki
16d2e41309
Use beforeunload instead of unload
...
unload is asynchronous in Chrome 36 and so saving the state while
reloading may not happen before the state is read on the new render
process.
2014-08-12 08:49:28 -07:00
Kevin Sawicki
f447781e01
Allow any bundled theme when in safe mode
...
Check enabled names against the bundled names and ensure
one bundled UI and one bundled syntax theme are enabled,
defaulting to the dark themes when necessary.
2014-08-11 15:24:49 -07:00
Kevin Sawicki
070d9d0b46
Merge pull request #3186 from maschs/ms-safeModeThemes
...
Load the default themes in safe mode
2014-08-11 14:51:14 -07:00
Luca Moser
28a0e94bb9
Fixes unexecutable commands on win32 in BP
...
Signed-off-by: Luca Moser <moser.luca@gmail.com >
2014-08-11 20:24:57 +02:00
Nathan Sobo
84064a811c
:non_potable_water: Unsubscribe from window resize in EditorComponent
...
This fixes a major memory leak
2014-08-07 04:59:02 -06:00
Maximilian Schüßler
b463d9d876
Load the default themes in safe mode
2014-08-05 13:32:16 +02:00
Nathan Sobo
7e45ffa4c3
Center around the cursor in Editor::scrollToCursorPosition by default
...
Fixes #3131
2014-08-04 11:58:07 -06:00
Nathan Sobo
6e72627e9e
Stop propagation of keydown/textInput events to prevent React handler
...
React's global synthetic event handler is somewhat expensive. This
prevents it from being invoked on every keystroke, saving ~1ms.
2014-07-31 15:11:06 -06:00
Kevin Sawicki
18016ae9df
💄 Use unless instead of if not
2014-07-31 08:33:36 -07:00
Maximilian Schüßler
62b52cb70a
In devmode do not load incompatible from cache
2014-07-31 16:24:29 +02:00
Nathan Sobo
0f77a2eef9
Only unmount ReactEditorView's component before removing if its mounted
...
Fixes #3108
Unmounting the component the first time can cause a focusout event,
which leads to a redundant removal and an attempt to unmount again. This
protects against that.
2014-07-29 20:02:01 -06:00
Nathan Sobo
f8e2231dfc
Increase overdraw margin to avoid intermittent full screen repaints
...
On Chromium 35, the screen seems to be full-screen painting on a Cinema
Display every few frames, causing frame rates to drop from 60 to 30 when
autoscrolling with the cursor. Increasing the overdraw avoids this.
2014-07-28 21:57:06 -06:00
Nathan Sobo
4f3570b56b
Merge pull request #3106 from atom/ns-react-css-font-styling
...
Apply React editor font styles via CSS instead of inline styles
2014-07-28 21:08:51 -06:00
Nathan Sobo
8918a42b3b
Merge pull request #3104 from dmnd/react-dev-mode
...
Show detailed React errors/warnings in devMode
2014-07-28 21:02:11 -06:00
Nathan Sobo
bd77a02207
Measure DOM in EditorComponent when a stylesheet is updated
2014-07-28 21:00:15 -06:00
Nathan Sobo
eebbb99fc8
Handle editor font config options with a global stylesheet
...
Previously, each editor observed font-related config values on its own
and applied inline styles to honor them. This made it difficult to style
the editor like a normal element with CSS.
Moving this to a global stylesheet that targets editors via the .editor
selector means that the font size setting can be overridden in specific
contexts, such as when using mini editors.
2014-07-28 21:00:15 -06:00
Nathan Sobo
2b27c0b440
Only handle stylesheet changes after initial measurement
2014-07-28 20:59:28 -06:00
Nathan Sobo
8e69b0c4a0
Base font styling on the computed style of the editor element
...
Previously, font styling was always explicitly assigned via the config.
This commit is the first step in basing the font styling of the editor
on the styles assigned via CSS. This will allow the editor's
font-family, font-size, and line-height to be assigned via CSS just like
they are for any other element, which will make it easier to style mini
editors.
We still need to switch the font settings to adjust a global stylesheet
rather than updating inline styles on each editor individually.
2014-07-28 20:59:28 -06:00
