Nathan Sobo
3dbaa0679b
Merge pull request #3587 from atom/ns-workspace-view-providers
...
Add view provider API to Workspace
2014-09-23 13:08:00 -06:00
Ben Ogle
3bc115a7a0
Merge pull request #3606 from atom/bo-model-placeholder-text
...
Model EditorView::setPlaceholderText
2014-09-23 11:20:23 -07:00
Ben Ogle
169a5de6a3
not.toBeDefined -> toBeUndefined
2014-09-23 10:38:38 -07:00
Ben Ogle
4606ce2d50
Model setPlaceholderText
...
Less dependence on the editorView!
2014-09-22 17:21:42 -07:00
Ben Ogle
c62fb26001
onDidChangeSelectionRange emits object with ranges + selection
2014-09-22 16:08:12 -07:00
Ben Ogle
5083c18c84
Add cursor to onDidChangeCursorPosition event object
2014-09-22 15:37:41 -07:00
Kevin Sawicki
dc3a3225b3
Remove logging from specs
2014-09-22 15:00:06 -07:00
Ben Ogle
6e8cfba440
nof
2014-09-22 11:07:53 -07:00
Ben Ogle
7a429b024e
Use GitRepository rather than Git
2014-09-22 11:07:41 -07:00
Nathan Sobo
ddb85abe77
Don’t add the same editor to two different panes in spec
2014-09-19 16:30:37 -06:00
Nathan Sobo
55cce48af1
Throw an exception if the same pane item is added twice in the workspace
2014-09-19 16:24:13 -06:00
Nathan Sobo
d344adc21e
Allow view providers to specify a createView factory method
...
If present, it will be called with the model object instead of
instantiating the view constructor directly and assigning a model on it.
This gives users more flexibility when constructing views.
2014-09-19 16:24:13 -06:00
Nathan Sobo
74d772f069
Rename view/modelClass to view/modelConstructor in view provider specs
...
It’s a more technically correct term. You use a class keyword to declare
these things, but the actual objects you pass around to talk about them
are constructor functions.
2014-09-19 16:24:13 -06:00
Nathan Sobo
e2e804483f
Return disposable from ViewRegistry::addViewProvider
2014-09-19 16:24:13 -06:00
Nathan Sobo
b5499247b3
Use view providers to build views if a matching provider is available
2014-09-19 16:24:13 -06:00
Nathan Sobo
54378b11d4
Isolate ViewRegistry specs
2014-09-19 16:24:12 -06:00
Nathan Sobo
0877721ce9
Construct PaneAxisViews and PaneViews via ViewRegistry
2014-09-19 16:24:12 -06:00
Nathan Sobo
7f41be3103
Use atom.workspace.getView to construct WorkspaceViews
...
It returns the root DOM node of the workspace. Eventually this will
be a custom element but for now it’s just a DOM node with a
__spacePenView reference on it.
2014-09-19 16:24:12 -06:00
Nathan Sobo
7baa3b6f09
Start on Workspace::getView
2014-09-19 16:24:12 -06:00
Kevin Sawicki
ee093d1709
Merge pull request #3582 from atom/ks-dont-allow-focused-specs-on-ci
...
Fail focused specs on CI
2014-09-18 16:16:17 -07:00
Ben Ogle
155d4ce733
Merge pull request #3569 from atom/bo-proper-doc-marker
...
Rename DisplayBufferMarker to Marker
2014-09-18 16:14:35 -07:00
Kevin Sawicki
021278e902
Always auto indent at least one hard tab
...
Previously when the delta between the suggested and current indent level
was greater than zero but less than one, no text would be inserted since
Editor::buildIndentString returns an empty string for levels less than one
when using hard tabs.
Closes #3575
2014-09-18 15:36:31 -07:00
Kevin Sawicki
597942c4ac
Fail focused specs on CI
...
This ensures focused specs never end up as green builds
2014-09-18 15:18:42 -07:00
Kevin Sawicki
7f3279e789
Unfocus spec
2014-09-18 14:50:36 -07:00
Ben Ogle
9af2325f17
Rename DisplayBufferMarker -> Marker
...
Gnar!! 😎
2014-09-18 13:53:12 -07:00
Ben Ogle
cef8b95ef3
Deprecate s|getAttributes for s|getProperties
2014-09-18 13:53:12 -07:00
Kevin Sawicki
31dd109343
Add Editor::onDidDestroy
2014-09-18 11:51:44 -07:00
Kevin Sawicki
c37e4649b5
Only call replace on string arguments
...
Prevents errors being thrown when trying to call replace on non-string
arguments.
2014-09-18 11:31:29 -07:00
Kevin Sawicki
3fb22f123a
Don't throw errors when folding comments
...
Previously trying to fold single line comments at the start/end
of files would throw errors since the +1 and -1 used in the
index ranges would cause the loop to advance past the last row
or before the first row.
2014-09-18 11:06:25 -07:00
Ben Ogle
8448b265d5
Merge pull request #3549 from atom/bo-visibility-split
...
Add sections and split methods into essential / extended API
2014-09-17 16:51:50 -07:00
Nathan Sobo
d36c738b07
Merge pull request #3469 from atom/ns-command-registry
...
Add command registry
2014-09-17 14:55:19 -06:00
Kevin Sawicki
f1fd13b0b2
Return as soon as first paired character is found
...
Previously the character count of the entire string was taken even
though it was only checking for the presence of a paired character.
Now hasPairedCharacter returns as early as possible and the now
unused getCharacterCount has been removed.
2014-09-17 10:35:33 -07:00
Kevin Sawicki
e343b0e0fc
Don't treat consecutive variation selectors as a sequence
2014-09-17 10:17:27 -07:00
Kevin Sawicki
3acddf3e71
📝 Drop text
2014-09-17 10:17:26 -07:00
Kevin Sawicki
df68ae26a2
Add specs for variation sequences
2014-09-17 10:17:26 -07:00
Kevin Sawicki
fb7061f500
📝 Mention variation sequence in specs
2014-09-17 10:17:26 -07:00
Kevin Sawicki
878da262d2
Add support for Unicode variation sequences
...
These are character pairs that should be treated as tokens with a
buffer delta of 2 and a screen delta of 1.
2014-09-17 10:17:26 -07:00
Kevin Sawicki
36f60c517e
Assert other whitespace class is not present
2014-09-17 09:50:55 -07:00
Kevin Sawicki
348f865cab
Add spec for all whitespace lines
2014-09-17 09:47:49 -07:00
Kevin Sawicki
18f54e6780
💄 Put leading spec first
2014-09-17 09:42:31 -07:00
Kevin Sawicki
b281737838
Add leading/trailing classes to hard tab tokens
...
Previously the leading-whitespace and trailing-whitespace classes
were never added to tokens that were hard tabs.
2014-09-17 09:42:31 -07:00
Ben Ogle
c0dd53104a
Make a managing the atom window section
...
de-public the get/setWindowDimensions in favor of
the (get|set)(Size|Position)
2014-09-16 11:37:11 -07:00
Ben Ogle
f12b70e3b7
Editor::onDidChangeScreenLines -> onDidChange
2014-09-16 10:51:32 -07:00
Nathan Sobo
eb97154c94
Merge remote-tracking branch 'origin/master' into ns-command-registry
2014-09-16 10:27:00 -06:00
Nathan Sobo
a069f34ad6
Fix CommandRegistry::findCommands spec
...
Don’t assert against commands registered on the window with jQuery
2014-09-16 09:23:52 -06:00
Nathan Sobo
a0edb92e16
Rename editor.softWrapped config option back to editor.softWrap
2014-09-15 14:34:35 -06:00
Kevin Sawicki
8c2bcf3943
Catch and log deactivate errors
...
Closes #3538
2014-09-15 08:34:54 -07:00
Kevin Sawicki
e6252546c4
Set initialLoadComplete to true in specs
2014-09-11 15:49:44 -07:00
Nathan Sobo
8f9cf3c790
Set the atom.commands root node to document.body in beforeEach
2014-09-11 14:17:45 -06:00
Nathan Sobo
99cf8fabc0
Clear atom.commands after each spec
2014-09-11 14:13:48 -06:00
