Nathan Sobo
49cd3eb5da
Clear window.setTimeout mock before each spec
...
This fixes a failure in the keymap spec where we assert that setTimeout
hasn’t been called.
2015-01-13 10:17:48 -07:00
Nathan Sobo
7f8ab72f53
Capitalize initialisms
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 22:00:24 -08:00
Kevin Sawicki
640f8920fb
Fix bounds checking of alpha
2015-01-12 17:34:43 -08:00
Kevin Sawicki
44939a12a0
Validate color properties when set
2015-01-12 17:34:43 -08:00
Kevin Sawicki
b8822b32db
Only coerce strings and plain objects
2015-01-12 17:34:43 -08:00
Kevin Sawicki
8c39818670
Don't blow up when asking for schema at non-existent path
2015-01-12 17:34:43 -08:00
Kevin Sawicki
5a2c208804
Add specs with invalid objects
2015-01-12 17:34:43 -08:00
Kevin Sawicki
fc899f54cf
Add specs for setting with an object
2015-01-12 17:34:42 -08:00
Kevin Sawicki
b923b57bcc
Add specs for hsl and hsla colors
2015-01-12 17:34:42 -08:00
Kevin Sawicki
319ec244e1
Add spec for invalid values
2015-01-12 17:34:42 -08:00
Kevin Sawicki
1267a1e14e
Add spec for default color value
2015-01-12 17:34:42 -08:00
Kevin Sawicki
0411f1584c
Add color schema type
2015-01-12 17:34:42 -08:00
Nathan Sobo
dd80226c23
Revert "Handle addition/removal of ‘gutter-hidden’ attribute"
...
This reverts commit 6926236268 .
There seems to be some bug or timing issue that prevents the
attachedCallback from being called in all cases when the
attributeChangedCallback is defined. We can figure this out at
a later time.
2015-01-12 17:39:07 -07:00
Nathan Sobo
6926236268
Handle addition/removal of ‘gutter-hidden’ attribute
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 16:21:31 -07:00
Nathan Sobo
43f57347d7
Add ‘gutter-hidden’ attribute to TextEditorElement
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 16:21:31 -07:00
Nathan Sobo
c0b78db159
💄
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 16:21:31 -07:00
Nathan Sobo
002918049d
🐎 Cache gutterVisible state in React component
...
This avoids a config read on every render.
2015-01-12 16:21:31 -07:00
Nathan Sobo
f00b0b7f7a
Add TextEditor::set/isGutterVisible
...
Controls gutter visibility on individual editors.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-12 16:21:31 -07:00
Max Brunsfeld
174b7072b7
Add specs for Task events
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-01-09 16:59:13 -08:00
Lee Dohm
acb19c1fe1
Log scopes to notification instead of console
...
Fixes #4969
2015-01-09 16:33:48 -08:00
Nathan Sobo
d26c19a0ec
Deprecate Project::resolve
...
It’s not something that will make sense once we add the ability to have
multiple directories in a project. This adds a new private method on
Project, ::resolvePath, with the original implementation for convenience
until we actually implement multi-folder projects.
2015-01-09 15:03:07 -08:00
Max Brunsfeld
f9bde050b4
Handle TextEditorElement::focus() while parent is being attached
...
Fixes atom/autocomplete#61
2015-01-09 15:00:35 -08:00
Nathan Sobo
19bf64f3cd
Revert "Deprecate Project::resolve"
...
This reverts commit 3c5bd9f10a .
2015-01-09 13:58:01 -08:00
Nathan Sobo
3c5bd9f10a
Deprecate Project::resolve
...
It’s not something that will make sense once we add the ability to have
multiple directories in a project.
2015-01-09 13:40:35 -08:00
Nathan Sobo
0a5b4f9b33
Make “style sheet” two words in package.json metadata
...
Rename `stylesheets` -> `styleSheets`
Rename `stylesheetsMain` -> `mainStyleSheet`
2015-01-09 09:04:04 -08:00
Nathan Sobo
932d3755ce
Rename stylesheets/ directory in fixture packages
2015-01-09 08:56:12 -08:00
Nathan Sobo
37ba67728b
Fix core deprecations
2015-01-09 08:24:48 -08:00
Nathan Sobo
7f9d06f55b
Move TextEditor::pixelPositionForScreen/BufferPosition to view layer
...
It doesn’t make sense to talk about pixels at the model layer long-term,
even though we currently store view dimension information in the model
so we don’t have to read from the DOM for optimization purposes. This
information is only available if the view is attached, however, making
these methods a liability on the model layer.
2015-01-09 08:22:45 -08:00
Nathan Sobo
4ab33890fc
Add PackageManager::onDidLoad/UnloadPackage
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:11 -08:00
Nathan Sobo
7acf3d4d6b
Add PackageManager::onDidDeactivatePackage
2015-01-08 17:51:11 -08:00
Nathan Sobo
6dd9834ae1
Remove defunct text-mate package specs
2015-01-08 17:51:11 -08:00
Nathan Sobo
a6c9244c77
Add PackageManager::onDidActivatePackage
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:11 -08:00
Nathan Sobo
dbc88bde18
Remove special case in spec for packages converted from text-mate
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:11 -08:00
Nathan Sobo
18ac0091a8
Don’t call onDidActivateInitialPackages listeners until the right time
...
We wait until all packages without activation commands actually
activate.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:11 -08:00
Nathan Sobo
30513cfde0
Rename ThemeManager methods for clarity/consistency
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-01-08 17:51:09 -08:00
Kevin Sawicki
fb3cc5554c
Catch errors spawning squirrel
...
Closes #4895
2015-01-07 10:24:19 -08:00
Kevin Sawicki
6fe7eb086f
Gracefully handle empty keymaps and menus
...
Closes atom/settings-view#310
2015-01-07 09:18:57 -08:00
Nathan Sobo
462af79d21
Fix deprecation suppression in specs
2015-01-07 10:12:04 -07:00
Nathan Sobo
7dd67caf57
Remove ‘group’ parameter to addStyleSheet in favor of ‘priority’
2015-01-07 09:51:42 -07:00
Nathan Sobo
2c1f8ce733
Set the style element priority based on the group
...
This ensures that elements are always in the desired order regardless
of the order the groups are added.
2015-01-06 19:41:57 -07:00
Nathan Sobo
94e12ee886
Handle priority in when inserting style elements in style manager
2015-01-06 19:33:14 -07:00
Nathan Sobo
4c74b07b22
Order style elements by priority
2015-01-06 19:14:54 -07:00
Nathan Sobo
c9eb84f2a4
Fix deprecation location reporting in spec runner
2015-01-06 11:50:20 -07:00
Nathan Sobo
180725799a
Unmount TextEditorComponent when TextEditorElement is detached
...
Fixes #4381
Fixes #4700
2015-01-06 11:35:26 -07:00
Nathan Sobo
e192922f0e
Don’t add __spacePenView property to jQuery objects in ViewRegistry
...
This property is added as needed in our legacy SpacePen views, and is
now used to trigger a deprecation warning. We don’t want to add it to
new SpacePen views because they shouldn’t trigger deprecation warnings.
2015-01-02 12:58:49 -07:00
Max Brunsfeld
eabb498af7
Fix LanguageMode::foldAllAtIndentLevel
2014-12-30 18:10:28 -08:00
Nathan Sobo
493035fe4e
Merge pull request #4606 from atom/ns-use-global-selector-in-config
...
Use `*` instead of `global` as the global selector in user settings
2014-12-30 16:37:09 -06:00
Nathan Sobo
b4756aa9b7
Remove unnecessary deprecation warning suppression
2014-12-30 13:55:49 -06:00
Nathan Sobo
651fa1aa42
💄 spelling
2014-12-30 13:53:46 -06:00
Nathan Sobo
db17fe2daa
💄 Move example to a better parent describe
2014-12-30 13:53:38 -06:00