Kevin Sawicki
c9f13afb72
Remove stray logging
2015-02-05 15:12:20 -08:00
Kevin Sawicki
e51c8f3407
Add specs for save/saveAs error handling
2015-02-05 15:07:42 -08:00
Kevin Sawicki
63ee46023d
Remove profiling
2015-02-05 14:57:09 -08:00
Kevin Sawicki
68e5839b14
Add missing error var
2015-02-05 14:44:16 -08:00
Kevin Sawicki
477801ba52
Remove save error reporting from Workspace
2015-02-05 14:43:50 -08:00
Kevin Sawicki
3850550345
Handle save errors in Pane
2015-02-05 14:42:21 -08:00
Kevin Sawicki
77741b6f3f
Set ATOM_HOME as early as possible in render process
...
Moves it from window-bootstrap.coffee to index.js so it runs before
the coffee cache is registered.
Refs #5412
2015-02-05 12:18:51 -08:00
Kevin Sawicki
4597dd5594
Add render process check for ATOM_HOME
...
Setting it in the browser process does not seem to make it into
the render processes on Linux.
Closes #5412
2015-02-05 12:11:13 -08:00
Kevin Sawicki
04d015a7e0
Use app.getHomeDir
2015-02-05 11:39:58 -08:00
Kevin Sawicki
83c8d904cf
🎨 Add space before arrow
2015-02-04 17:44:33 -08:00
Kevin Sawicki
fd1d872840
Prompt split editors to save on close
...
Previously an editor that was split into multiple panes would not
prompt to save correctly when the window was unloading.
This adds a new `windowCloseRequested` option passed through from the
beforeunload handler to the editor so that it can specially handle this
case.
Closes #5257
2015-02-04 17:14:46 -08:00
Kevin Sawicki
c5b6b90c88
Normalize opened paths to handle ~
...
Closes #3829
2015-02-04 16:39:25 -08:00
Kevin Sawicki
9618ec45cf
Remove unused require
2015-02-04 15:35:41 -08:00
Kevin Sawicki
6e3d41f433
Suppress deprecations in BufferedNodeProcess
...
This keeps it consistent with the render process which also suppresses
deprecations
Closes #5383
2015-02-04 15:27:17 -08:00
Nathan Sobo
d14d4aaae1
Remove subscriptions in editor view that are handled in presenter
2015-02-04 15:12:21 -07:00
Nathan Sobo
77599c799c
Rename TextEditorPresenter::height to ::explicitHeight
...
This clarifies that the height is being assigned externally rather than
derived from the content.
2015-02-04 15:10:58 -07:00
Nathan Sobo
b94576dc09
Pass view measurements to model via presenter
...
Someday, we won’t need to pass measurements to the model anymore.
2015-02-04 14:48:17 -07:00
Max Brunsfeld
495caa7316
🎨 Rename DEFAULT_SOCKET_PATH -> DefaultSocketPath
2015-02-04 13:12:41 -08:00
Max Brunsfeld
ab43b08739
Add hidden --socket-path flag
...
This will allow integration tests to control which atom application
instance they use when creating atom windows
2015-02-04 11:47:29 -08:00
Kevin Sawicki
de1c6d1a5d
Remove unused require
2015-02-04 10:54:25 -08:00
Kevin Sawicki
a985942b16
Use realpath to maintain old behavior
2015-02-04 10:52:32 -08:00
Nathan Sobo
9bdb961b3f
Update vertical scroll state when contentFrameWidth changes
...
A wider content frame can mean the horizontal scrollbar gets hidden,
which could in turn mean we need to adjust the scrollTop because the
clientHeight changed.
2015-02-04 11:51:46 -07:00
Nathan Sobo
59d96c9f1a
Measure scrollbars immediately when editor becomes visible
...
This ensures all required measurements are present so assignment of
subsequent measurements such as backgroundColor have an effect.
2015-02-04 11:48:47 -07:00
Kevin Sawicki
71333bbc93
Remove custom Windows behavior
2015-02-04 10:42:13 -08:00
Kevin Sawicki
4e10ea0b10
Remove unused Subscriber mixin
2015-02-04 10:35:57 -08:00
Kevin Sawicki
888d6dfab5
Inline compile cache path
2015-02-04 10:35:57 -08:00
Kevin Sawicki
622b396111
Guard against no LOCALAPPDATA env var
2015-02-04 10:35:57 -08:00
Kevin Sawicki
0f2943989f
📝 Fix comment typos
2015-02-04 10:35:57 -08:00
Kevin Sawicki
63e618cf74
Add missing rootAtomFolder var
2015-02-04 10:35:57 -08:00
Kevin Sawicki
76f37277d9
Use sibling .atom when non-standard installer location
2015-02-04 10:35:57 -08:00
Kevin Sawicki
745e9c8284
📝 Default -> Defaults
2015-02-04 10:35:57 -08:00
Kevin Sawicki
456e511031
📝 Doc ATOM_HOME
2015-02-04 10:35:57 -08:00
Kevin Sawicki
390be558e2
Use ATOM_HOME when setting configDirPath
2015-02-04 10:35:57 -08:00
Kevin Sawicki
a127240f4f
Use ATOM_HOME as config dir path
2015-02-04 10:35:56 -08:00
Kevin Sawicki
c0ab2c4ac8
Use ATOM_HOME when building cache path
2015-02-04 10:35:56 -08:00
Kevin Sawicki
4c534606c2
Use inherited ATOM_HOME env var
2015-02-04 10:35:56 -08:00
Kevin Sawicki
f330e207b4
Set ATOM_HOME env var at startup
2015-02-04 10:35:56 -08:00
Nathan Sobo
6196882b9d
Include scrollbar dimensions in required measurements in presenter
2015-02-04 11:35:07 -07:00
Nathan Sobo
3973939de1
Don’t constrain scrollTop/Left until required measurements are assigned
...
This commit also adds to the list of required measurements and updates
the spec with a buildPresenter helper to more easily supply default
values for required measurements in each spec when they aren’t relevant
to that spec’s content.
2015-02-04 11:13:24 -07:00
Nathan Sobo
b792190693
Constrain scrollLeft based on computed clientWith and scrollWidth
2015-02-04 10:22:29 -07:00
Nathan Sobo
5bb3095ffa
Constrain scrollTop based on clientHeight and scrollHeight
2015-02-04 09:38:00 -07:00
Nathan Sobo
3656d4cca6
Pass options in DisplayBuffer::screenRangeForBufferRange
2015-02-04 08:42:34 -07:00
Nathan Sobo
6977660699
Store ‘isOnlyWhitespace’ in line presenter state
2015-02-04 07:59:34 -07:00
Nathan Sobo
ba6d11e24e
Merge branch 'master' into ns-editor-presenters
2015-02-04 07:57:04 -07:00
Nathan Sobo
86991bbec2
Merge branch 'driskell-bugs/ident_guide_whitespace_only'
2015-02-03 21:26:25 -07:00
Nathan Sobo
a685f3dc37
Prevent updates for off-screen line decoration markers on change
...
When there were lots of off-screen markers, we were performing lots of
redundant updates when off-screen markers changed. Now we only perform
updates if they intersect the visible row range.
@maxbrunsfeld this should improve the situation for folding/unfolding
when there are lots of others folds. Let me know.
2015-02-03 21:02:33 -07:00
Nathan Sobo
20a95269c9
Preserve line number for mouseWheelScreenRow in a sane way
...
What we were doing before made no sense.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-02-03 20:41:59 -07:00
Kevin Sawicki
a4976c32ae
Remove release notes from event payload
...
The release notes are provided by Squirrel on Mac but not by Squirrel for
Windows and the release notes package pulls them down manually anyway
so this field is no longer needed.
Checking for the presence of the release notes previously was preventing the
event from firing on Windows which would cause old release notes to show in
the package.
Closes #3757
2015-02-03 14:57:33 -08:00
Nathan Sobo
78b8039384
Don’t require sync update before measuring when autoHeight changes
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-02-03 15:05:45 -07:00
Nathan Sobo
cd77870286
In presenter, handle the first line being soft-wrapped
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-02-03 15:05:44 -07:00
