7906 Commits

Author SHA1 Message Date
probablycorey
a3cb98a3d3 Shorten the spec-directory description 2014-03-13 14:38:05 -07:00
Kevin Sawicki
cb41e2c41a Remove unneeded do -> block 2014-03-13 11:00:24 -07:00
Kevin Sawicki
ebfe50aafc Keep mouse move handler from going out of control
Previously the editor could be hidden and the mouse move handler
would start logging errors since it will still trying to compute
positions based on the move events still firing on the document.

Now the display property is checked in the handler and also the selection
is finalized when a move event occurs and the button is no longer pressed.

Closes #1755
2014-03-13 10:33:18 -07:00
Kevin Sawicki
eba2abd5d9 📝 Doc save, saveAs, and getPath as public 2014-03-13 09:21:06 -07:00
Kevin Sawicki
864ab0c095 Use file path in save as dialog
Previously the dirname of the file path was used which caused the
save dialog to not be filled in with the current file name

Closes #1748
2014-03-12 18:41:50 -07:00
Kevin Sawicki
68c2c18d83 Don't allow the tab length to go below 1
Closes #1751
2014-03-12 18:00:11 -07:00
Kevin Sawicki
adb2f31e7f Kill associated processes on will-quit
Previously processes were only killed when the window was destroyed.

This affected `atom --wait` when using cmd-q to quit the app.

Closes #1679
2014-03-12 12:51:47 -07:00
Nathan Sobo
99b5675c4e Ensure position is a Point in Selection::selectToPosition
Fixes #1750
2014-03-11 20:42:42 -06:00
Kevin Sawicki
2de18d3c4d 📝 Add examples for atom.workspaceView 2014-03-11 18:23:59 -07:00
Kevin Sawicki
8cb66895f0 Check that activations events are present
Having an empty array, object, or string will now be treated
as no activation events.

This was reported as being confusing since people were just clearing
the array generated by the package generator but their packages weren't
activating.
2014-03-11 16:15:30 -07:00
Kevin Sawicki
151d22c325 Destroy items on pane:close
Previously pane:close would do nothing because of the guards in
Pane::destroy.

Also renames the menu to Close Pane to be more accurate.

Closes #1686
2014-03-11 13:22:03 -07:00
Nathan Sobo
38f25160d6 Upgrade to q@1.0.1, which doesn't need loophole to avoid CSP errors 2014-03-11 13:18:56 -06:00
probablycorey
945011f9e3 Add data to the same jquery object that is appended to the list.
Closes #1747
2014-03-11 11:20:03 -07:00
Nathan Sobo
d7c6cd68b9 Merge pull request #1741 from atom/cz-first-responder-menu
Send command to first responder when no window is focused
2014-03-11 11:10:36 -06:00
Cheng Zhao
d719ea74dd Send command to first responder when no window is focused. 2014-03-11 15:31:54 +08:00
Kevin Sawicki
86cd7f7a01 Handle non-integer indentation level values
This was already occurring when using hard tabs but soft tabs still
had issues.

Refs atom/language-c#7
2014-03-10 18:45:18 -07:00
Kevin Sawicki
86c720af81 Normalize all tabs, not just the first one
Refs atom/language-javascript#10
2014-03-10 17:57:10 -07:00
Nathan Sobo
79089ced97 💄 whitespace 2014-03-07 17:19:53 -07:00
Nathan Sobo
dd27a35039 Silence CSP warnings from q's feature detection 2014-03-07 17:01:51 -07:00
Nathan Sobo
8405041f64 Merge branch 'master' into enable-csp
Conflicts:
	package.json
2014-03-07 16:46:00 -07:00
probablycorey
a372993c44 Only listen of update events once when checking for update. 2014-03-07 15:39:44 -08:00
Nathan Sobo
5d49839236 Don't require loophole unless we need it. Won't happen in production. 2014-03-06 19:13:27 -07:00
Nathan Sobo
e6508237e7 Merge pull request #1710 from atom/ns-duplicate-multiple-lines
Handle multiple lines and multiple selections with the editor::duplicate-lines command
2014-03-07 04:01:59 +02:00
Nathan Sobo
2d4797c84e Define allowUnsafeEval in an npm module 2014-03-06 18:56:09 -07:00
Nathan Sobo
392516e60f Delegate activateNextPane correctly 2014-03-06 18:32:24 -07:00
Nathan Sobo
d09a2d0772 Merge branch 'master' into ns-duplicate-multiple-lines
Conflicts:
	package.json
2014-03-06 18:16:48 -07:00
Nathan Sobo
2bd5c10f09 Merge branch 'master' into enable-csp 2014-03-06 18:14:25 -07:00
Nathan Sobo
b9b3d021cc Add private method docs to DisplayBuffer::outermostFoldsInBufferRange 2014-03-06 15:31:14 -07:00
Nathan Sobo
6e202e18d8 💄 more comment formatting 2014-03-06 15:29:25 -07:00
Nathan Sobo
da85a07dae 💄 comment formatting 2014-03-06 15:17:34 -07:00
Nathan Sobo
85824c5df6 Handle last buffer line in Editor::duplicateLines 2014-03-06 14:48:52 -07:00
Nathan Sobo
20a0c27111 Rename duplicate-line to duplicate-lines (but retain deprecated method)
Might as well make the name accurate while it's early.
2014-03-06 14:36:25 -07:00
Nathan Sobo
76200884d5 Preserve folds when duplicating lines 2014-03-06 13:16:16 -07:00
Nathan Sobo
ce4ce55b29 Make outermostFoldsForBufferRowRange exclusive of end row 2014-03-06 12:52:27 -07:00
Nathan Sobo
66f6e38788 Fix ::translateToBufferMarkerAttributes reference 2014-03-06 12:42:16 -07:00
Nathan Sobo
d97a0a3324 Add DisplayBuffer::outermostFoldsInBufferRowRange 2014-03-06 12:36:42 -07:00
Nathan Sobo
63f5a0a324 💄 Rename attributes to params to match TextBuffer naming 2014-03-06 12:32:17 -07:00
Nathan Sobo
f0837bb98b 📝 Improve DisplayBuffer::findMarkers docs 2014-03-06 12:31:55 -07:00
Corey Johnson
1dd59204e9 Only released versions should check for updates
Fixes atom/release-notes#6
2014-03-06 10:51:47 -08:00
Corey Johnson
272dd4a076 Don't trigger window:update-available on new windows
This was causing people to see `undefined` release notes. In the 
future we can store the release notes, but since anything related to
updates and the browser process takes a lot of time to fix I'm holding
off on that improvement.
2014-03-06 10:25:12 -08:00
Corey Johnson
626ebe380e Use proper variable name 2014-03-06 10:14:02 -08:00
Nathan Sobo
a0234d0cc6 Handle empty selections on folded lines 2014-03-06 00:07:59 -07:00
Nathan Sobo
8a77acb51e Duplicate multiple selections and multiple lines; folds are broken 2014-03-05 23:29:28 -07:00
Kevin Sawicki
372ca374cc Serialize project 2014-03-05 15:06:19 -08:00
Corey Johnson
75b6e94be1 Merge pull request #1699 from atom/cj-convert-keystrokes-using-shift
Converts keystrokes with alpha chars using shift
2014-03-05 15:00:42 -08:00
Nathan Sobo
5e8213d45f Add atom.allowUnsafeEval loophole and disable unsafe-eval again
With Node.js baked in, there's no water-tight way to prevent users from
evaluating code at runtime, at least with CSP alone. This is because
node exposes a 'vm' module that allows scripts to be compiled. There's
also `module._compile`, etc.

I think a reasonable compromise is to protect users from eval'ing code
by accident. This commit adds an atom.allowUnsafeEval method which
re-enables eval in the dynamic scope of the given function.

I then use this to compile the keystroke grammar which saves us the
complexity of pre-compiling it during specs.

What do people think?
2014-03-05 09:57:08 -07:00
Nathan Sobo
bc14ad5b15 Fix broken docs links 2014-03-05 08:53:38 -07:00
Kevin Sawicki
6531128647 📝 Add missing h 2014-03-04 18:25:31 -08:00
probablycorey
f4e88bbcc0 Make sure shift is not double added 2014-03-04 18:00:00 -08:00
probablycorey
d0889cca31 Normalize keystrokes to use shift and the uppercase letter
`cmd-shift-l`, `cmd-L` and `cmd-shift-L` all normalize to `cmd-shift-L`
2014-03-04 17:42:32 -08:00