Kevin Sawicki
0adae86b4d
Don't set line height on mini editors
2014-03-25 10:55:32 -07:00
Cheng Zhao
eb1bed118f
No need to parse args before passing to nslog.
2014-03-25 15:40:43 +08:00
Justin Palmer
cf590685b9
remove lineHeight getter
...
Nothing is using it and we can add it back once the need arises.
2014-03-24 12:52:01 -07:00
Justin Palmer
a604bfcdf1
remove trailing whitespace
2014-03-24 11:42:32 -07:00
Justin Palmer
ce02dcf5a5
clarify docs around lineHeight
2014-03-24 11:37:38 -07:00
Justin Palmer
d3d38c0312
rename editorLineHeight to lineHeight
2014-03-24 11:28:15 -07:00
Justin Palmer
95d097dd7b
1.3 best represents the previous default line height
2014-03-24 10:59:19 -07:00
Justin Palmer
47f3b562b5
add getter for editorLineHeight
2014-03-24 10:58:58 -07:00
Justin Palmer
5eb12e671b
add config option for explicitly setting the editor line height
2014-03-24 10:58:26 -07:00
Nathan Sobo
424652e27c
Also ensure editor is *visible* before recalculating dimensions
2014-03-21 17:33:39 -06:00
Nathan Sobo
2daf026967
Merge pull request #1777 from atom/ns-optimize-editor-rendering
...
Remove extra reflow and options object allocation from editor view updates
2014-03-21 13:12:54 -06:00
Nathan Sobo
61e9befbe7
Favor the most recent matching binding when selecting app menu shortcuts
...
We sending every binding matching the `body` selector to the browser
process, but it only selects the first. Since we scan the bindings in
chronological order, we need to unshift bindings to the front of the
array so the most recently defined bindings are loaded first.
2014-03-21 10:42:04 -06:00
Nathan Sobo
50c25d9e44
Read scrollView width prior to touching the DOM to prevent reflow
2014-03-20 18:02:04 -06:00
Nathan Sobo
9be593d390
Eliminate options object for suppressAutoscroll
...
It's a single option used only internally. Let's not allocate an object
for it.
2014-03-20 18:02:04 -06:00
Kevin Sawicki
244fc33f49
Support submodules inside submodules from isSubmodule
2014-03-20 16:36:10 -07:00
Kevin Sawicki
f83f5263a9
💄 Reorder keys
2014-03-20 16:10:10 -07:00
Kevin Sawicki
3266dde2e3
📝 Add missing d
2014-03-20 16:10:10 -07:00
Kevin Sawicki
3428ee335a
💄
2014-03-20 16:10:10 -07:00
Kevin Sawicki
db6b4d7b81
Support submodules in more methods
2014-03-20 16:10:10 -07:00
Kevin Sawicki
1c195987c1
Load submodule statuses in handler
2014-03-20 16:10:09 -07:00
Kevin Sawicki
4913714a61
Fall back to root repo for submodule check
2014-03-20 16:10:09 -07:00
Kevin Sawicki
8e2856465c
Handle submodules in getDiffStats/isSubmodule
2014-03-20 16:10:09 -07:00
Kevin Sawicki
868c7a3908
Compute status of submodules
2014-03-20 16:10:09 -07:00
Kevin Sawicki
afaf91ebde
Add path argument to handle submodules correct
2014-03-20 16:10:09 -07:00
Kevin Sawicki
2bde128fed
Make serialization version independent of app version
...
Previously when deserializing the version of the serialized state
was compared to the app version causing the serialized state be discarded
each time Atom was updated.
Now the cached app version variable is different than the serialization
version allow them to drift accordingly without loss of serialized state.
2014-03-20 16:09:16 -07:00
Kevin Sawicki
0fdda032cc
Guard against interval firing after editor is destroyed
2014-03-20 14:41:16 -07:00
Nathan Sobo
075611eb65
Don't recalculate dimensions on stylesheet changes for detached editors
2014-03-20 12:19:34 -06:00
Nathan Sobo
f0a7663447
Recalculate line-height and char-width when stylesheets change
...
If either of these dimensions change, we request a display update for
the editor.
2014-03-19 21:37:26 -06:00
Nathan Sobo
2d26382510
Emit 'stylesheet-changed' from atom.themes
...
Whenever stylesheets are applied or removed.
2014-03-19 15:51:36 -06:00
Nathan Sobo
24943dd526
Avoid sending arguments object to child process.
...
The arguments variable is not a real array, and gets screwed up when
sending it to the child process. This updates it to send an array
instead.
Thanks to @lackac!
Refs atom/terminal#23 .
2014-03-19 15:40:35 -06:00
Kevin Sawicki
5783350484
📝 Tweak option comment
2014-03-19 10:06:10 -07:00
Kevin Sawicki
9fce23d5ac
Update option to preserveLeadingWhitespace
2014-03-19 10:05:34 -07:00
Kevin Sawicki
61f01f4713
📝 Add through
2014-03-19 10:05:34 -07:00
Kevin Sawicki
8e62d772b3
Ignore leading whitespace when auto-indenting a newline
...
Refs atom/language-less#1
2014-03-19 10:05:34 -07:00
Cheng Zhao
6838ff8ea2
Merge pull request #1762 from atom/linux-build
...
Make Atom build on Linux
2014-03-19 01:40:11 +00:00
Kevin Sawicki
8aa2c40bbf
Don't capture whitespace group in comment patterns
...
This was causing corruption when uncommenting XML since the fact that
it was being captured was throwing off the index used into the match.
Closes atom/language-xml#3
2014-03-18 18:19:59 -07:00
Cheng Zhao
0ee3421cbc
Merge branch 'master' into linux-build
2014-03-18 15:54:52 +08:00
Cheng Zhao
cc2e1eecd3
Still set NODE_PATH since tasks may need it.
2014-03-18 15:38:57 +08:00
Cheng Zhao
87b95128f9
Do not rely on NODE_PATH env.
2014-03-18 15:34:24 +08:00
Cheng Zhao
da8d055817
🐧 Quit when all windows are closed.
2014-03-18 14:09:43 +08:00
Nathan Sobo
ff23f62c3e
Move jQuery.Event::abortKeyBinding to keymap-extensions
2014-03-17 13:05:47 -06:00
Nathan Sobo
dcdc9d6b90
Construct Keymap with options object
2014-03-17 13:05:47 -06:00
Nathan Sobo
3d28f957c7
Export Keymap from keymap-extensions
2014-03-17 13:05:47 -06:00
Nathan Sobo
2eb2aa5bef
Rename season variable to CSON for consistency
2014-03-17 13:05:46 -06:00
Nathan Sobo
2dcbf7f751
Replace Keymap subclass with keymap-extensions
2014-03-17 13:05:46 -06:00
Nathan Sobo
4c0f1efec6
Set the keymap default target to atom.workspaceView's DOM element
2014-03-17 13:05:46 -06:00
Nathan Sobo
8974cb5f34
Make a quick and dirty subclass of the Keymap from the npm
2014-03-17 13:05:46 -06:00
probablycorey
a3cb98a3d3
Shorten the spec-directory description
2014-03-13 14:38:05 -07:00
Kevin Sawicki
cb41e2c41a
Remove unneeded do -> block
2014-03-13 11:00:24 -07:00
Kevin Sawicki
ebfe50aafc
Keep mouse move handler from going out of control
...
Previously the editor could be hidden and the mouse move handler
would start logging errors since it will still trying to compute
positions based on the move events still firing on the document.
Now the display property is checked in the handler and also the selection
is finalized when a move event occurs and the button is no longer pressed.
Closes #1755
2014-03-13 10:33:18 -07:00
