Corey Johnson
50e045212b
Measure the rendered char width instead of the buffer char
...
If invisibles are turned on, the buffer char and the rendered char
may differ in size. For example, if `☃` is used as the tab invisible
its width is probably larger than the width of a `\t`
Closes #1724
2014-03-26 13:57:04 -07:00
Kevin Sawicki
0adae86b4d
Don't set line height on mini editors
2014-03-25 10:55:32 -07:00
Justin Palmer
cf590685b9
remove lineHeight getter
...
Nothing is using it and we can add it back once the need arises.
2014-03-24 12:52:01 -07:00
Justin Palmer
a604bfcdf1
remove trailing whitespace
2014-03-24 11:42:32 -07:00
Justin Palmer
ce02dcf5a5
clarify docs around lineHeight
2014-03-24 11:37:38 -07:00
Justin Palmer
d3d38c0312
rename editorLineHeight to lineHeight
2014-03-24 11:28:15 -07:00
Justin Palmer
95d097dd7b
1.3 best represents the previous default line height
2014-03-24 10:59:19 -07:00
Justin Palmer
47f3b562b5
add getter for editorLineHeight
2014-03-24 10:58:58 -07:00
Justin Palmer
5eb12e671b
add config option for explicitly setting the editor line height
2014-03-24 10:58:26 -07:00
Nathan Sobo
424652e27c
Also ensure editor is *visible* before recalculating dimensions
2014-03-21 17:33:39 -06:00
Nathan Sobo
50c25d9e44
Read scrollView width prior to touching the DOM to prevent reflow
2014-03-20 18:02:04 -06:00
Nathan Sobo
9be593d390
Eliminate options object for suppressAutoscroll
...
It's a single option used only internally. Let's not allocate an object
for it.
2014-03-20 18:02:04 -06:00
Kevin Sawicki
0fdda032cc
Guard against interval firing after editor is destroyed
2014-03-20 14:41:16 -07:00
Nathan Sobo
075611eb65
Don't recalculate dimensions on stylesheet changes for detached editors
2014-03-20 12:19:34 -06:00
Nathan Sobo
f0a7663447
Recalculate line-height and char-width when stylesheets change
...
If either of these dimensions change, we request a display update for
the editor.
2014-03-19 21:37:26 -06:00
Kevin Sawicki
cb41e2c41a
Remove unneeded do -> block
2014-03-13 11:00:24 -07:00
Kevin Sawicki
ebfe50aafc
Keep mouse move handler from going out of control
...
Previously the editor could be hidden and the mouse move handler
would start logging errors since it will still trying to compute
positions based on the move events still firing on the document.
Now the display property is checked in the handler and also the selection
is finalized when a move event occurs and the button is no longer pressed.
Closes #1755
2014-03-13 10:33:18 -07:00
Kevin Sawicki
2de18d3c4d
📝 Add examples for atom.workspaceView
2014-03-11 18:23:59 -07:00
Nathan Sobo
20a0c27111
Rename duplicate-line to duplicate-lines (but retain deprecated method)
...
Might as well make the name accurate while it's early.
2014-03-06 14:36:25 -07:00
Nathan Sobo
834dd963ef
Subtract the scrollbar's width when calculating editor's width in chars
...
Fixes #1342
2014-03-04 15:46:07 -07:00
Nathan Sobo
aa04589dd2
Rename Editor::joinLine to ::joinLines
...
It acts on multiple lines, and in a quick survey of the literature I see
Sublime docs referring to it as "join lines" as well.
2014-02-27 16:16:01 -08:00
Nathan Sobo
6d246f5244
Rename Editor::foldSelection to Editor::foldSelectedLines and publicize
2014-02-27 16:16:01 -08:00
Kevin Sawicki
9ed7254277
Use 16 as font size default
2014-02-26 11:46:07 -08:00
Nathan Sobo
53fb36d0e2
Switch all documentation links to match CoffeeScript literal notation
...
Foo::bar for instance methods
Foo.bar for class methods
2014-02-19 17:23:47 -07:00
Kevin Sawicki
8900d9efdd
Require TextBuffer from text-buffer module
2014-02-19 09:19:08 -08:00
Kevin Sawicki
4e2218b005
Use @ instead of EditorView prefix
2014-02-12 08:59:06 -08:00
Kevin Sawicki
a1ce1c9ef6
📝 . instead of ,
2014-02-12 08:43:16 -08:00
Kevin Sawicki
cc890ebdc0
Add editor.fontFamily config default
...
This causes it to display in the settings view.
2014-02-11 17:00:25 -08:00
Kevin Sawicki
18348b8738
📝 doc parameters in editor-view.coffee
2014-02-06 16:35:32 -08:00
Kevin Sawicki
ec4cf8b497
Remove ConfigObserver
...
This class offers little utility now that emissary exists with beefed
up Subscriber and Emitter classes.
2014-02-06 13:07:25 -08:00
Kevin Sawicki
d5b809a194
📝 Clean up EditorView docs
...
* Remove ### Internal ### blocks
* Remove ### Public ### blocks
* Remove ### Private ### blocks
* Remove empty Private: comments
* Add explicit Public: to comments
2014-02-04 13:19:50 -08:00
Kevin Sawicki
2fb0f796c4
Capitalize Editor is method name
2014-02-04 12:46:42 -08:00
Kevin Sawicki
f473d46cf1
📝 doc EditorView::setPlaceholderText
2014-02-04 12:45:56 -08:00
Kevin Sawicki
061599554e
📝 coc EditorView::getEditor
2014-02-04 12:43:47 -08:00
Kevin Sawicki
b1e99d9927
Use atom.clipboard instead of atom.pasteboard
2014-02-03 13:10:10 -08:00
Kevin Sawicki
84c5a25ef3
📝 Shorten comment
2014-01-30 12:44:01 -08:00
Kevin Sawicki
4a54565f59
Prevent scrolling when a space is pressed in editor
...
Closes atom/settings-view#25
2014-01-30 12:44:01 -08:00
Kevin Sawicki
be0e36b663
Rename Gutter to GutterView
...
Refs #1468
2014-01-24 17:30:29 -08:00
Kevin Sawicki
ac2985af36
Call getSelectedText() on Editor
2014-01-22 15:57:15 -08:00
Kevin Sawicki
e4bcb52573
📝 Add requiring in packages example to exported classes
2014-01-21 18:43:07 -08:00
Nathan Sobo
99f025d5d6
Rename .fold-icon to .icon-right in gutter to make it multi-purpose
2014-01-17 16:59:50 -07:00
Nathan Sobo
a774c2ff08
🔫 unnecessary return statement
2014-01-17 15:46:49 -07:00
Nathan Sobo
b2dff15e51
Toggle folding upon 'mousedown' on a foldable line's fold-icon
2014-01-17 15:17:13 -07:00
probablycorey
4f82662263
Fix page up/page down keybindings
2014-01-17 08:28:45 -08:00
Kevin Sawicki
f19d2d7369
Call selectLeft on editor
2014-01-16 16:00:20 -08:00
probablycorey
7f790137ed
Fix editor method name
2014-01-16 15:55:21 -08:00
Cheng Zhao
fcffcc83f9
Merge branch 'master' into chrome31
...
Conflicts:
package.json
vendor/apm
2014-01-16 09:11:34 +08:00
probablycorey
b620be7780
Fix cut, copy and paste key bindings
...
Closes #1425
2014-01-15 16:00:09 -08:00
Kevin Sawicki
06ccb48efe
Remove trailing }
2014-01-13 15:40:33 -08:00
probablycorey
95f2d02d18
Merge branch 'master' into cj-remove-editor-view-delegate-methods
...
Conflicts:
package.json
spec/workspace-view-spec.coffee
src/editor.coffee
src/gutter.coffee
2014-01-13 15:06:18 -08:00