Nathan Sobo
34f624c895
Unsubscribe from the editor model with ::unsubscribe
2014-04-15 19:07:57 -06:00
Nathan Sobo
d554b7fd03
Remove scopes from event names in subscriptions
2014-04-15 18:50:36 -06:00
Nathan Sobo
a61dff6e21
🚱 Unsubscribe from Editor when EditorView is removed
...
This replaces calls to `@editor.on` with `@subscribe @editor`. That
causes us to correctly unsubscribe when the editor is removed, avoiding
a memory leak.
2014-04-15 18:46:20 -06:00
Corey Johnson
aed0c16acc
Remove github auth token methods
2014-04-15 16:16:01 -07:00
Corey Johnson
ecfb505144
Merge pull request #1851 from atom/cj-move-functionality-to-workspace-part-II
...
Move functionality from Project to Workspace Part II
2014-04-15 11:45:46 -07:00
Corey Johnson
54b60a5253
Don't assume atom.workspace is always defined
2014-04-14 08:49:03 -07:00
Corey Johnson
e56fa3ec4f
Use PaneContainer to keep the state of open editors
2014-04-11 11:10:00 -07:00
Corey Johnson
fe0d714710
Fix inconsistent indentation
2014-04-11 10:51:56 -07:00
Kevin Sawicki
7c1a7f52a5
📝 Use TomDoc in src/browser/ files
2014-04-11 10:50:33 -07:00
Kevin Sawicki
590c6be33d
Add back dialog require used for path prompting
...
Closes #1861
2014-04-11 10:42:49 -07:00
Kevin Sawicki
1afdd62a5d
Only alter indentation when it is too low
...
Previously insert newline above would use the current line's
indent level which could be the less than the proper level if the
newline should be further indented based on the increase indent
pattern being used.
2014-04-11 10:07:50 -07:00
Corey Johnson
3644a36d67
Clearing a selection will also finalize the selection
...
Fixes #1843
2014-04-11 09:44:57 -07:00
Cheng Zhao
f37ca3e19c
Add application:open-file and application:open-folder command.
2014-04-11 11:29:38 +08:00
Corey Johnson
613e05f4ac
Merge pull request #1855 from atom/cj-remember-last-window-dimensions
...
Remember last window dimensions
2014-04-10 16:39:01 -07:00
Corey Johnson
e1491ca154
Merge remote-tracking branch 'origin/master' into cj-remember-last-window-dimensions
2014-04-10 14:49:34 -07:00
Corey Johnson
e9a975fd92
Don't use version as a method
2014-04-10 14:42:51 -07:00
Corey Johnson
10392942d5
Merge remote-tracking branch 'origin/master' into cj-auto-update-no-breaky
2014-04-10 14:10:15 -07:00
Cheng Zhao
6017ff585f
Do not use deprecated app.exit API.
2014-04-10 17:33:26 +08:00
Kevin Sawicki
b328a69f50
Check that label exists when comparing to other items
...
Previously separators would be removed when merging menus that
contained multiple separators.
Refs atom/find-and-replace#159
2014-04-09 11:39:38 -07:00
Corey Johnson
a2f73fd6b0
Remove unneeded fat arrows
2014-04-09 10:13:09 -07:00
probablycorey
b72bb4ab65
Fix default size bug
2014-04-08 17:27:52 -07:00
probablycorey
d72e3d9c81
Add AtomWindow::getWindowDimensions
2014-04-08 17:11:20 -07:00
probablycorey
3393583b72
Use windowDimensions from load settings if they exist
2014-04-08 16:57:52 -07:00
probablycorey
6fcd905d4f
Use windowDimensions instead of initialSize
2014-04-08 16:57:18 -07:00
probablycorey
993534337c
Update restoreWindowDimensions
2014-04-08 15:26:08 -07:00
probablycorey
03814246ef
Rename to storeDefaultWindowDimensions
2014-04-08 15:25:49 -07:00
probablycorey
053965602c
Apply default dimensions
2014-04-08 14:19:03 -07:00
probablycorey
b45c1c7548
Store the default windows position.
...
Based on the last closed window or the last focused window
2014-04-08 12:35:36 -07:00
probablycorey
63a80a4d4d
Revert "Revert "Merge pull request #1844 from atom/cj-move-functionality-to-workspace""
...
This reverts commit 87d008c337
2014-04-08 10:52:19 -07:00
probablycorey
87d008c337
Revert "Merge pull request #1844 from atom/cj-move-functionality-to-workspace"
...
This reverts commit 2d7dda066c96e3c63291
2014-04-08 10:44:08 -07:00
Corey Johnson
2d7dda066c
Merge pull request #1844 from atom/cj-move-functionality-to-workspace
...
Move functionality from Project to Workspace
2014-04-08 09:52:29 -07:00
probablycorey
837f3c553f
Don't explode the array
2014-04-08 09:07:55 -07:00
Cheng Zhao
96e3c63291
Show console when window error happened, fixes #1805 .
2014-04-08 15:27:41 +08:00
probablycorey
4b089b62a6
Destructure item instead of calling it i
2014-04-07 17:01:11 -07:00
probablycorey
be8514b864
Use _.clone instead of new Array
2014-04-07 16:56:35 -07:00
probablycorey
e826b66dd2
Don't destructure underscore
2014-04-07 16:56:17 -07:00
probablycorey
a3c9a65838
Remove redundant non-public documentation
2014-04-07 15:35:25 -07:00
probablycorey
8ca5d6db35
Remove trailing whitespace
2014-04-07 15:29:15 -07:00
probablycorey
980c17e50c
Pass current version to AutoUpdateManager
2014-04-07 15:28:42 -07:00
probablycorey
6613b9fd4d
Don't send autoUpdateManager to ApplicationMenu
2014-04-07 15:19:48 -07:00
probablycorey
6bc471cef1
Only emit window:update-available event after window is loaded
2014-04-07 14:55:50 -07:00
probablycorey
4b3240eeee
Use EventEmitter instead of emissary
...
To be consistent with other browser process classes
2014-04-07 14:55:12 -07:00
probablycorey
1f9de98eb2
Make AtomWindow emit window:loaded
2014-04-07 14:54:27 -07:00
probablycorey
7eea30fa7f
Make new windows receive previously triggered update-available events
2014-04-07 14:26:07 -07:00
probablycorey
63e51af87d
Move window_udpate-evailable emitter to method
2014-04-07 14:25:35 -07:00
probablycorey
bbc6433a75
Update comment
2014-04-07 14:18:16 -07:00
probablycorey
d4ae836225
Use hidden menu items for update processes
2014-04-07 14:17:44 -07:00
probablycorey
789f29e0b5
AutoUpdateManager barely works
2014-04-07 12:25:55 -07:00
probablycorey
f5ea098417
Don't overwrite menu item's metadata field
2014-04-07 11:04:55 -07:00
probablycorey
82081aa5e9
Rename methods
2014-04-07 10:21:37 -07:00
