Kevin Sawicki & Nathan Sobo
9e3ce09658
Rename lineHeight to lineHeightInPixels to distinguish from CSS value
...
CSS has a line-height property with values like '1.3', but we also have
a measured pixel value for line height. It's important to keep these
separate conceptually.
2014-05-22 10:17:12 -06:00
Nathan Sobo
7b4bc16531
Fix specs that broke when accounting for horizontal scrollbar height
2014-05-09 11:33:03 -06:00
Corey Johnson
c03dec2783
Merge remote-tracking branch 'origin/master' into cj-add-deprecation-warning-to-specs
2014-04-23 16:51:14 -07:00
Corey Johnson
c1907054b7
Remove deprecated methods from display buffer spec
2014-04-23 16:24:10 -07:00
Nathan Sobo
f53d489abb
Add DisplayBuffer::scrollToScreen/BufferPosition
...
Also add delegators in Editor and ReactEditorView
2014-04-22 17:10:23 -06:00
Nathan Sobo
4b9871fa13
Enable advanced scroll management only when editor is used by react view
...
This preserves the original behavior of the editor model with respect
to scroll position and autoscroll unless it's being used by the react
component, which flips the ::manageScrollPosition flag to true.
2014-04-22 17:09:41 -06:00
Nathan Sobo
7a4dc0b9a4
Eliminate duplicate key to pass coffeelint
2014-04-22 17:09:40 -06:00
David Graham & Nathan Sobo
d0a917ed14
Prevent scrollLeft/scrollTop from going out of bounds
2014-04-22 17:09:39 -06:00
Nathan Sobo
148a9f0248
Add DisplayBuffer::pixelPositionForScreenPosition
...
This bakes character width tracking into display buffer directly, which
moves us toward a world where all rendering decisions can be made in the
model to strictly control DOM reads.
2014-04-22 17:09:03 -06:00
Corey Johnson
1583271e2f
Use setTextInRange instead of change
2014-04-18 15:50:30 -07:00
Nathan Sobo
70cd6a6bc3
💄 Use CoffeeScript :: notation in specs
...
Going to add another spec on a branch and prefer to stick with our new
convention.
2014-04-02 07:58:48 -06:00
Nathan Sobo
6e9217be5f
Reenable disable display-buffer-marker specs
2014-04-02 07:50:24 -06:00
Nathan Sobo
ce4ce55b29
Make outermostFoldsForBufferRowRange exclusive of end row
2014-03-06 12:52:27 -07:00
Nathan Sobo
d97a0a3324
Add DisplayBuffer::outermostFoldsInBufferRowRange
2014-03-06 12:36:42 -07:00
Nathan Sobo
06bc09951d
Fix position translation bug for wrapped lines with hard tabs
...
Fixes #1681
2014-03-04 17:55:53 -07:00
Nathan Sobo
40a8522460
Merge pull request #1623 from atom/ns-fix-editor-width-related-freezes
...
Fix freezes related to the editor's width in characters being assigned to non-positive integers
2014-02-28 20:38:07 +02:00
Nathan Sobo
4681098e8c
Only allow positive widths in characters to be assigned
...
Fixes #1574
2014-02-28 10:31:02 -08:00
Nathan Sobo
83dc1c76ef
Add a spec that corrupts the row map by partially editing a fold
2014-02-28 10:11:57 -08:00
Nathan Sobo
f17c490768
Make Editor::unfoldBufferRow destroy all folds containing the buffer row
...
Also, remove ::destroyAllFoldsContainingBufferRow as it is now redundant
2014-02-27 16:16:01 -08:00
Kevin Sawicki
189ebc4476
Remove _/fs from modules directly
2014-02-23 17:09:05 -08:00
probablycorey
e01be5d41a
Update display buffer spec
2014-02-10 15:52:33 -08:00
Nathan Sobo
e26d97d5ac
Remove telepath as a core dependency
2014-01-03 17:42:11 -07:00
Ben Ogle
75153388cc
Use tab char
2013-12-16 15:50:26 -08:00
Ben Ogle
77b5fd47ca
Dont re-atomicize atomic tokens.
...
Fixes #1318
2013-12-16 15:34:27 -08:00
Nathan Sobo
1ccc93c50b
Make DisplayBuffer a telepath model subclass
2013-12-07 03:07:15 -08:00
Kevin Sawicki
d0b380e535
Add atom prefix to rootView and project references
2013-11-20 17:23:47 -08:00
Kevin Sawicki
2eeb399cf1
Remove deserializer shims on window
2013-11-20 13:51:12 -08:00
Kevin Sawicki
ce3ec75c55
Remove remaining package manager shims
2013-11-20 12:49:15 -08:00
Kevin Sawicki
13186fcf7a
Remove Emitter::subscriptionCount shim
2013-11-19 12:55:18 -08:00
Kevin Sawicki
a377a49004
Use atom.config instead of window.config
2013-11-11 09:16:44 -08:00
Kevin Sawicki
3b05b40d66
Update package names for new language- prefix
2013-10-22 09:01:30 -07:00
probablycorey
af8ecef30d
Add 'Sync' to end of Project's synchronous open methods
...
Remove 'Async' from Project's asynchronous open methods
2013-10-15 09:45:43 -07:00
Kevin Sawicki
d46891caf0
Rename atom-api require to atom
2013-09-20 10:03:02 -07:00
Kevin Sawicki
3c94ca4b9e
Use relative paths in spec requires
2013-09-20 10:02:20 -07:00
Kevin Sawicki
fd85acd3eb
Remove unused require
2013-09-20 10:02:20 -07:00
Kevin Sawicki
eaf80a0194
Rename softWrapColumn to editorWidthInChars
2013-08-23 18:09:17 -07:00
Kevin Sawicki
32396a2a8b
Update soft wrapped lines when config changes
...
DisplayBuffer now observes for config changes to the preferred line length
and the preference to soft wrap at the preferred line length to update
any wrapped screen lines.
2013-08-23 18:09:16 -07:00
Kevin Sawicki
a45b93614e
Add editor.softWrapAtPreferredLineLength config setting
...
This is used by the DisplayBuffer to use `editor.preferredLineLength`
as the soft wrap column instead of the editor size.
2013-08-23 18:09:16 -07:00
Kevin Sawicki
e675fe73c8
Set soft wrap explicitly on the display buffer
...
This is required now that soft wrap column only takes affect
when soft wrap is enabled.
2013-08-23 18:09:16 -07:00
Nathan Sobo
0192c57f46
Fix corner case in RowMap::mapBufferRowRange w/ 0-buffer-row regions
...
Fixes #688
The DisplayBuffer applies buffer and screen deltas to the row map as
rows are inserted/removed from the buffer/screen. This can leave some
of the regions in a weird state, such as mapping multiple screen rows
to zero buffer rows. But next the DisplayBuffer applies any new mappings
based on the replaced lines over the top of existing regions. These
weirdly shaped regions should be overwritten by newly inserted regions,
so at the end of the operation the row map makes sense again.
This fixes a corner case where regions spanning 0 buffer rows at the
very beginning of the row range were not being included in the set of
regions to replace. This was in turn causing the RowMap to get into a
bad state in certain situations involving soft-wrapped lines.
2013-08-20 19:30:29 -06:00
Kevin Sawicki
a7a1244599
Flatten spec directory
2013-08-19 20:13:58 -07:00
