github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 22:08:08 -05:00
Code Issues Packages Projects Releases Wiki Activity
24,605 Commits 140 Branches 571 Tags
v1.0.6
Commit Graph

51 Commits

Author SHA1 Message Date
Kevin Sawicki
c95d6b2c60 Catch wmic spawn errors 2015-04-29 09:20:22 -07:00
Kevin Sawicki
63bfee1096 Use the command ivar 2015-04-29 09:20:21 -07:00
Kevin Sawicki
a9806d63eb Check for process from within handleEvents 2015-04-29 09:20:21 -07:00
Kevin Sawicki
78d2c868f7 Assign process ivar from within spawn 2015-04-29 09:20:21 -07:00
Kevin Sawicki
96f0916ddd Add missing l 2015-04-29 09:20:21 -07:00
Kevin Sawicki
920def7eb0 Add spec for thrown spawn error 2015-04-29 09:20:21 -07:00
Kevin Sawicki
fd84c5ff04 Extract handle events helper 2015-04-29 09:20:21 -07:00
Kevin Sawicki
99e40a788b Handle errors thrown by child_process.spawn 2015-04-29 09:20:21 -07:00
Kevin Sawicki
a67d9615a8 Extract error handling helper 2015-04-29 09:20:21 -07:00
Kevin Sawicki
213e6fd611 Check process before killing 2015-04-29 09:20:21 -07:00
Ben Ogle
0b0cbe11dc 📝 Fix BufferedProcess docs 2015-01-22 17:24:56 -08:00
Kevin Sawicki
85456ad920 Add missing s in comspec 2014-12-19 18:59:46 -08:00
Kevin Sawicki
aabf4dfbab Add missing path require 
Closes atom/settings-view#288
 2014-12-19 18:37:05 -08:00
Kevin Sawicki
12d4fae91c Fall back to system root for cmd.exe path 2014-12-18 17:58:18 -08:00
Kevin Sawicki
2f334979d5 Add explorer check using SystemRoot path 
Closes #4551
 2014-12-18 17:20:40 -08:00
Ben Ogle
f2ab14656b BufferedProcess::onDidThrowError -> ::onDidThrowError 2014-12-10 18:08:43 -08:00
Ben Ogle
ad73902382 📝 Add docs 2014-12-10 16:27:05 -08:00
Ben Ogle
bf63a9715c Add BufferedProcess::onDidThrowError() 2014-12-10 16:26:57 -08:00
Kevin Sawicki
31dd9bed6a Map over cmdArgs when quoting 2014-09-18 11:37:37 -07:00
Kevin Sawicki
44860ba572 Filter null/undefined arguments on Windows 
These won't be able to be properly quoted
 2014-09-18 11:36:41 -07:00
Kevin Sawicki
c37e4649b5 Only call replace on string arguments 
Prevents errors being thrown when trying to call replace on non-string
arguments.
 2014-09-18 11:31:29 -07:00
Ben Ogle
1933488914 Buffered process classes are extended 2014-09-16 13:35:19 -07:00
Kevin Sawicki
aa5870570f 📝 Convert BufferedProcess docs 2014-08-25 15:08:45 -07:00
Kevin Sawicki
b572594f92 Ignore errors from process object 2014-08-12 16:15:42 -07:00
Kevin Sawicki
fbde059748 Ignore errors killing child processes 2014-08-12 16:15:42 -07:00
Kevin Sawicki
6084ef52e7 Ensure pid is positive 2014-08-12 16:15:42 -07:00
Kevin Sawicki
a9f4dfc6b7 Split on whitespace when parsing pids 2014-08-12 16:15:42 -07:00
Kevin Sawicki
8032d6dab2 Return undefined from BufferedProcess::kill 2014-08-12 16:15:42 -07:00
Kevin Sawicki
01ec449fce Kill parent process after children on Windows 2014-08-12 16:15:42 -07:00
Kevin Sawicki
e79d66497c Remove comment about killing process 2014-08-12 16:15:41 -07:00
Kevin Sawicki
a205c6d190 Use wmic to kill child processes 2014-08-12 16:15:41 -07:00
Luca Moser
28a0e94bb9 Fixes unexecutable commands on win32 in BP 
Signed-off-by: Luca Moser <moser.luca@gmail.com>
 2014-08-11 20:24:57 +02:00
Kevin Sawicki
0faff626d1 Remove stray # 2014-07-14 07:55:28 -07:00
Kevin Sawicki
18818c9ba5 Special case quoting of certain explorer args 
This is required for things like:

`explorer.exe /root,C:\a\folder` to spawn correctly.

Refs atom/tree-view#180
 2014-07-14 07:55:28 -07:00
Kevin Sawicki
6d2b70b3d9 Check that args are present before mapping over 
Closes #2925
 2014-07-11 08:40:53 -07:00
Kevin Sawicki
31b3d8f967 Add missing require 2014-06-03 11:06:02 -07:00
Kevin Sawicki
a7a9301f25 Quote all arguments to cmd.exe 
This is required since the command or arguments may have spaces that will
be interpreted as separate arguments unless quotes surround it.

Closes #2231
Closes atom/symbols-view#37
 2014-06-03 10:50:00 -07:00
Kyle Filz
f9fe5efbb0 Fix running .cmd stubs through BufferedProcess 
ChildProcess.spawn only will run .exe files on Windows, not .cmd, .bat,
.anythingElse.

See joyent/node#2318 for more information.
 2014-05-09 09:04:36 -05:00
Pascal Borreli
7070ed8ae4 Fixed typos 2014-05-07 08:52:58 +01:00
Kevin Sawicki
be5342fb51 Assign all ivars in constructor 2014-02-24 16:59:58 -08:00
Kevin Sawicki
50dc82d074 Add example to overview 2014-02-24 16:59:15 -08:00
Kevin Sawicki
83cc6a76de 📝 doc parameters in buffered-process.coffee 2014-02-06 15:38:59 -08:00
Kevin Sawicki
932a792289 Remove Private: prefix 2014-02-06 10:02:53 -08:00
Kevin Sawicki
e4bcb52573 📝 Add requiring in packages example to exported classes 2014-01-21 18:43:07 -08:00
Matt Colyer
814ab4e980 📝 Throughly document BufferedProcess. 2013-10-21 16:32:10 -07:00
Kevin Sawicki
216a5e61fd Update underscore-extensions requires 2013-10-15 13:50:16 -07:00
Kevin Sawicki
ed1dcceb31 Add Public keyword to all exported classes 2013-09-20 10:03:02 -07:00
Kevin Sawicki
41fc4f7fe6 Use relative require paths in src/ files 2013-09-20 10:02:20 -07:00
Matt Colyer
ad69522bd1 Update buffered-process's documentation 2013-08-27 10:16:59 -07:00
Matt Colyer
d5c2878d53 Document BufferedProcess and BufferedNodeProcess 2013-08-27 10:16:59 -07:00