Nathan Sobo
d2fdc414e7
Merge pull request #8919 from bencolon/workspace_vertical_splits
...
Add top/bottom split options when opening uri in a workspace
2015-10-22 14:13:42 -06:00
Ben Colon
1b0d72b232
Add up/down split options when opening uri in a workspace
2015-10-22 17:03:10 +02:00
Nathan Sobo
84aa8471b4
Pass AppDelegate to Workspace, Pane instead of bound functions
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-13 18:54:48 -06:00
Antonio Scandurra
56e13bba69
Reset Workspace in AtomEnvironment
2015-10-12 15:01:00 +02:00
Max Brunsfeld
369f3d2648
Don't use atom.{notifications,config,deserializers,confirm} in Pane
...
Still need to get rid of one use of showSaveDialogSync
2015-10-09 17:18:26 -07:00
Thomas Johansen
669eff5d20
🔥 Remove duplicate keys
2015-10-07 15:25:06 -05:00
Antonio Scandurra
464cfd4474
Don't use atom.confirm in Workspace
2015-10-07 15:25:02 -05:00
Nathan Sobo
b2359f44a6
Don’t use atom.grammars global in TokenizedBuffer
2015-10-07 15:25:00 -05:00
Nathan Sobo
dc0709ef9e
Don’t use atom.assert global in DisplayBuffer
2015-10-07 15:24:59 -05:00
Nathan Sobo
d15d9be9eb
Construct Workspace with all dependencies in specs
2015-10-07 15:24:59 -05:00
Nathan Sobo
eb2ace37b4
Move TextEditor construction to Workspace
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-07 15:24:56 -05:00
Max Brunsfeld
77825e9d41
Wait for async service consumption in workspace spec
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-10-07 15:24:56 -05:00
Nathan Sobo
156cdfaf31
Move Workspace.deserialize to an instance method
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-07 15:24:55 -05:00
Nathan Sobo
3491fa3650
Construct Project during Atom environment construction
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-07 15:24:55 -05:00
Nathan Sobo
26f0ef5424
Move Project.deserialize to instance method
...
So we can instantiate atom.project during Atom environment construction.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-07 15:24:55 -05:00
Nathan Sobo
3d4ed37f81
Don’t use Serializable mixin in Workspace
2015-09-22 10:55:52 -06:00
Thomas Johansen
e0ff96127a
🔥 Remove deprecations from Workspace
2015-09-22 10:37:06 -06:00
Nathan Sobo
035429b7bc
Wait for fakeSearch to be defined in spec
2015-09-18 20:48:49 -06:00
Nathan Sobo
4ac43cf994
Drop space-pen-extensions from WorkspaceSpec
2015-09-18 20:48:48 -06:00
Nathan Sobo
f77cb3786c
Terminate all directory searches if any fail
...
@bolinfest: I was seeing exceptions after the test terminated due to
one of the searches still running. I think since the promise rejects
with “all” semantics that we should cancel any other searches when one
fails. I wouldn’t expect them to continue if the promise is no longer
unresolved.
2015-09-18 20:48:46 -06:00
Nathan Sobo
117d1507ab
Move ‘core:close’ specs in workspace-view-spec to workspace-spec
2015-09-18 20:48:42 -06:00
Nathan Sobo
f5c7061257
Move workspace serialization specs to workspace-spec
2015-09-18 20:48:39 -06:00
Nathan Sobo
f9a576b0ce
Allow Infinity for initialLine/Column; move specs to workspace
...
The initialLine and initialColumn behavior belongs on workspace.
2015-08-10 11:32:38 -06:00
Nathan Sobo
69da157ecb
Add specs for initialLine and initialColumn, simplify implementation
2015-08-10 11:27:15 -06:00
Max Brunsfeld
d9aa95fb11
Fix specs to deal w/ async ServiceHub::consume
2015-07-23 11:31:09 -07:00
Ivan Žužak
852456fafe
Merge pull request #7173 from atom/ns-prompt-on-large-files
...
Show a warning prompt when opening files over 20MB
2015-06-21 18:17:59 +02:00
Michael Bolin
ad46b37cfe
In workspace-spec.coffee, updated FakeSearch to match the spec, which
...
helped uncover a bug.
2015-06-10 23:30:42 +01:00
Michael Bolin
3c44bc06f4
Revert "Revert "Introduce atom.directory-searcher service v0.1.0.""
...
This reverts commit 262d41c306 .
2015-06-10 23:30:25 +01:00
Max Brunsfeld
262d41c306
Revert "Introduce atom.directory-searcher service v0.1.0."
2015-06-09 11:51:30 -07:00
Michael Bolin
0630bce95c
Two things:
...
* Removed the `Directory` argument to `didSearchPaths`.
Now each searcher gets its own instance of `didSearchPaths` that is parameterized by provider.
* Simplified `DefaultDirectorySearcher.search()` so it creates one `DirectorySearch`
rather than one per `Directory` passed to `search()`.
2015-06-09 15:34:10 +01:00
Michael Bolin
028ac79836
Changed the behavior so that if a searcher rejects,
...
then the thenable returned by `atom.workspace.scan()` rejects.
2015-06-09 15:34:09 +01:00
Michael Bolin
7dc3d07f8a
Changed the contract of DefaultDirectorySearcher in two significant ways:
...
* `search()` takes an array of `Directory` objects rather than an individual object.
* `options.didSearchPaths` now takes the `Directory` in addition to the `count` as an argument.
2015-06-09 15:34:09 +01:00
Michael Bolin
318498464a
Responded to all of @maxbrunsfeld's comments except for:
...
* The effect of a failed search.
* Letting `DirectorySearcher::search` take multiple directories.
I'm working on those now.
2015-06-09 15:34:09 +01:00
Michael Bolin
5fc9d9e01a
Document and test the cancel() method on the object returned by atom.workspace.scan().
2015-06-09 15:34:09 +01:00
Michael Bolin
10d9111f68
Clean up test to verify that an individual failed search fails the overall search.
2015-06-09 15:34:09 +01:00
Michael Bolin
898f7b87e8
remove require for Disposable that is no longer needed
2015-06-09 15:34:09 +01:00
Michael Bolin
f7e822d41f
Make delegate method names more delegate-like.
2015-06-09 15:34:09 +01:00
Michael Bolin
4eb30f3925
Switch to the delegate pattern,
...
eliminating a nasty race condition and deleting a lot of code.
2015-06-09 15:34:09 +01:00
Michael Bolin
4330c3a181
Fix some nits I found during my self-review.
2015-06-09 15:34:08 +01:00
Michael Bolin
7294e0cda4
Change DirectorySearcher to return a DirectorySearch.
2015-06-09 15:34:08 +01:00
Michael Bolin
7781e34ba2
Introduce atom.directory-searcher service v0.1.0.
...
The contract for a provider for the `atom.directory-searcher` service
is defined by the spec of the `DefaultDirectorySearcher`.
This modifies `Workspace::scan()` to use the appropriate `DirectorySearcher`
for each member of `atom.project.getDirectories()` when scanning the workspace
for files that match the specified regex.
2015-06-09 15:34:08 +01:00
Nathan Sobo
5c57cb0cfe
Show a warning prompt when opening files over 20MB
...
We still have some trouble on files this large. I want to show a
progress bar, but for now this is better than freezing without any
warning at all.
2015-06-09 00:02:36 +02:00
Nathan Sobo
df733aa3de
Add a basic test for opening an editor in largeFileMode if >= 2MB
2015-06-05 23:25:48 +02:00
Nathan Sobo
ffcebdad33
Remove outdated test
2015-06-05 23:14:11 +02:00
Machiste Quintana
d5bcc0433d
WIP: 👕 Fix linter errors
2015-05-22 16:29:12 -04:00
Machiste Quintana
4fb58317ec
🔥 Redundant lines
2015-04-30 13:41:47 -04:00
Machiste Quintana
2bd7cc9a99
Reset font size if editor.fontSize is changed from anywhere
2015-04-28 22:58:35 -04:00
Machiste Quintana
12b59cf610
Only reset font size if font size has been changed
2015-04-28 06:27:03 -04:00
Machiste Quintana
f4b228c908
Reset font size to window's starting font size
2015-04-28 06:27:03 -04:00
Machiste Quintana
5d2392ea67
👕 Fix new coffeelint errors
2015-04-06 23:59:54 -04:00