Nathan Sobo
d0cb8e2c55
Store project directory paths as state on AtomWindow in browser process
...
Fixes #9574
Previously, we were storing the project directory paths as the
`initialPaths` key in load settings, which were accessed in the browser
process by reading the URL hash. However, this URL hash was not always
available, subjecting us to timing issues when opening multiple files
in the same folder in rapid succession.
We now store the project directory paths directly on AtomWindow
instances on creation, then RPC changes from the render process to the
browser process with a custom code path.
Shout out to :airplane::finnadie:’d @as-cii on this for pairing with me.
2015-11-17 21:00:13 -08:00
Nathan Sobo
e475065b45
Merge branch 'stable' into beta
2015-11-17 16:57:19 -08:00
Nathan Sobo
3b2c6afdaf
Fix removeListener calls
2015-11-17 16:23:38 -08:00
Nathan Sobo
8da44c4dfc
Discard highlights that end above the visible row range
...
Fixes #9628
2015-11-17 11:45:51 -08:00
Nathan Sobo
192e804c8f
Fix specs. Duh.
2015-11-17 08:53:13 -08:00
Nathan Sobo
fa66048d71
Guard against focusing a destroyed pane
2015-11-12 17:34:48 -07:00
Antonio Scandurra
05550699bd
Merge pull request #9524 from atom/as-transact-async
...
Introduce Config::transactAsync
2015-11-12 09:26:26 +01:00
Max Brunsfeld
62f4f32d23
Merge pull request #9528 from efatsi/master
...
Remap pane:show-item-9 to activate last pane item
2015-11-11 15:14:08 -08:00
Antonio Scandurra
c6cb37ac88
🎨
2015-11-11 20:26:23 +01:00
Antonio Scandurra
cc30daa617
Make sure showing success dialogs works correctly
2015-11-11 12:05:11 -07:00
Antonio Scandurra
780979e122
Make sure showing errors works correctly
2015-11-11 12:05:03 -07:00
Nathan Sobo
db0149ca65
Merge pull request #9529 from atom/as-fix-bad-fat-arrow
...
Use fat arrow when showing errors in CommandInstaller
2015-11-11 12:02:36 -07:00
Max Brunsfeld
eafffd9733
Merge pull request #9444 from atom/mb-synchronous-scroll-position
...
Allow synchronous control of scroll position through TextEditor model
2015-11-11 09:58:05 -08:00
Nathan Sobo
ec4c5ddb68
Merge pull request #9477 from atom/jf-add-appveyor-build
...
Add Windows CI
2015-11-11 10:35:28 -07:00
Antonio Scandurra
0490b1482f
Make sure showing success dialogs works correctly
2015-11-11 18:19:32 +01:00
Antonio Scandurra
60841e574a
Make sure showing errors works correctly
2015-11-11 18:18:55 +01:00
Eli Fatsi
84a6f0cb75
Remap pane:show-item-9 to activate last pane item
2015-11-11 10:09:09 -07:00
Antonio Scandurra
38d713379f
🎨 Introduce Config::transactAsync
2015-11-11 09:55:20 +01:00
Max Brunsfeld
fefb387d3c
Merge branch 'master' into mb-synchronous-scroll-position
...
Conflicts:
src/text-editor-presenter.coffee
src/text-editor.coffee
2015-11-10 16:23:39 -08:00
Joe Fitzgerald
19334be188
Add Appveyor CI
...
- Add Appveyor badge
- Add Appveyor.yml definition, with encrypted ATOM_ACCESS_TOKEN
- Add cibuild.cmd script to launch cibuild on Windows
- Prepare to release Atom on Windows from Appveyor (but don't do it yet)
- Reduce dependence on JANKY in ci scripts + tasks
- Suppress release activities on PRs for Travis and Appveyor
- Cache ~/.atom/.apm, ~/.atom/.node-gyp/.atom, and ~/.atom/.npm on Appveyor
2015-11-10 15:37:01 -07:00
Kevin Sawicki
a0c208974b
Add failing spec
2015-11-10 13:54:42 -08:00
Max Brunsfeld
1304648361
Make getLastVisibleScreenRow a model API again
2015-11-09 11:00:38 -08:00
Max Brunsfeld
48cc5e713e
Make presenter respond to external changes to model's first visible screen row
2015-11-09 10:13:09 -08:00
Nathan Sobo
5587bad758
Add description to waitsFor
2015-11-09 00:35:34 -07:00
Nathan Sobo
a35e24658d
Increase timeouts
2015-11-09 00:35:34 -07:00
Nathan Sobo
6dd18b348b
Include more debug info when nextViewUpdatePromise times out
2015-11-09 00:35:34 -07:00
Nathan Sobo
98c420a408
Wait for nextTick after presenter updates
...
This gives any nextTick callbacks in the model a chance to complete
before proceeding with tests.
2015-11-09 00:35:34 -07:00
Nathan Sobo
21f8ad6958
Bump timeouts
2015-11-09 00:35:34 -07:00
Nathan Sobo
1a8adbb4e1
🎨
2015-11-09 00:35:33 -07:00
Nathan Sobo
ff681752f7
Add a nextViewUpdatePromise helper so we get stack traces from timeouts
2015-11-09 00:35:33 -07:00
Nathan Sobo
e9dfc080a3
Convert text-editor-component-spec to Babel for async/await
...
It's much easier to reason about async/await than Jasmine's
built-in queuing system, and using them made it easier to
debug flaky async tests.
2015-11-09 00:35:32 -07:00
Nathan Sobo
9ee3d53975
Destroy the selections marker layer when editors are destroyed
2015-11-09 00:35:31 -07:00
Nathan Sobo
2f81e5faac
Store folds in their own marker layer
2015-11-09 00:35:31 -07:00
Nathan Sobo
29bb1bb31b
Add TextEditor-level marker layers and use them for selections
2015-11-09 00:35:31 -07:00
Nathan Sobo
b508cc6d9f
Fix linter error
2015-11-09 00:35:30 -07:00
Nathan Sobo
a3ff0ad75a
🎨 Rename method
2015-11-09 00:35:28 -07:00
Nathan Sobo
75d0a0820c
Allow properties to be overridden for a single marker in LayerDecoration
2015-11-09 00:35:28 -07:00
Nathan Sobo
acf142863c
Add TextEditor::decorateMarkerLayer
2015-11-09 00:35:27 -07:00
Nathan Sobo
20f4c61325
Drop stray sample.js file
2015-11-09 00:35:27 -07:00
Nathan Sobo
3a25fe4975
Remove id from decoration properties
...
It doesn’t make sense to include this when we’ll reuse the same
properties for multiple decoration instances when decorating marker
layers.
2015-11-09 00:35:27 -07:00
Nathan Sobo
7d22ed788c
Test decorateMarker + decorationStateForScreenRowRange
2015-11-09 00:35:27 -07:00
Nathan Sobo
9d6168aac8
Fix gutter spec indentation
2015-11-09 00:35:27 -07:00
Nathan Sobo
3c98c30b43
Wait for animation frames synchronously after actions
...
This avoids test flakiness, presumably due to an animation frame firing
before we have a chance to wait due to jasmine’s queueing.
2015-11-09 00:35:26 -07:00
Nathan Sobo
2af010e729
Remove dead test
...
It tests functionality that no longer matters since we don’t subscribe
to decorations being destroyed in DisplayBuffer
2015-11-09 00:35:26 -07:00
Nathan Sobo
0169c1160e
Wait for next DOM update synchronously after change to avoid flakiness
2015-11-09 00:35:26 -07:00
Nathan Sobo
0ac42a12f3
Add waitsForNextDOMUpdate helper function
2015-11-09 00:35:18 -07:00
Nathan Sobo
4b5e4d02eb
Use real clock in text-editor-component-spec
...
This will make it much easier to test asynchronous update logic.
2015-11-09 00:35:18 -07:00
Nathan Sobo
1aefb22789
Add ViewRegistry.prototype.getNextUpdatePromise
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-11-09 00:35:18 -07:00
Max Brunsfeld
cdaac9dfcc
wip
2015-11-09 00:35:18 -07:00
Nathan Sobo
1fd2ba084c
Merge pull request #8232 from lpommers/move-lines-up-and-down-with-multiple-selections
...
Move lines up and down with multiple selections
2015-11-07 14:40:58 -07:00
