From 7de4eb347d2fb7d69117aae4bb921fa620fdf234 Mon Sep 17 00:00:00 2001 From: Li Jiang Date: Sat, 20 May 2023 04:05:14 +0800 Subject: [PATCH] Fix PULL_REQUEST_TEMPLATE and improve test by removing unnecessary environment variable (#1043) * Improve test by removing unnecessary environment variable * Fix PULL_REQUEST_TEMPLATE * Hide pre-commit check * remove the checkbox for pre-commit Co-authored-by: Chi Wang --------- Co-authored-by: Chi Wang --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- test/spark/test_utils.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f0991bd04..fbd50f39c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -12,7 +12,7 @@ ## Checks -- I've used [pre-commit](https://microsoft.github.io/FLAML/docs/Contribute#pre-commit) to lint the changes in this PR (note the same in integrated in our CI checks). + - [ ] I've included any doc changes needed for https://microsoft.github.io/FLAML/. See https://microsoft.github.io/FLAML/docs/Contribute#documentation to build and test documentation locally. - [ ] I've added tests (if relevant) corresponding to the changes introduced in this PR. - [ ] I've made sure all auto checks have passed. diff --git a/test/spark/test_utils.py b/test/spark/test_utils.py index 967b490fb..759c01dae 100644 --- a/test/spark/test_utils.py +++ b/test/spark/test_utils.py @@ -219,6 +219,7 @@ def test_n_current_trials(): assert get_n_current_trials(2) == min(2, tmp_max) assert get_n_current_trials(50) == min(50, tmp_max) assert get_n_current_trials(200) == min(200, tmp_max) + del os.environ["FLAML_MAX_CONCURRENT"] def test_iloc_pandas_on_spark():