github/backbone
1
1
Fork 0
mirror of https://github.com/jashkenas/backbone.git synced 2026-01-14 09:27:53 -05:00
Code Issues Packages Projects Releases Wiki Activity

removing view.make

Browse Source
This commit is contained in:
Tim Griesser
2012-12-28 14:00:13 -05:00
parent d63fe9e61f
commit c1e62cda99
2 changed files with 2 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
backbone.js
View File

@@ -1272,18 +1272,6 @@
return this;
},
// For small amounts of DOM Elements, where a full-blown template isn't
// needed, use **make** to manufacture elements, one at a time.
//
// var el = this.make('li', {'class': 'row'}, this.model.escape('title'));
//
make: function(tagName, attributes, content) {
var $el = Backbone.$('<' + tagName + '>');
if (attributes) $el.attr(attributes);
if (content != null) $el.html(content);
return $el[0];
},
// Change the view's element (`this.el` property), including event
// re-delegation.
setElement: function(element, delegate) {
@@ -1353,7 +1341,8 @@
var attrs = _.extend({}, _.result(this, 'attributes'));
if (this.id) attrs.id = _.result(this, 'id');
if (this.className) attrs['class'] = _.result(this, 'className');
this.setElement(this.make(_.result(this, 'tagName'), attrs), false);
var $el = Backbone.$('<' + _.result(this, 'tagName') + '>').attr(attrs);
this.setElement($el, false);
} else {
this.setElement(_.result(this, 'el'), false);
}

16
test/view.js
View File

@@ -29,22 +29,6 @@ $(document).ready(function() {
strictEqual(view.$('a b').html(), 'test');
});
test("make", 3, function() {
var div = view.make('div', {id: 'test-div'}, "one two three");
equal(div.tagName.toLowerCase(), 'div');
equal(div.id, 'test-div');
equal($(div).text(), 'one two three');
});
test("make can take falsy values for content", 2, function() {
var div = view.make('div', {id: 'test-div'}, 0);
equal($(div).text(), '0');
div = view.make('div', {id: 'test-div'}, '');
equal($(div).text(), '');
});
test("initialize", 1, function() {
var View = Backbone.View.extend({
initialize: function() {