Commit Graph

3203 Commits

Author SHA1 Message Date
Jacob Buck
6cff9419fb Add findIndex and findLastIndex underscore methods to Collection. 2015-09-30 10:20:33 +13:00
Jeremy Ashkenas
979adf5200 Merge pull request #3803 from jridgewell/removeModels-regression
Fix _removeModels regression
2015-09-25 10:48:48 -04:00
Adam Krebs
bd0fbdea4d Merge pull request #3553 from megawac/extend-create
Use _.create in extend
2015-09-24 11:42:24 -04:00
Justin Ridgewell
4b64eebcba Fix _removeModels regression
Fixes #3693.

This leaves open the question of whether events triggered on the model
during a ‘remove’ listener should also trigger on the model. Just
something to revisit for V2.

```js
col.on('other', (model) => {
// Should this be triggered?
});

col.on('remove', (model) => {
// If the model is really "removed" (we can't `#get` it anymore)
// by the time this listener is called, then I'd argue that this
// shouldn't trigger the 'other' event on the collection...
model.trigger('other');
});
```
2015-09-23 11:24:16 -04:00
Justin Ridgewell
02666a6d8d Merge pull request #3800 from FishbaitHarry/master
Docs for Collection#at behavior
2015-09-22 15:39:23 -04:00
FishbaitHarry
73578911e8 Docs for Collection#at behavior 2015-09-22 21:34:40 +02:00
Graeme Yeates
3c6fabbc8f Use _.create in extend 2015-09-18 12:58:02 -04:00
Justin Ridgewell
fd44dd4499 Merge pull request #3692 from akre54/modelid-docs
update modelId docs
2015-09-18 12:29:42 -04:00
Justin Ridgewell
e33de12fcd Merge pull request #3754 from paulfalgout/patch-1
Remove _.matches proxy ref in docs
2015-09-18 12:26:43 -04:00
Justin Ridgewell
fba51b6e2a Merge pull request #3735 from akre54/readme-help
Add alternative help channels to README
2015-09-18 12:25:35 -04:00
Adam Krebs
13d87a3d35 Merge pull request #3797 from jdalton/msedge
Add MS Edge to karma-sauce runner.
2015-09-18 12:16:43 -04:00
Adam Krebs
87eade612d Merge pull request #3794 from garrettmaring/master
Test for conflicting className/id and attributes
2015-09-18 12:09:42 -04:00
Garrett Maring
afd2ce8b59 Test for conflicting className/id and attributes 2015-09-17 16:44:36 -07:00
John-David Dalton
c2a2aa9d9f Add MS Edge to karma-sauce runner. 2015-09-17 14:28:43 -07:00
Adam Krebs
c59149ec2f Merge pull request #3787 from paulfalgout/patch-3
fix incorrect closing b tag
2015-09-08 08:27:26 -04:00
Paul Falgout
10b7df9f95 fix incorrect closing b tag 2015-09-05 15:11:53 -05:00
Jeremy Ashkenas
05fde9e201 Backbone.js 1.2.3 1.2.3 2015-09-03 11:56:05 -04:00
Jeremy Ashkenas
b75329c22d Merge pull request #3771 from akre54/delegate-undelegate-docs
Document delegate/undelegate
2015-09-03 11:50:26 -04:00
Adam Krebs
e8ba576d92 document delegate/undelegate 2015-08-24 00:05:56 -04:00
Jeremy Ashkenas
45a68a55d0 Merge pull request #3770 from ahumphreys87/fixCollectionAtIssue
fix error when adding model to collection at an out of bounds index
2015-08-21 13:16:30 -04:00
Andrew Humphreys
91d0824190 fix error when adding model to collection at an out of bounds index 2015-08-21 17:15:07 +01:00
Jeremy Ashkenas
9f436d67f8 Merge pull request #3765 from paulfalgout/patch-2
Remove LICENSE from package.json files array.
2015-08-19 15:55:48 -04:00
Paul Falgout
7db3e5e627 Remove LICENSE from package.json files array.
[NPM includes LICENSE automatically.](https://docs.npmjs.com/files/package.json#files)
https://github.com/jashkenas/underscore/pull/2264
2015-08-19 14:49:04 -05:00
Jeremy Ashkenas
15a33c3d2e merged 2015-08-19 15:04:46 -04:00
Jeremy Ashkenas
00f8b6fe79 Backbone.js 1.2.2 1.2.2 2015-08-19 15:03:44 -04:00
Jeremy Ashkenas
2ee9081694 kill old email 2015-08-19 10:51:57 -04:00
Jeremy Ashkenas
09fca1dc7e Merge pull request #3663 from jridgewell/collection-set-style-compat
Collection#set style (Backwards Compatible)
2015-08-18 17:35:20 -04:00
Paul Falgout
372436a78d Remove matches proxy from docs
It's not proxied
2015-08-18 12:55:04 -05:00
Adam Krebs
fc19ee38e3 fix localStorage link 2015-08-17 00:12:55 -04:00
Justin Ridgewell
9b684dc871 Merge pull request #3759 from ohbarye/fix-link
Fixed a broken link.
2015-08-14 12:48:08 -04:00
ohbarye
6852516812 Fixed a broken link. 2015-08-15 01:40:44 +09:00
Adam Krebs
4dcbd2cb48 include -> contains 2015-08-14 11:24:46 -04:00
Adam Krebs
cf73162b9a doc fixes and tightening 2015-08-11 17:34:51 -04:00
Justin Ridgewell
caa0105b0b Merge pull request #3740 from paulfalgout/changelog-1.3
Draft change log for Backbone 1.2.2
2015-08-11 15:58:23 -04:00
Justin Ridgewell
c05c316709 Merge pull request #3751 from jdalton/ie
Add Modernizr style check for 'onhashchange' to avoid issues in IE compat modes.
2015-08-10 18:07:44 -04:00
John-David Dalton
1f29c6713a Add Modernizr style check for 'onhashchange' to avoid issues in IE compat modes. [closes #3730] 2015-08-10 12:55:41 -07:00
paulfalgout
5e5f689641 Draft change log for Backbone 1.3
While this is short update, other than the underdash stuff, both additions are featurey and much less bugfixy so I'd suggest a minor point bump.

Style references:
- Listing multiple methods: https://github.com/jashkenas/backbone/blob/1.2.1/index.html#L4445
- Similar backbone event entry https://github.com/jashkenas/backbone/blob/1.2.1/index.html#L4539

Ponderings:
- Should the model-attribute-style predicate functionality be documented better elsewhere and just referenced here?
- The fairly generic underdash log entry could be removed, though it seems as if that is predominately why this release is shipping now.  If it stays, should we link out to Underdash's github?
2015-08-10 13:16:14 -05:00
Graeme Yeates
46b461cbf9 Merge pull request #3747 from jdalton/t-for-test
Use `some`, `includes`, `map` in tests instead of `any`, `include`, `pluck`.
2015-08-07 22:31:36 -04:00
Justin Ridgewell
a6e2f0fb54 Test null set doesn't clear model.
https://github.com/jashkenas/backbone/pull/3663#discussion_r36124174
2015-08-07 13:20:41 -04:00
John-David Dalton
0bc02af704 Use some, includes, map in tests instead of any, include, pluck. 2015-08-07 01:58:09 -07:00
Graeme Yeates
a2763083c6 Merge pull request #3676 from jridgewell/collection-includes
Add Collection#includes for underscore v1.8
2015-08-06 21:17:43 -04:00
Graeme Yeates
73f08b57bd Merge pull request #3732 from jdalton/sortBy
Use `_.bind` instead of `context` param of `_.sortBy`.
2015-08-06 21:17:01 -04:00
Graeme Yeates
71b8b8e8d0 Merge pull request #3743 from jridgewell/fix-qunit-15
Setup DOM for every view test
2015-08-04 07:42:38 -04:00
Justin Ridgewell
f4d4557592 Setup DOM for every view test
Karma QUnit v0.1.5 now removes and reinserts the `#qunit-fixture`
element before every test.
2015-08-04 01:13:48 -04:00
John-David Dalton
7dc9708cc1 Use _.bind instead of context param of _.sortBy. 2015-08-03 13:52:51 -07:00
Justin Ridgewell
376249e46b Add Collection#includes for underscore v1.8 2015-08-03 16:35:15 -04:00
Jeremy Ashkenas
3e3a055467 Merge pull request #3736 from vanquang9387/adjust-index-sidebar
Update index.html: adjust toc_section font for better display on Windows
2015-07-28 17:34:05 -04:00
Van Quang
635eef5c33 Update index.html: adjust toc_section font
Adjust toc_section's font to "Lucida Grande", "Lucida Sans Unicode", Helvetica, Arial, sans-serif; for better display on Windows.
2015-07-28 17:58:24 +07:00
Adam Krebs
716764dc24 Add alternative help channels to README 2015-07-27 17:25:39 -04:00
Adam Krebs
cb47ea4340 fix grammario 2015-07-23 00:33:59 -04:00