Brad Dunbar
20a2e3408a
set _changing = false only if !alreadyChanging
2011-11-09 13:56:43 -05:00
Jason Morrison
becb826168
Make function definition formatting consistent
2011-11-04 16:22:05 -04:00
Justin
f17747e041
This means that after unbinding every event, a trigger call will return faster, because !(calls = this._callbacks) will evaluate to true.
2011-11-03 22:30:36 +00:00
Jeremy Ashkenas
3392d5fba9
relying on _.escape, and fixing a lint problem.
2011-10-31 12:35:02 -04:00
Jeremy Ashkenas
18be7107c7
fixing broken comparison.
2011-10-31 11:56:53 -04:00
Jeremy Ashkenas
35600be547
Merge branch 'events' of https://github.com/braddunbar/backbone
2011-10-31 11:49:04 -04:00
Jeremy Ashkenas
39061ff48a
Merge branch 'master' of github.com:documentcloud/backbone
2011-10-31 11:00:02 -04:00
Jeremy Ashkenas
5ebbeb0ce2
Fixes #659
2011-10-31 10:59:54 -04:00
Brad Dunbar
6da0683605
create empty tail as an invariant
2011-10-31 10:36:30 -04:00
Brad Dunbar
de2430554e
implement callbacks as linked list
2011-10-31 07:15:03 -04:00
Tim Branyen
9982e314cb
Merge pull request #700 from iros/673
...
#673 - Adding index as a property on the options object that gets passed
2011-10-29 13:30:58 -07:00
Irene Ros
80769fcf99
#673 - Adding index as a property on the options object that gets passed when the add/remove callbacks get triggered on a collection.
2011-10-29 16:29:18 -04:00
Tim Branyen
fbffb36819
Merge pull request #698 from alexgraul/master
...
Fix for Issue #690
2011-10-29 13:21:15 -07:00
Alex Graul
afc2d99b46
nicer again
2011-10-29 16:19:04 -04:00
Alex Graul
79eea1dc3c
better method names
2011-10-29 16:16:02 -04:00
Jeremy Ashkenas
b2407efb43
Merge branch 'router_no_callback' of https://github.com/derickbailey/backbone
2011-10-29 15:53:32 -04:00
Alex Graul
970ce0762c
fix for wrapped errors inside success callbacks on save, issue #690
2011-10-29 15:51:41 -04:00
Jeremy Ashkenas
8478567ecb
Needs testing, but fixes #686 , fixes #592 , and probably others -- allow you to override any $.ajax options.
2011-10-29 14:15:33 -04:00
Jeremy Ashkenas
c37e2f9bd1
Merge branch 'master' of https://github.com/alexgraul/backbone
2011-10-29 13:28:02 -04:00
Alex Graul
567e0a3c2d
Fix for adding models with custom set methods to collections, issue #539
2011-10-29 13:23:01 -04:00
Jeremy Ashkenas
de740f8ab5
Fixes #552 #693 , allowing unset to work with changedAttributes()
2011-10-29 13:12:33 -04:00
Irene Ros
2be771412b
Setting _unsetAttributes to false in unset rather than changedAttributes so that the unset attributes aren't lost on subsequent calls of changedAttributes. Added test to verify this behavior.
2011-10-29 12:27:46 -04:00
Irene Ros
d50c5e980b
Adding a _unsetAttributes property on model that stores unset attributes and appends them to the changedAttributes object.
2011-10-29 12:15:45 -04:00
Irene Ros
f6a73ff21d
Reducing the amount of properties we are iterating over by removing the old properties that already exist in now. To do that, previousAttributes had to be cloned. Changing "void 0" return to "undefined".
2011-10-29 11:51:41 -04:00
Irene Ros
f499fc8cfc
Merge branch 'master' of github.com:spmason/backbone
2011-10-29 11:39:35 -04:00
Derick Bailey
6799c8e8be
added a test and code to allow a router to define a route with no callback method for the route name
2011-10-06 19:09:53 -05:00
Les Hill
ef40512d84
Rename to undelegateEvents
...
As suggested by @jashkenas https://github.com/documentcloud/backbone/pull/620#issuecomment-2132400
2011-09-19 10:30:45 -07:00
Les Hill
1aaffa1302
Clear event callbacks with clearEvents
2011-09-18 23:29:51 -07:00
Jeremy Ashkenas
291863df55
Merge pull request #599 from walmartlabs/root-handling
...
Fix root prefix handling in navigate.
2011-09-14 14:38:59 -07:00
Matt Smith
9ba9cefd43
fix a small error in the documentation
2011-09-11 09:19:08 -04:00
kpdecker
b20f54f245
Fix root prefix handling in navigate.
...
Fixes prefix removal when the root prefix is included as part of the navigate route parameter.
2011-09-08 00:25:08 -05:00
Keith Cirkel
123b92e468
Fix incorrect variable name on docs for delegateEvents
2011-09-06 11:52:15 +02:00
Jacob Thornton
084e0288e7
add support and tests for ender jeesh
2011-08-18 16:41:42 -07:00
TrisMcC
49645de27c
Fixed misspelled word in comments for _ensureElement.
2011-08-18 14:21:52 -03:00
Steve Mason
98877ff4b6
Fix for unset attributes not being returned by changedAttributes
2011-08-11 08:55:12 +01:00
Jeremy Ashkenas
29b60e53fa
Backbone.js 0.5.3
2011-08-09 10:39:09 -04:00
Jeremy Ashkenas
44629daacc
patching a pernicious pushstate problem.
2011-08-09 10:28:20 -04:00
tbranyen
b1574b1034
allow history start to not call initial route
2011-08-07 15:23:20 -04:00
Asan Usipov
3b6864835d
Added 'groupBy' to underscore proxy methods
2011-08-04 21:25:43 +04:00
Jeremy Ashkenas
6bb43c1b81
fixes #244 -- allow View#events to be defined as a function, making it easier to call super.
2011-08-03 16:41:49 -04:00
Jeremy Ashkenas
10e71e3119
Fixes #531 , reverts 39b36af
2011-08-03 16:11:41 -04:00
Neeraj Singh
960a1c844b
Edited comment
2011-07-28 23:38:54 -03:00
Devin Hunt
b85c116caf
Ajax.processData is left as the default if emulateJSON is set to true
2011-07-27 10:59:30 +01:00
Jeremy Ashkenas
22456de207
whitespace
2011-07-26 16:00:44 -03:00
Nadav
39b36afd74
Setting to context to this by default on bind() instead of trigger()
2011-07-26 21:27:10 +03:00
Jeremy Ashkenas
9d2811a639
Backbone.js 0.5.2
2011-07-26 13:31:51 -04:00
Jeremy Ashkenas
49a16bdd32
Merge pull request #500 from keithcirkel/master
...
Issue #482
2011-07-26 10:22:43 -07:00
Chris Moore
3145b4db22
isNew should use id, not idAttribute
2011-07-25 17:48:09 -04:00
Keith Cirkel
6ef6f759b6
Add a third "context" argument to Backbone.Event.Bind which, when passed, will bind the callback to the provided context.
...
Example:
Backbone.Event.Bind('event', this.event, this);
Before this commit the way to do this was as follows:
Backbone.Event.Bind('event', _.bind(this.event, this));
2011-07-25 22:47:48 +01:00
Raimonds Simanovskis
b32a34c52f
do not call loadUrl when redirecting to hash based URL on non-push state browser
2011-07-22 17:55:09 +03:00
