Commit Graph

1207 Commits

Author SHA1 Message Date
Brad Dunbar
fb27097835 Fix #1105 - Add convenience overloads for off. 2012-03-17 09:02:23 -04:00
Jeremy Ashkenas
01fb4149e1 editing airbnb mobile 2012-03-16 16:47:10 -04:00
Harry Shoff
ec8dc945c8 Fix typo 2012-03-16 16:44:07 -04:00
Harry Shoff
8b619759df Add airbnb mobile to examples 2012-03-16 16:44:02 -04:00
Jeremy Ashkenas
a3282f4324 Merge pull request #1071 from dira/patch-2
Documentation for set - validation is skipped when passing {silent: true}
2012-03-16 13:39:32 -07:00
Jeremy Ashkenas
7e8218835c Merge branch 'master' of github.com:documentcloud/backbone 2012-03-14 10:28:50 -04:00
Jeremy Ashkenas
9414513acb Fixes #1098 2012-03-14 10:28:05 -04:00
Jeremy Ashkenas
44b40c1eac Merge pull request #1097 from lxb/optimization-1
Slight optimization for Events, cache splitting Regex
2012-03-13 18:23:23 -07:00
Alex Buck
82eed08b7a Slight optimization for Events cache splitting Regex
- cache the regular expression used to separate the event string
- changed old eventSplitter to delegateEventSplitter to remove ambiguity
- http://jsperf.com/triggering
- not caching the regex is 85% slower on chrome linux i686
2012-03-13 21:14:16 -04:00
Irina Dumitrascu
d5751d503e Improved description. 2012-03-13 13:49:08 +00:00
Jeremy Ashkenas
64f37ce00e fixes #1067, urlRoot vs collection.url() order 2012-03-12 11:22:44 -04:00
Jeremy Ashkenas
2b849a9be4 Merge pull request #1070 from dira/patch-1
Updated documentation for validate - #1063
2012-03-12 08:16:46 -07:00
Jeremy Ashkenas
58b5a22b6e fixes #1073 -- document that sync can be overridden at the collection or model level. 2012-03-12 11:12:24 -04:00
Jeremy Ashkenas
b59fa6f72b Merge pull request #1084 from dira/patch-3
Prevent javascript injection attacks when bootstrapping data #1034
2012-03-12 07:33:14 -07:00
Jeremy Ashkenas
6d85811d68 Merge pull request #1093 from afeld/test-cleanup2
clean up tests to use fresh object instances for each run and not set globals
2012-03-12 06:36:47 -07:00
Aidan Feldman
f49969014c clean up tests to use fresh object instances for each run, and don't set
globals within test files
2012-03-12 04:27:22 -04:00
Irina Dumitrascu
5d43483a10 Added a note to javascript injection attacks when bootstrapping data #1034 2012-03-09 14:19:53 +00:00
Jeremy Ashkenas
b9c6ee91cb Merge pull request #1079 from paulmillr/add-links-to-software
Add links to software.
2012-03-07 13:49:28 -08:00
Paul Miller
3c69806f8d Add links to software. 2012-03-07 23:44:38 +02:00
Jeremy Ashkenas
5db14ff4de Merge branch 'master' of github.com:documentcloud/backbone 2012-03-07 16:17:49 -05:00
Jeremy Ashkenas
fdfe0105af adding chaincal as an example app 2012-03-07 16:17:18 -05:00
Irina Dumitrascu
9928deee95 Documentation for set - mention that the validation is skipped when passing {silent: true} 2012-03-06 13:14:51 +00:00
Irina Dumitrascu
c473066c9d Updated documentation for validate #1063 2012-03-06 13:04:59 +00:00
brad dunbar
1f40de7539 Merge pull request #1065 from ewang/master
fix typo in index.html
2012-03-03 13:12:13 -08:00
Eric Wang
f422291547 fix typo in index.html 2012-03-03 11:47:13 -08:00
Jeremy Ashkenas
673d07beaf adding attictv and codiqa as example apps 2012-03-01 10:43:57 -05:00
addyosmani
3cf1bb4ed5 Updating with latest version from TodoMVC
As requested in #1044, here's the latest version of the Backbone.js
Todo app as rewritten by our project.

We started out with the 0.5 base and re-wrote it to cover some subtle
best practices we thought were important. Ours, like the current one
also uses the latest Backbone and jQuery 1.7.1. As part of the changes,
we also introduced two differences in the UX:

* When in edit mode, if a todo item is emptied and then blurred, the
item is removed. This contrasts with the current behaviour of the app
in the official repo at the moment which maintains the empty item in
place (albeit looking a little broken
http://addyosmani.com/gyazo/bbd4cd.png)

* We removed the tooltip occasionally seen when a user was trying to
add a new item. Having discussed this with developers frequently using
the Todo app as an initial point of reference, it was a consensus that
the notification didn't really offer that much value nor did it really
show anything that Backbone-specific worth keeping it in for.

We usually enforce examples separate concerns (Models, Views etc.) into
their own directories pre-build, but I've reformatted it to match the
structure your current app takes so that it can be more easily diffed.

I hope it's worth considering our version for a merge. We're happy to
take on any feedback needed to update it to address concerns you might
have.
2012-02-27 21:41:27 +00:00
Jeremy Ashkenas
77c12aca8f Merge pull request #1041 from braddunbar/undelegate
Fix #986 - Undelegate events before changing `el`.
2012-02-27 13:07:33 -08:00
Brad Dunbar
6c392fa69a Fix #986 - Undelegate events before changing el. 2012-02-27 15:01:05 -05:00
Jeremy Ashkenas
dca02ecab7 Fixes #1053 -- updating comment to reflect changed style of validate() 2012-02-27 14:56:21 -05:00
Jeremy Ashkenas
5ef4921c54 merging async test. 2012-02-27 14:37:50 -05:00
Jeremy Ashkenas
f930b5f042 adding additional router test 2012-02-27 14:37:13 -05:00
Jeremy Ashkenas
83d2918bc7 removing a test that is invalid in IE. 2012-02-27 14:32:30 -05:00
Jeremy Ashkenas
54e284bced Merge branch 'master' of github.com:documentcloud/backbone 2012-02-27 14:30:26 -05:00
Jeremy Ashkenas
07604deac0 merging in hash fixer for FF 2012-02-27 14:30:23 -05:00
Brad Dunbar
f8b37a84b5 Add test for #1048. 2012-02-27 14:23:49 -05:00
Brad Dunbar
111d5a1f19 Add a test for #1052. 2012-02-27 14:16:00 -05:00
Jeremy Ashkenas
b37a09662e Merge pull request #1048 from marat-dreizin/master
Added ability to avoid an additional '$()' call in 'setElement' method if current 'element' is already wrapped with '$()'
2012-02-27 11:14:50 -08:00
Jeremy Ashkenas
c9599d6ba0 fixing or= JS style for sync options. 2012-02-27 14:04:44 -05:00
Jeremy Ashkenas
a91b325c99 Merge pull request #1052 from Sid3Show/master
Fix to make Backbone.sync options parameter optional again
2012-02-27 11:03:49 -08:00
Oli
daea564e8a Made Backbone.sync options parameter optional 2012-02-27 18:04:59 +00:00
Jeremy Ashkenas
41e9d1a847 Merge pull request #1040 from braddunbar/$-docs
Fixes #1038 - Document changes to `view.$`.
2012-02-25 06:37:38 -08:00
Marat Dreizin
0d1d278c7b Added ability to avoid an additional '$()' call in 'setElement' method if current 'element' is already wrapped with '$()' 2012-02-25 02:05:12 +03:00
Brad Dunbar
ef5835ac5a Fixes #1038 - Document changes to view.$. 2012-02-22 18:35:07 -05:00
Jeremy Ashkenas
a960794534 Merge pull request #1024 from braddunbar/locals
Use local references to `Model`, `View`, etc.
2012-02-18 21:54:12 -08:00
Brad Dunbar
e3098484ce Use local references to Model, View, etc. 2012-02-18 12:35:50 -05:00
Jeremy Ashkenas
4de073ca14 Merge pull request #1023 from braddunbar/events
Clean up `Backbone.Events`.
2012-02-18 07:29:26 -08:00
Brad Dunbar
f92fa9a0bd Clean up Backbone.Events.
* Refactor `Backbone.Events` for increased clarity.
* Update documentation to include multiple events.
* Use `event` consistently throughout.
2012-02-18 09:19:26 -05:00
Brad Dunbar
c8cbde2e73 Correct more grammar. 2012-02-17 10:28:51 -05:00
brad dunbar
6560ad836b Merge pull request #1022 from hswolff/grammar-fixes
fix instances of it's to its for proper grammar
2012-02-17 06:33:17 -08:00