github/backbone
1
1
Fork 0
mirror of https://github.com/jashkenas/backbone.git synced 2026-04-30 03:00:06 -04:00
Code Issues Packages Projects Releases Wiki Activity
2,800 Commits 4 Branches 35 Tags
4fd9da4f818d84b594be26de7964e4fc9e97e17e
Commit Graph

834 Commits

Author SHA1 Message Date
Adam Krebs
4fd9da4f81 style tweaks 2015-02-17 19:24:35 -05:00
Adam Krebs
0df246e1f6 Merge pull request #3488 from platinumazure/include-updated-options-in-sync-callback 
Include updated options in sync callbacks
 2015-02-17 19:20:02 -05:00
Kevin Partington
b331afede1 Small style tweaks per akre54's comments on the pull request. 2015-02-17 19:13:19 -05:00
Adam Krebs
d52b5f92ae Revert "History's root" 2015-02-17 17:41:06 -05:00
Adam Krebs
074544afe8 Merge pull request #3443 from jridgewell/history-root 
History's root
 2015-02-17 17:27:25 -05:00
Justin Ridgewell
6aed2485ae Revert "Merge pull request #3465 from jridgewell/trigger-objects" 
This reverts commit 760004faa7, reversing
changes made to 7315c56d2e.
 2015-02-17 17:06:21 -05:00
Yousef Cisco
2d041d799d Updated Model to allow configuration of the cid prefix 2015-02-12 17:16:55 +00:00
Kevin Partington
1088d18a21 Collection#fetch, Model#save, Model#fetch, and Model#destroy should all pass extra sync options to success callbacks. 2015-02-10 20:28:20 -06:00
Kevin Partington
780c84744a Collection#create passes extra options added by model sync to success callback 2015-02-10 19:59:22 -06:00
Jeremy Ashkenas
377b9c89e4 Merge pull request #3485 from megawac/qunit-update 
[minor] Update QUnit to v1.7.1
 2015-02-10 10:47:20 -05:00
Graeme
1577524edd Update QUnit to v1.7.1 2015-02-10 00:31:04 -05:00
Stephen Thomas
0f2e968913 Add failing test for save and wait. 2015-02-05 07:33:25 -05:00
Jeremy Ashkenas
713c288475 Merge pull request #3455 from jridgewell/listenTo-memory-leak 
Fix listenTo memory leak
 2015-02-03 14:16:15 -05:00
Jeremy Ashkenas
c1ce7a7484 Merge pull request #3423 from jridgewell/ajax_context 
Call the success callback with context
 2015-02-02 13:48:49 -05:00
Justin Ridgewell
3aac74d121 Undo concat #on tests 2015-01-29 23:23:22 -05:00
Justin Ridgewell
778d447922 Address listenTo and off memory leak 
https://github.com/jashkenas/backbone/pull/3455#issuecomment-71677970
 2015-01-27 20:55:54 -05:00
Justin Ridgewell
59c3704955 Test trigger arguments behavior 
To be clear, I think the trigger with object behavior is silly. But I
needed tests to ensure that my [`eventsApi` refactor]
(https://github.com/jridgewell/backbone/tree/eventsApi-refactor) kept
the current functionality.
 2015-01-26 16:54:54 -05:00
Justin Ridgewell
7ecf183dce Test trigger arguments behavior 
To be clear, I think the trigger with object behavior is silly. But I
needed tests to ensure that my [`eventsApi` refactor]
(https://github.com/jridgewell/backbone/tree/eventsApi-refactor) kept
the current functionality.
 2015-01-25 13:49:19 -05:00
Justin Ridgewell
0c200ca31f Delete events hash if there are none. 2015-01-24 14:56:10 -05:00
Justin Ridgewell
85fb8c30de Fix listenTo memory leak 
Fixes https://github.com/jashkenas/backbone/issues/3453
 2015-01-24 14:56:10 -05:00
Justin Ridgewell
c48cf5f22e Do not alter the "on" events array 2015-01-24 14:44:17 -05:00
Justin Ridgewell
85885130a8 Ensure listenToOnce without a callback noops 
This mirrors the test directly above, ensuring `#once` without a
callback noops.
 2015-01-23 14:08:21 -05:00
Brad Dunbar
1b0c67bdf8 Collection#set - options.at accepts a string. 
Closes #3353.
 2015-01-23 06:33:15 -05:00
Brad Dunbar
dc048c6bf8 Ensure events are triggered by the correct name. 2015-01-19 12:36:44 -05:00
Brad Dunbar
f6695d13fe Fix #3448. Ensure listenToOnce splits event names. 
Calling `listenToOnce('x y', …)` should be functionally equivalent
to `listenToOnce('x', …); listenToOnce('y', …)`.
 2015-01-19 09:42:11 -05:00
Justin Ridgewell
e58e6f0e41 Fix issue with atRoot matching. 
This is to support legacy:

When an app is served at `/root`, but registers its root as `/root/`, we
should still consider the current location as the root when
transitioning from a pushState enabled browser to a hashChange browser.
 2015-01-12 18:38:20 -05:00
Justin Ridgewell
50f364c111 Add test case for root with mandatory trailing slash 2015-01-12 16:50:54 -05:00
Justin Ridgewell
ab304871d7 Simplify History.root 2015-01-12 15:22:32 -05:00
Brad Dunbar
7af3329175 Ensure a search test fails when appropriate. 2015-01-04 11:38:51 -05:00
Justin Ridgewell
c2b2a71c29 Call the success callback with context 
Fixes https://github.com/jashkenas/backbone/issues/3283.
 2014-12-22 12:01:28 -05:00
Adam Krebs
29244e4175 Merge pull request #3307 from gf3/model-matches 
Add `Model::matches` as special-cased proxy to `_.matches`
 2014-12-15 12:15:33 -05:00
Brad Dunbar
151d252186 Merge pull request #3359 from braddunbar/transition-params 
Transition with search params.
 2014-11-30 08:40:17 -05:00
Brad Dunbar
7e67491049 Leave out unnecessary trailing slash. 2014-11-26 16:49:50 -05:00
Brad Dunbar
efb60cc223 Ensure iframe hash is set. 2014-11-16 10:16:26 -05:00
James Hartig
c3b09ddb98 Collection.add accepts negative indexes for the at option 2014-11-14 16:06:14 -05:00
Adam Krebs
0519e7df6f Code style cleanup in collection tests and add an extra sort test 2014-11-13 12:06:44 -05:00
Adam Krebs
bc88f125f1 Merge pull request #3381 from fastest963/orderSort 
Order should trigger a sort iff order was changed
 2014-11-13 11:43:29 -05:00
James Hartig
787ee49d7e Order should trigger a sort iff order was changed 2014-11-13 11:39:11 -05:00
robrobbins
f2fe23e339 use number of assertions, not another var 2014-11-12 15:12:05 -07:00
robrobbins
51d076c9be listen for invalid, not error 2014-11-11 12:45:52 -07:00
Justin Ridgewell
2450b70af8 Test that listenToOnce is only called once 2014-11-03 09:52:14 -05:00
Justin Ridgewell
fab32cc93a Remove duplicated tests 2014-11-03 09:52:14 -05:00
Adam Krebs
740946142e check for cleaned up references in listenToOnce with stopListening 2014-11-03 09:52:14 -05:00
Justin Ridgewell
b3ab6117c0 Test both _listeningTo and _events are empty 2014-11-03 09:52:13 -05:00
Adam Krebs
c6a1df5084 use clearer event names 2014-11-03 09:52:13 -05:00
Adam Krebs
d84e15b08c test for correct context in event maps 2014-11-03 09:52:12 -05:00
Jmeas
459dc24f80 Fixes listenToOnce memory leak. 2014-11-03 09:52:12 -05:00
Jmeas
71cecdc1e2 Failing spec for listenToOnce 2014-11-03 09:52:12 -05:00
Brad Dunbar
ea9f5b8c47 Transition with search params. 2014-10-24 11:42:19 -04:00
Brad Dunbar
23599e7472 Update trailing slash for search params. 2014-10-23 18:16:29 -04:00