github/backbone
1
1
Fork 0
mirror of https://github.com/jashkenas/backbone.git synced 2026-01-15 01:47:55 -05:00
Code Issues Packages Projects Releases Wiki Activity
1,914 Commits 4 Branches 35 Tags
614f0b83115b75c6f7894dea4e8b251b8de4700a
Commit Graph

960 Commits

Author SHA1 Message Date
Adam Krebs
0b5774b311 initial attempt at moving add logic to update 2013-02-13 00:38:41 -05:00
Casey Foster
5cf670139c Refactor update to reduce wasted lookups 2013-02-11 09:52:05 -08:00
Casey Foster
93967561d9 Refactor, account for double-parse bug in update 2013-02-10 10:03:34 -08:00
Casey Foster
86451644f0 Fix possible memory leak in stopListening, refactor 2013-02-08 23:17:26 -08:00
Casey Foster
ee350e156e Update parses at model level, simpler get 2013-02-07 18:07:52 -08:00
brad dunbar
e4c046cd4d Merge pull request #2221 from tgriesser/sync-revert2 
Making error/success handlers promise compatible
 2013-02-05 08:01:34 -08:00
Casey Foster
0631d158ed Fix #2228 - Add findWhere for parity with underscore 2013-01-31 15:45:59 -08:00
Casey Foster
50201bea86 One simplification step further... 2013-01-31 06:47:11 -08:00
Brad Dunbar
5a72cac5db Add missing wrapError and simplify a bit. 2013-01-31 01:56:12 -05:00
Tim Griesser
6e646f1ba7 making error/success handlers promise compatible 2013-01-30 23:41:05 -05:00
Casey Foster
103c9e87e4 triggerEvents now under the 80 char line and even faster! 2013-01-29 10:15:46 -08:00
KungD
770883fd25 added event functions chaining tests 2013-01-27 15:04:18 +01:00
Krawaller
a4929aad47 Update backbone.js 
In `Events.once` we can streamline the final statements `this.on(...); return this;` into `return this.on(...)`, as `Events.on` also returns `this`. Saves a row for a very slight loss of readability.

Same thing applies in the `_.each` loop where we set up the IoC versions of `on` and `once`.
 2013-01-27 10:19:56 +01:00
Jeremy Ashkenas
4be1288923 tweaking variable name 2013-01-25 20:42:14 +10:00
Jeremy Ashkenas
4d6b813fad Merge pull request #2049 from gsamokovarov/listen-to-once 
Add Events#listenToOnce
 2013-01-25 02:40:29 -08:00
Dmytro Nemoga
f5d703b1c8 Return "this" reference 
Forgot one more return statement.
 2013-01-24 21:15:18 +02:00
Dmytro Nemoga
fee896725e Return "this" reference 
Return "this" is a good convention that allow to use chains.
 2013-01-24 18:40:58 +02:00
Casey Foster
fbcfea4c5f Refactor var name list -> events for clarity, uniformity 2013-01-22 09:21:48 -08:00
Diego Tres
beea398c8f Changed the year from 2012 to 2013. 2013-01-22 07:36:38 -02:00
Tim Griesser
e716b86ac9 documenting validationError 2013-01-21 14:17:23 -05:00
Genadi Samokovarov
3caee55366 Rename Events#oneTimeListenTo to Events#listenToOnce 2013-01-17 23:20:18 +02:00
Genadi Samokovarov
02d42348b7 Add Events#oneTimeListenTo 2013-01-17 23:06:38 +02:00
Casey Foster
87ee87dc3a Tidy up event internals, delete empty event keys in off, return this early in stopListening 2013-01-17 12:04:13 -08:00
Chris Smith
4aaf3b8556 Fixed comment for Model#_validate 
The comment needed to be updated for the new "invalid" event type in the implementation.
 2013-01-16 12:41:09 -07:00
Jeremy Ashkenas
9b3fa12fad Reverting #2106 -- satisfying lint. 2013-01-16 13:41:38 +11:00
Jeremy Ashkenas
902c3e2342 Revert "Issue number in comments." 
This reverts commit b890e3e2f2.
 2013-01-16 13:16:44 +11:00
Tim Griesser
289d76d352 Merge pull request #2112 from braddunbar/issue-comments 
Issue number in comments.
 2013-01-15 13:31:13 -08:00
Tim Griesser
f12518ec5c bumping to 0.9.10 2013-01-15 15:15:37 -05:00
Casey Foster
179887e116 Consistent argument names across event functions, remove unused argument from triggerEvents 2013-01-15 07:01:32 -08:00
Casey Foster
4d8ca2b837 Account for listenTo/stopListening edge cases, add tests 2013-01-15 06:53:39 -08:00
Brad Dunbar
80fbe37c77 Bail from listenTo early. 2013-01-15 08:24:25 -05:00
brad dunbar
b443fb061b Merge pull request #2132 from tgriesser/listenTo-patch 
Fix for #2100
 2013-01-15 05:21:06 -08:00
Tim Griesser
201f9e4f18 fix for #2100 2013-01-15 07:59:24 -05:00
Genadi Samokovarov
172ecd4330 Use === instead of == in Model#save 
Its just a nit pick. I stumbled upon it today.
 2013-01-13 15:03:11 +02:00
brad dunbar
9e80717877 Merge pull request #2106 from akre54/array-reset-speed-testing 
Faster Collection _reset
 2013-01-12 13:17:52 -08:00
Brad Dunbar
b890e3e2f2 Issue number in comments. 2013-01-12 08:45:34 -05:00
Casey Foster
975a44a6f1 Consistently turn on parse flag in save, like fetch already does 2013-01-11 08:20:57 -08:00
Adriaan Labuschagne
b653186c4a removed unused variable 'model' from 'save' function 2013-01-10 22:40:42 -05:00
Adam Krebs
7efec383a0 add collection models init to constructor 2013-01-10 14:31:06 -05:00
Brad Dunbar
95480b8f1a Semicolon. 2013-01-10 10:58:00 -05:00
Casey Foster
edb68c7b95 Fix #2099 - sortedIndex use model attributes for string iterator 2013-01-10 07:49:06 -08:00
Adam Krebs
e928d27227 use slice instead of _.clone per @caseywebdev 2013-01-10 09:19:00 -05:00
Adam Krebs
857e2da8cc trying with faster array reset code (see http://stackoverflow.com/q/1232040) 2013-01-10 00:00:06 -05:00
Casey Foster
ba8f1800bc Remove useless code in add, tidy up 2013-01-08 09:07:21 -08:00
Brad Dunbar
016825e725 Add a test for the "route" event. 2013-01-07 11:27:32 -05:00
bodokaiser
317c5b9763 changed trigger call 2013-01-07 11:27:32 -05:00
bodokaiser
17bb8bacc0 route parameters provided as array argument 2013-01-07 11:27:32 -05:00
bodokaiser
52dc7de74f added trigger applyment 2013-01-07 11:27:32 -05:00
Casey Foster
6e3e137019 Revert "Add keys, values, pairs, invert, pick, omit, each, and other" 
This reverts commit faa776a67c.
 2013-01-06 15:48:01 -08:00
Adam Krebs
faa776a67c Add keys, values, pairs, invert, pick, omit, each, and other 
underscore methods to models
 2013-01-06 16:53:17 -05:00