Commit Graph

889 Commits

Author SHA1 Message Date
Justin Ridgewell
dba0faad09 Collection#invoke should collect arguments
Fixes https://github.com/jashkenas/backbone/issues/3610.
2015-05-15 20:26:58 -04:00
Jeremy Ashkenas
bc73e25c5e Fixes #3512 2015-05-13 18:03:53 -04:00
Jeremy Ashkenas
a1c65e2420 s/updated/update 2015-05-13 17:39:05 -04:00
Jeremy Ashkenas
3150eec295 merged in 'updated' 2015-05-13 17:37:54 -04:00
Jeremy Ashkenas
6ef574669b Merge pull request #3594 from jridgewell/eventsApi-refinements
Refine eventsApi
2015-05-13 16:11:31 -04:00
Adam Krebs
c731f721f3 Merge branch 'master' into bb-120 2015-05-13 11:59:33 -04:00
Jeremy Ashkenas
4aa539d3db Merge pull request #3577 from jridgewell/destroy-zalgo
Always call success async
2015-05-13 11:19:39 -04:00
Adam Krebs
6ea3bfb665 merge in master branch 2015-05-13 11:10:03 -04:00
Justin Ridgewell
9ad11ddf80 Ensure #on and #off **never** alter callback list 2015-05-01 20:20:21 -04:00
Justin Ridgewell
020bec3b22 Refine eventsApi
Based off code from https://github.com/jashkenas/backbone/pull/3476
2015-05-01 20:20:21 -04:00
Brad Dunbar
1eb03c8354 Clean up. 2015-04-28 07:17:15 -04:00
Brad Dunbar
c8968853a2 Simplify. 2015-04-28 07:13:54 -04:00
Brad Dunbar
24daf350e4 Use more descriptive test names. 2015-04-28 06:56:40 -04:00
Brad Dunbar
21180e7234 Handle roots with regex characters. 2015-04-28 06:55:10 -04:00
Brad Dunbar
c1e70a28aa If the root doesn't match, no routes can match. 2015-04-28 06:34:28 -04:00
Justin Ridgewell
d7943fe4c0 Always call success async
Let's not [unleash
Zalgo](http://blog.izs.me/post/59142742143/designing-apis-for-asynchrony
).
2015-04-23 14:03:50 -04:00
Adam Krebs
401fdbd02c Merge branch 'master' into bb-120
Conflicts:
	index.html
2015-03-20 11:44:34 -04:00
Adam Krebs
bf731534aa Merge pull request #3507 from akre54/matches-with-callback
Matches with predicate
2015-03-20 11:33:01 -04:00
Jeremy Ashkenas
dfec4b837d Merge pull request #3463 from jridgewell/on-does-not-alter
Do not alter the "on" events array
2015-03-04 11:35:24 -05:00
Justin Ridgewell
8b28f31e95 Merge pull request #3523 from braddunbar/test-scripts
Sync test scripts with karma config.
2015-03-03 10:12:08 -05:00
Brad Dunbar
6c63ef2cb5 Set the pathname explicitly for phantomjs. 2015-03-03 07:50:31 -05:00
Brad Dunbar
75b9c0db0a Sync test scripts with karma config. 2015-03-03 07:48:31 -05:00
Jeremy Ashkenas
e109f6d3e7 Merge pull request #3434 from braddunbar/decode-fragment
Decode unicode escapes without decoding `%25`.
2015-02-23 11:48:55 -05:00
Adam Krebs
74fdd620d7 fix comma at end of collections test 2015-02-22 11:58:06 -05:00
Graeme
f02ba1f47b Run test suite using karma 2015-02-20 15:12:09 -05:00
Adam Krebs
499f6af3b9 allow Model#matches to take a predicate function 2015-02-19 09:39:00 -05:00
Adam Krebs
96f7746393 bump Underscore dependency to 1.7.0 2015-02-19 09:35:51 -05:00
Adam Krebs
bc014663f2 Remove AMD test. We know it works, no need to keep an extra file around. 2015-02-19 00:06:50 -05:00
Adam Krebs
4fd9da4f81 style tweaks 2015-02-17 19:24:35 -05:00
Adam Krebs
0df246e1f6 Merge pull request #3488 from platinumazure/include-updated-options-in-sync-callback
Include updated options in sync callbacks
2015-02-17 19:20:02 -05:00
Kevin Partington
b331afede1 Small style tweaks per akre54's comments on the pull request. 2015-02-17 19:13:19 -05:00
Adam Krebs
d52b5f92ae Revert "History's root" 2015-02-17 17:41:06 -05:00
Adam Krebs
074544afe8 Merge pull request #3443 from jridgewell/history-root
History's root
2015-02-17 17:27:25 -05:00
Justin Ridgewell
6aed2485ae Revert "Merge pull request #3465 from jridgewell/trigger-objects"
This reverts commit 760004faa7, reversing
changes made to 7315c56d2e.
2015-02-17 17:06:21 -05:00
Adam Krebs
19f9905fec Merge branch 'master' into bb-120
Conflicts:
	backbone.js
	docs/backbone.html
	test/collection.js
	test/events.js
2015-02-13 17:20:43 -05:00
Yousef Cisco
2d041d799d Updated Model to allow configuration of the cid prefix 2015-02-12 17:16:55 +00:00
Kevin Partington
1088d18a21 Collection#fetch, Model#save, Model#fetch, and Model#destroy should all pass extra sync options to success callbacks. 2015-02-10 20:28:20 -06:00
Kevin Partington
780c84744a Collection#create passes extra options added by model sync to success callback 2015-02-10 19:59:22 -06:00
Jeremy Ashkenas
377b9c89e4 Merge pull request #3485 from megawac/qunit-update
[minor] Update QUnit to v1.7.1
2015-02-10 10:47:20 -05:00
Graeme
1577524edd Update QUnit to v1.7.1 2015-02-10 00:31:04 -05:00
Stephen Thomas
0f2e968913 Add failing test for save and wait. 2015-02-05 07:33:25 -05:00
Jeremy Ashkenas
713c288475 Merge pull request #3455 from jridgewell/listenTo-memory-leak
Fix listenTo memory leak
2015-02-03 14:16:15 -05:00
Jeremy Ashkenas
c1ce7a7484 Merge pull request #3423 from jridgewell/ajax_context
Call the success callback with context
2015-02-02 13:48:49 -05:00
Justin Ridgewell
3aac74d121 Undo concat #on tests 2015-01-29 23:23:22 -05:00
Justin Ridgewell
3d3f0a0b02 Prevent "on" and "off" from altering trigger events array 2015-01-28 15:31:55 -05:00
Justin Ridgewell
778d447922 Address listenTo and off memory leak
https://github.com/jashkenas/backbone/pull/3455#issuecomment-71677970
2015-01-27 20:55:54 -05:00
Justin Ridgewell
59c3704955 Test trigger arguments behavior
To be clear, I think the trigger with object behavior is silly. But I
needed tests to ensure that my [`eventsApi` refactor]
(https://github.com/jridgewell/backbone/tree/eventsApi-refactor) kept
the current functionality.
2015-01-26 16:54:54 -05:00
Justin Ridgewell
7ecf183dce Test trigger arguments behavior
To be clear, I think the trigger with object behavior is silly. But I
needed tests to ensure that my [`eventsApi` refactor]
(https://github.com/jridgewell/backbone/tree/eventsApi-refactor) kept
the current functionality.
2015-01-25 13:49:19 -05:00
Justin Ridgewell
0c200ca31f Delete events hash if there are none. 2015-01-24 14:56:10 -05:00
Justin Ridgewell
85fb8c30de Fix listenTo memory leak
Fixes https://github.com/jashkenas/backbone/issues/3453
2015-01-24 14:56:10 -05:00