Commit Graph

509 Commits

Author SHA1 Message Date
Brad Dunbar
82ee97d36b Use null for uninitialized variables. 2012-02-17 07:22:43 -05:00
Brad Dunbar
69b80f5e3a Fixes #959 - Silent changes fire 'change:attr'.
* Silent changes are tracked so `'change:attr'` can be
  fired next time `change` is called.
* Pending changes are tracked to prevent infinite loops
  and accurately reflect nested changes.
2012-02-17 07:22:43 -05:00
Brad Dunbar
232c888038 fixes #1003 - History is started before navigate 2012-02-15 00:39:38 -05:00
Brad Dunbar
8b285c6c83 on is a noop if no callback is provided 2012-02-14 15:22:27 -05:00
Jeremy Ashkenas
a603e5a843 resolving merge with master. 2012-02-13 14:41:46 -05:00
Jeremy Ashkenas
18fba57724 Much asked-for change. Instead of throwing an early error when adding duplicate models, Backbone will simply skip them instead. 2012-02-13 14:39:36 -05:00
vlad
3761d28188 fixes #972 by cleaning up a messy conditional 2012-02-08 17:05:38 -08:00
Jeremy Ashkenas
2a92f71dcc Merge branch 'master' of github.com:documentcloud/backbone 2012-02-08 16:59:11 -05:00
Jeremy Ashkenas
e3ac6f8eaa Adding Collection#push, pop, shift, and unshift to the API, returning references to the model. Fixing a too-unescaped regex. 2012-02-08 16:58:37 -05:00
Stan Angeloff
b993441e5e Tiny spelling error, no functional changes. 2012-02-07 14:09:48 +02:00
Brad Dunbar
522e090831 fixes #964 - collection.get has consistent return 2012-02-06 16:45:06 -05:00
Brad Dunbar
3ef9c3a5fc Add tests for #908, #933. 2012-02-03 10:17:45 -05:00
Jeremy Ashkenas
a865aa41f1 removing obsolete error case. 2012-02-02 17:15:28 -05:00
Jeremy Ashkenas
4337fc3ff3 comments for setDomLibrary 2012-02-02 16:34:09 -05:00
Jeremy Ashkenas
0ffd7ea2ca merging in setDomLibrary 2012-02-02 16:30:56 -05:00
Jeremy Ashkenas
8a427f3018 DRY-ing up _validate 2012-02-02 16:22:10 -05:00
Jeremy Ashkenas
738e25dd4d options.silent respected in _prepareModel ... prepping for a 0.9.1 2012-02-02 16:19:19 -05:00
Jeremy Ashkenas
d187f7f989 Merge pull request #906 from tomasztunik/master
Fixes issue #904
2012-02-02 13:02:01 -08:00
Jeremy Ashkenas
eb4753862e #917, adding an Model#isValid() function. 2012-02-02 15:54:34 -05:00
Jeremy Ashkenas
0e709e456f Merge branch 'master' of github.com:documentcloud/backbone 2012-02-02 15:40:13 -05:00
Jeremy Ashkenas
aafbcb05e5 Fixes #917 -- reverts validate() behavior to never run on silent sets. 2012-02-02 15:40:06 -05:00
Jeremy Ashkenas
fc2c4ded7c Merge pull request #920 from braddunbar/$
use `$` as DOM abstraction library
2012-02-02 12:17:48 -08:00
Jeremy Ashkenas
ad870b256c Fixes #933, Fixes #908 2012-02-02 14:41:36 -05:00
Jeremy Ashkenas
799b9b3dd4 Revert "Fixes #935. ensuring that sync is triggered on the collection after the model is removed."
This reverts commit 0cbcdc96eb.
2012-02-02 14:13:19 -05:00
Jeremy Ashkenas
0cbcdc96eb Fixes #935. ensuring that sync is triggered on the collection after the model is removed. 2012-02-02 14:09:54 -05:00
Brad Dunbar
17d0f12a59 use a while loop instead of do...while 2012-02-02 11:24:39 -05:00
Brad Dunbar
29a4359ff7 fixes #915 - nested 'change:attr' events
* `'change'` does not fire without changes
* nested `'change:attr'` events are fired
* `'change'` is only fired once for nested calls
* nested `'change'` events are fired
2012-02-02 10:49:27 -05:00
Brad Dunbar
ec61503c87 fixes #928 - Save sends correct attrs.
* Temporarily set model's attrs for `sync`.
* Remove cross-module (global) dependencies in
  Collection, Model, and sync test modules.
2012-02-02 08:57:47 -05:00
Brad Dunbar
bc79feaf5a passing falsey keys to hasChanged or previous 2012-02-01 16:06:36 -05:00
Brad Dunbar
c860070ca3 refactor _changed to prevent confusion 2012-02-01 09:13:31 -05:00
Brad Dunbar
9bdaa62224 use $ as DOM abstraction library 2012-01-31 22:49:03 -05:00
James Sanders
e97c58f547 Change name to setDomLibrary 2012-01-31 17:25:41 -07:00
James Sanders
9bd086e64b Change from Backbone.use to Backbone.setjQuery and fix tests 2012-01-31 15:49:53 -07:00
Matt Smith
701350ab90 inject js library with Backbone.use(myLib) 2012-01-31 15:11:13 -07:00
Jeremy Ashkenas
bbee6f17ce Merge pull request #909 from josscrowcroft/master
Return `this` from View.setElement()
2012-01-31 07:30:58 -08:00
Brad Dunbar
7a486392f1 ensure options is present 2012-01-31 10:21:56 -05:00
Brad Dunbar
db95e2c1fb fixes #907 - save with wait succeeds without validate 2012-01-31 10:02:05 -05:00
Joss Crowcroft
4ad12bcd0a Return this from View.setElement 2012-01-31 17:18:16 +08:00
Tomasz Tunik
bb1a7d7792 Fixes issue #904 2012-01-31 01:48:42 +01:00
Jeremy Ashkenas
843eacfcd3 Merge pull request #903 from tomasztunik/master
Removed duplicated variable definitions
2012-01-30 13:35:23 -08:00
Tomasz Tunik
73858ecf31 Removed multiple definitions for already defined variable 2012-01-30 22:27:16 +01:00
Jeremy Ashkenas
5ce976bf6a Backbone.js 0.9.0 2012-01-30 16:24:40 -05:00
Brad Dunbar
8ce8753930 leaked global 2012-01-30 15:52:23 -05:00
Tomasz Tunik
f52ef8c724 Fixed small leak introduced by #901 2012-01-30 21:45:20 +01:00
Brad Dunbar
50e8103fdf check for duplicate models/ids 2012-01-30 15:24:41 -05:00
Brad Dunbar
fb97ef1e86 one more refactor... 2012-01-30 13:57:00 -05:00
Brad Dunbar
ef9d40aa82 factor away else branch 2012-01-30 13:28:34 -05:00
Jeremy Ashkenas
4b4f2c1ad6 missed an API regression in model.changedAttributes(), reimplementing in the same way as the original. 2012-01-30 12:18:58 -05:00
Jeremy Ashkenas
ac580caffa Fixes #892 ... make .route() chainable. 2012-01-30 11:03:16 -05:00
Jeremy Ashkenas
31046e0562 Merge pull request #897 from dcneiner/jquery-zepto-context
Made minor optimization to scoped jQuery/Zepto method $ on the Backbone.View
2012-01-30 06:30:27 -08:00