Commit Graph

296 Commits

Author SHA1 Message Date
Nicklas Ansman Giertz
d852c729df Add a test case for cloning the attribute object
The problem is that the attribute object isn't cloned so when an ID is
set through the constructor attributes[id] will get set on all
subsequent objects as well.
2012-04-02 12:37:25 +02:00
Raúl Naveiras
db4b617697 add ignores comparator when at option is passed 2012-03-26 16:30:26 +02:00
Ben Orenstein
c7034b9735 Let make take other falsy values for content. 2012-03-21 17:21:16 -04:00
Ben Orenstein
69d2c50640 Allow make to take an argument of 0. 2012-03-21 17:07:32 -04:00
Jeremy Ashkenas
f4a1ebc374 fixes #1030 -- save with wait:true with a synchronous Backbone.sync 2012-03-21 11:18:30 -04:00
Jeremy Ashkenas
e9e1abfe61 model.destroy() returns false if the model.isNew() 2012-03-21 10:40:54 -04:00
Jeremy Ashkenas
7b6dbc8dcd Merge pull request #1021 from ahamid/reset_passes_options
small patch to allow passing options through reset to model initializer
2012-03-19 14:00:58 -07:00
Jeremy Ashkenas
de599c169d Fixes #991. Add Collection#where for simple filters 2012-03-19 16:34:53 -04:00
Jeremy Ashkenas
5f41b88764 Merge pull request #1110 from braddunbar/off
Fix #1105 - Add convenience overloads for `off`.
2012-03-19 09:27:17 -07:00
Jeremy Ashkenas
e2e0a0982b Merge pull request #1114 from braddunbar/save-wait-validate
Fix #1057 - Save with wait validates model.
2012-03-19 08:35:12 -07:00
Brad Dunbar
9ffc84c9fe Fix #1112 - options.model sets collection.model. 2012-03-18 22:28:08 -04:00
Brad Dunbar
6948b59e61 Fix #1057 - Save with wait validates model. 2012-03-18 08:59:23 -04:00
Brad Dunbar
fb27097835 Fix #1105 - Add convenience overloads for off. 2012-03-17 09:02:23 -04:00
Jeremy Ashkenas
64f37ce00e fixes #1067, urlRoot vs collection.url() order 2012-03-12 11:22:44 -04:00
Aidan Feldman
f49969014c clean up tests to use fresh object instances for each run, and don't set
globals within test files
2012-03-12 04:27:22 -04:00
Brad Dunbar
6c392fa69a Fix #986 - Undelegate events before changing el. 2012-02-27 15:01:05 -05:00
Jeremy Ashkenas
5ef4921c54 merging async test. 2012-02-27 14:37:50 -05:00
Jeremy Ashkenas
f930b5f042 adding additional router test 2012-02-27 14:37:13 -05:00
Jeremy Ashkenas
83d2918bc7 removing a test that is invalid in IE. 2012-02-27 14:32:30 -05:00
Jeremy Ashkenas
54e284bced Merge branch 'master' of github.com:documentcloud/backbone 2012-02-27 14:30:26 -05:00
Jeremy Ashkenas
07604deac0 merging in hash fixer for FF 2012-02-27 14:30:23 -05:00
Brad Dunbar
f8b37a84b5 Add test for #1048. 2012-02-27 14:23:49 -05:00
Brad Dunbar
111d5a1f19 Add a test for #1052. 2012-02-27 14:16:00 -05:00
Brad Dunbar
69b80f5e3a Fixes #959 - Silent changes fire 'change:attr'.
* Silent changes are tracked so `'change:attr'` can be
  fired next time `change` is called.
* Pending changes are tracked to prevent infinite loops
  and accurately reflect nested changes.
2012-02-17 07:22:43 -05:00
Aaron Hamid
79045c11cb small patch to allow passing options through reset to model initializer 2012-02-17 04:03:30 -05:00
Jeremy Ashkenas
e5db1c93d0 Merge pull request #1011 from wookiehangover/issue996
adding test coverage for route precedence as per issue #996
2012-02-15 09:04:30 -08:00
Sam Breed
8d8a3599a9 adding test coverage for route precedence as per issue #996 2012-02-14 23:18:46 -07:00
Brad Dunbar
232c888038 fixes #1003 - History is started before navigate 2012-02-15 00:39:38 -05:00
Brad Dunbar
8b285c6c83 on is a noop if no callback is provided 2012-02-14 15:22:27 -05:00
brad dunbar
1406ef1c28 Merge pull request #1001 from vertigem/feature/qunit-toolbar
added qunit toolbar
2012-02-14 05:44:24 -08:00
Duke
63188db42b added qunit toolbar 2012-02-13 22:12:15 -02:00
Jeremy Ashkenas
18fba57724 Much asked-for change. Instead of throwing an early error when adding duplicate models, Backbone will simply skip them instead. 2012-02-13 14:39:36 -05:00
Jeremy Ashkenas
2a92f71dcc Merge branch 'master' of github.com:documentcloud/backbone 2012-02-08 16:59:11 -05:00
Jeremy Ashkenas
e3ac6f8eaa Adding Collection#push, pop, shift, and unshift to the API, returning references to the model. Fixing a too-unescaped regex. 2012-02-08 16:58:37 -05:00
Jake Harding
17459a316b Adding test for #967. 2012-02-07 14:17:53 -08:00
Brad Dunbar
522e090831 fixes #964 - collection.get has consistent return 2012-02-06 16:45:06 -05:00
Brad Dunbar
3ef9c3a5fc Add tests for #908, #933. 2012-02-03 10:17:45 -05:00
Brad Dunbar
1d921d690a Add tests for #906. 2012-02-02 20:26:41 -05:00
Brad Dunbar
954da679ed Refactor some tests.
* Use object for lastRequest to prevent errors.
* Ensure setDOMLibrary tests are cleaned up.
2012-02-02 19:36:50 -05:00
Jeremy Ashkenas
a865aa41f1 removing obsolete error case. 2012-02-02 17:15:28 -05:00
Jeremy Ashkenas
0ffd7ea2ca merging in setDomLibrary 2012-02-02 16:30:56 -05:00
Jeremy Ashkenas
eb4753862e #917, adding an Model#isValid() function. 2012-02-02 15:54:34 -05:00
Jeremy Ashkenas
aafbcb05e5 Fixes #917 -- reverts validate() behavior to never run on silent sets. 2012-02-02 15:40:06 -05:00
Brad Dunbar
29a4359ff7 fixes #915 - nested 'change:attr' events
* `'change'` does not fire without changes
* nested `'change:attr'` events are fired
* `'change'` is only fired once for nested calls
* nested `'change'` events are fired
2012-02-02 10:49:27 -05:00
Brad Dunbar
ec61503c87 fixes #928 - Save sends correct attrs.
* Temporarily set model's attrs for `sync`.
* Remove cross-module (global) dependencies in
  Collection, Model, and sync test modules.
2012-02-02 08:57:47 -05:00
Brad Dunbar
bc79feaf5a passing falsey keys to hasChanged or previous 2012-02-01 16:06:36 -05:00
James Sanders
e97c58f547 Change name to setDomLibrary 2012-01-31 17:25:41 -07:00
James Sanders
9bd086e64b Change from Backbone.use to Backbone.setjQuery and fix tests 2012-01-31 15:49:53 -07:00
Matt Smith
701350ab90 inject js library with Backbone.use(myLib) 2012-01-31 15:11:13 -07:00
Brad Dunbar
db95e2c1fb fixes #907 - save with wait succeeds without validate 2012-01-31 10:02:05 -05:00