Commit Graph

786 Commits

Author SHA1 Message Date
Brad Dunbar
efb60cc223 Ensure iframe hash is set. 2014-11-16 10:16:26 -05:00
Brad Dunbar
ea9f5b8c47 Transition with search params. 2014-10-24 11:42:19 -04:00
Brad Dunbar
23599e7472 Update trailing slash for search params. 2014-10-23 18:16:29 -04:00
admangum
dae5424bd5 clone options passed to reset 2014-10-09 12:31:35 -07:00
Adam Krebs
833ab6f327 don't just test for the presence of options, test that it points to the same object as passed in. 2014-10-03 14:03:55 -04:00
Hadrien Milano
cdce75ef76 fix wrong test: collection.model must be a function 2014-10-03 17:59:35 +02:00
Hadrien Milano
e10ab33e73 fix flawed test 2014-10-02 22:15:26 +02:00
Adam Krebs
4927b6e3f0 Merge pull request #3281 from jisaacks/master
Allow Collection.at to accept negative indexes
2014-09-25 12:22:18 -04:00
James Hartig
34e1a1e40c Send correct 'at' when firing 'add' event 2014-09-11 13:04:36 -04:00
JD Isaacks
bcd7549bc9 Set correct number of assertions 2014-09-02 10:33:05 -04:00
JD Isaacks
992fc7b794 Add test for negative indexes in at method 2014-09-02 10:28:48 -04:00
Adam Krebs
ac384b2c1e test for attributes set on the model correctly in patch save 2014-07-23 11:38:36 -04:00
Adam Krebs
2deb84a982 allow Model#save with patch: true to take different attrs. Fixes #3232 2014-07-23 09:47:29 -04:00
Jeremy Ashkenas
8761f25c7d Merge pull request #3133 from caseywebdev/generate-id
Allow Collections to determine uniqueness, not Models
2014-06-27 16:39:20 -04:00
Casey Foster
4e2d20918f Allow Collections to determine uniqueness, not Models 2014-06-21 08:00:13 -05:00
Brad Dunbar
1ed87107cb Add test for urls in params. 2014-06-05 00:35:24 -04:00
Adam Krebs
c33dcdeffd Merge branch 'method-chain' from akre54/method-chain 2014-05-27 14:52:11 -04:00
Adam Krebs
ce6780877f add Model#chain back in. closes gh-3161 2014-05-27 14:51:50 -04:00
Casey Foster
11cc0e863f Revert "Make new tests more thorough"
This reverts commit f814b85db6.

Revert "Return `id` assumption for simple polymorphic `Collection#model` factories."

This reverts commit 3f7fbdeec6.

Conflicts:
	test/collection.js

Revert "#2985 -- use 'change-id' as the event name"

This reverts commit 36e4925b9c.

Revert "Merge pull request #2985 from caseywebdev/generate-id"

This reverts commit 60b9cc1d18, reversing
changes made to 0c1838be63.

Conflicts:
	test/collection.js
2014-04-23 12:02:09 -05:00
Brad Dunbar
5821bc03a3 Decode the fragment before comparing.
Since #getFragment decodes the fragment, #navigate should
match this behavior (using decodeURI, not decodeURIComponent).
2014-04-17 13:10:11 -04:00
Adam Krebs
ccdb757d0d Revert "Added reverse option in the collection sort method"
This reverts commit cea2f3fb86.

Conflicts:
	backbone.js
	test/collection.js
2014-04-15 12:03:12 -04:00
Adam Krebs
edb2a21d13 cleanup reverse tests 2014-04-14 12:20:07 -04:00
Ferran Basora
cea2f3fb86 Added reverse option in the collection sort method
Added the reverse option to be able to sort the collection in the
inverse order specified by the comparator. Useful for one argument
comparators returning string values.

For boolean and integer comparators are easy to find the inverse
function to reverse the collection but for string comparators it's
not as easy as it seems.
2014-04-09 09:45:17 +02:00
Brad Dunbar
a79f7ac830 History#atRoot handles params without path. 2014-03-27 22:43:33 -04:00
Brad Dunbar
623207831e Fix #3078 - Router#execute receives route name. 2014-03-23 17:36:20 -04:00
Adam Krebs
06f19f45af fix tagName test description 2014-03-23 01:59:42 +02:00
Adam Krebs
c10267db3f view test reorg 2014-03-21 01:44:48 +02:00
Nate Hunzaker
a04d7da6e4 DOM element creation should be overrideable
- Add test for _createElement
- Send tag name to _createElement
2014-03-20 19:34:13 -04:00
Tim Griesser
f5dba8edf4 Fixes #3028 assign collection in prepareModel 2014-03-18 17:25:57 -04:00
Jeremy Ashkenas
3994c1cb85 Merge pull request #3003 from akre54/view-native-hooks
View hooks for native and non-jQuery libraries
2014-03-16 19:13:18 -04:00
Brad Dunbar
72f7da4208 A little clarification.
* Rename #_remove as #_removeElement.
* Add #_setAttributes instead of using #setElement.
* Slim down tests a bit.
* #delegate returns this.
2014-03-14 11:56:16 -04:00
Jimmy Yuen Ho Wong
ad39972d5d Return undefined from delegate 2014-03-14 18:04:18 +08:00
Adam Krebs
f67c7a11c3 test delegate returns listener 2014-03-14 06:35:20 +04:00
Adam Krebs
c5c0d2ef0c Merge branch 'master' into view-native-hooks
Conflicts:
	backbone.js
2014-03-14 06:20:59 +04:00
Adam Krebs
291f3bcde4 nicer jq test 2014-03-13 12:59:36 +04:00
Adam Krebs
3850d37def add missing semi 2014-03-12 19:55:08 +04:00
Adam Krebs
d99e43b564 test for undelegate with handler and selector, and use an element that exists in the DOM for bubbling 2014-03-12 15:20:40 +04:00
Adam Krebs
d21fd79d8f remove namespace test from custom events test. 2014-03-12 15:16:33 +04:00
Adam Krebs
be11f3a010 add an undelegate method to View and pass back the listener from delegate 2014-03-12 11:07:33 +04:00
Jimmy Yuen Ho Wong
393a209ca8 Merge _remove and remove tests and remove _setEl tests 2014-03-10 21:18:14 +08:00
Jimmy Yuen Ho Wong
b840669fa7 Rename _removeElement to _remove and test _remove for event undelegation 2014-03-10 21:18:13 +08:00
Brad Dunbar
cbaa8d144b Pass along textStatus and errorThrown. 2014-03-06 17:07:53 -05:00
Adam Krebs
c62708f04b use notEqual body isntead of equal null 2014-03-06 15:26:44 +04:00
Adam Krebs
bef78ef496 test setEl and el.parentNode 2014-03-06 15:22:13 +04:00
Adam Krebs
9eff496762 Revert "View conformance tests"
This reverts commit 7eedd4bc0a.

Conflicts:
	test/view.js
2014-03-06 11:14:16 +04:00
Adam Krebs
6d6999976a test _removeElement 2014-03-06 10:46:41 +04:00
Casey Foster
f814b85db6 Make new tests more thorough 2014-03-05 07:57:39 -06:00
Casey Foster
3f7fbdeec6 Return id assumption for simple polymorphic Collection#model factories.
Also, add tests to make sure it doesn't break in the future.
2014-03-05 07:48:27 -06:00
Jimmy Yuen Ho Wong
1cb19be4e9 Test for view.remove and view._removeElement 2014-03-05 18:31:13 +08:00
Adam Krebs
81809e188f add global Element guard for IE8 2014-03-04 23:07:28 +02:00