From 083cb9cc9ae53687ab9b9f852161dcc79d842e64 Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Sun, 5 May 2013 01:53:42 +0200 Subject: [PATCH] Replace util/osJunk with junk module --- lib/resolve/resolvers/FsResolver.js | 4 ++-- lib/resolve/resolvers/UrlResolver.js | 4 ++-- lib/util/extract.js | 4 ++-- lib/util/osJunk.js | 29 ---------------------------- package.json | 3 ++- 5 files changed, 8 insertions(+), 36 deletions(-) delete mode 100644 lib/util/osJunk.js diff --git a/lib/resolve/resolvers/FsResolver.js b/lib/resolve/resolvers/FsResolver.js index 66281b83..a9ecc876 100644 --- a/lib/resolve/resolvers/FsResolver.js +++ b/lib/resolve/resolvers/FsResolver.js @@ -7,7 +7,7 @@ var Resolver = require('../Resolver'); var copy = require('../../util/copy'); var extract = require('../../util/extract'); var createError = require('../../util/createError'); -var osJunk = require('../../util/osJunk'); +var junk = require('junk'); var FsResolver = function (source, options) { Resolver.call(this, source, options); @@ -89,7 +89,7 @@ FsResolver.prototype._rename = function () { // Remove any OS specific files from the files array // before checking its length - files = files.filter(osJunk.isNotOsJunk); + files = files.filter(junk.isnt); if (files.length === 1) { file = files[0]; diff --git a/lib/resolve/resolvers/UrlResolver.js b/lib/resolve/resolvers/UrlResolver.js index 1e6fbfe0..2b934771 100644 --- a/lib/resolve/resolvers/UrlResolver.js +++ b/lib/resolve/resolvers/UrlResolver.js @@ -7,7 +7,7 @@ var mout = require('mout'); var Resolver = require('../Resolver'); var extract = require('../../util/extract'); var createError = require('../../util/createError'); -var osJunk = require('../../util/osJunk'); +var junk = require('junk'); var UrlResolver = function (source, options) { var pos; @@ -176,7 +176,7 @@ UrlResolver.prototype._rename = function () { // Remove any OS specific files from the files array // before checking its length - files = files.filter(osJunk.isNotOsJunk); + files = files.filter(junk.isnt); if (files.length === 1) { file = files[0]; diff --git a/lib/util/extract.js b/lib/util/extract.js index b53f8345..532ff1b4 100644 --- a/lib/util/extract.js +++ b/lib/util/extract.js @@ -5,7 +5,7 @@ var unzip = require('unzip'); var tar = require('tar'); var Q = require('q'); var mout = require('mout'); -var osJunk = require('./osJunk'); +var junk = require('junk'); // This forces the default chunk size to something small in an attempt // to avoid issue #314 @@ -99,7 +99,7 @@ function isSingleDir(dir) { // Remove any OS specific files from the files array // before checking its length - files = files.filter(osJunk.isNotOsJunk); + files = files.filter(junk.isnt); if (files.length !== 1) { return false; diff --git a/lib/util/osJunk.js b/lib/util/osJunk.js deleted file mode 100644 index 691c6b12..00000000 --- a/lib/util/osJunk.js +++ /dev/null @@ -1,29 +0,0 @@ -var osJunk = [ - // MacOSX - /^__MACOSX$/, - /^\.DS_Store/, - /^\.AppleDouble$/, - /^\.LSOverride$/, - /\.Trashes/, - /^\._.*/, - /^.Spotlight-V100$/, - /^Icon[\r\?]?/, - // Windows - /^ehthumbs\.db$/, - /^Thumbs\.db$/, - /^Desktop.ini$/ -]; - -function isOsJunk(filename) { - return osJunk.some(function (extra) { - return extra.test(filename); - }); -} - -function isNotOsJunk(filename) { - return !isOsJunk(filename); -} - -module.exports.isOsJunk = isOsJunk; -module.exports.isNotOsJunk = isNotOsJunk; -module.exports.osJunk = osJunk; \ No newline at end of file diff --git a/package.json b/package.json index 28cd5197..ae309f6a 100644 --- a/package.json +++ b/package.json @@ -29,7 +29,8 @@ "unzip": "~0.1.7", "tar": "~0.1.17", "fstream": "~0.1.22", - "fstream-ignore": "0.0.6" + "fstream-ignore": "0.0.6", + "junk": "~0.2.0" }, "devDependencies": { "mocha": "~1.8.2",