From 0c7e593370fee7ac4e2267926bc9b1548e7e8d1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andre=CC=81=20Cruz?= Date: Wed, 1 May 2013 15:34:15 +0100 Subject: [PATCH] Fix bug in the hasNew of the GitResolver. --- lib/resolve/resolvers/GitResolver.js | 4 ++-- test/resolve/resolvers/gitResolver.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/resolve/resolvers/GitResolver.js b/lib/resolve/resolvers/GitResolver.js index 84c6efab..e5cbf5c1 100644 --- a/lib/resolve/resolvers/GitResolver.js +++ b/lib/resolve/resolvers/GitResolver.js @@ -27,8 +27,8 @@ GitResolver.prototype._hasNew = function (pkgMeta) { return true; } - // If resolved to a tag, there is new content if the tags are not equal - if (resolution.type === 'tag' && semver.neq(resolution.tag, oldResolution.tag)) { + // If resolved to a version, there is new content if the tags are not equal + if (resolution.type === 'version' && semver.neq(resolution.tag, oldResolution.tag)) { return true; } diff --git a/test/resolve/resolvers/gitResolver.js b/test/resolve/resolvers/gitResolver.js index f6258bef..378062f3 100644 --- a/test/resolve/resolvers/gitResolver.js +++ b/test/resolve/resolvers/gitResolver.js @@ -42,7 +42,7 @@ describe('GitResolver', function () { })); GitResolver.fetchRefs = function () { return Q.resolve([ - 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa refs/heads/master' + 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb refs/heads/master' // same commit hash on purpose ]); }; @@ -71,7 +71,7 @@ describe('GitResolver', function () { return Q.resolve([ 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa refs/heads/master', 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb refs/tags/1.0.0', - 'cccccccccccccccccccccccccccccccccccccccc refs/tags/1.0.1' + 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb refs/tags/1.0.1' // same commit hash on purpose ]); };