From 8abd010d08ff6f786d76549b4c3c45b6088b7446 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andre=CC=81=20Cruz?= Date: Sun, 14 Apr 2013 18:15:09 +0100 Subject: [PATCH] Fix bug when targeting branches. --- lib/resolve/resolvers/GitResolver.js | 7 +++---- test/test.js | 3 +-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/resolve/resolvers/GitResolver.js b/lib/resolve/resolvers/GitResolver.js index 5ad0bf83..aa3e490a 100644 --- a/lib/resolve/resolvers/GitResolver.js +++ b/lib/resolve/resolvers/GitResolver.js @@ -53,7 +53,6 @@ GitResolver.fetchRefs = function (source) {}; GitResolver.prototype._findResolution = function () { var branches, - target, self = this.constructor; // Target is a range/version @@ -86,16 +85,16 @@ GitResolver.prototype._findResolution = function () { // Otherwise, assume target is a branch return self.fetchHeads(this._sourcePath) .then(function (heads) { - if (!heads[target]) { + if (!heads[this._target]) { branches = Object.keys(heads); - throw createError('Branch "' + target + '" does not exist', 'ENORESTARGET', { + throw createError('Branch "' + this._target + '" does not exist', 'ENORESTARGET', { details: !branches.length ? 'No branches found in "' + this._source + '"' : 'Available branches in "' + this._source + '" are: ' + branches.join(', ') }); } - return { type: 'branch', branch: target, commit: heads[target] }; + return { type: 'branch', branch: this._target, commit: heads[this._target] }; }.bind(this)); }; diff --git a/test/test.js b/test/test.js index c617d5b8..0abc2f46 100644 --- a/test/test.js +++ b/test/test.js @@ -20,8 +20,7 @@ function testGitRemoteResolver() { function testGitLocalResolver() { var bowerResolver = new GitFsResolver('.', { name: 'bower', - //target: 'rewrite', - target: '0.8.4' + target: 'rewrite' }); return bowerResolver.resolve()