From f33bac5b5957512605c7bc1744754bc19d15de8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andre=CC=81=20Cruz?= Date: Sun, 14 Apr 2013 17:25:36 +0100 Subject: [PATCH] Add missing hasNew. --- lib/resolve/Resolver.js | 4 ++++ lib/resolve/resolvers/FsResolver.js | 7 +++++++ lib/resolve/resolvers/UrlResolver.js | 7 +++++++ 3 files changed, 18 insertions(+) diff --git a/lib/resolve/Resolver.js b/lib/resolve/Resolver.js index efa590c2..8591c428 100644 --- a/lib/resolve/Resolver.js +++ b/lib/resolve/Resolver.js @@ -45,6 +45,10 @@ Resolver.prototype.resolve = function () { .then(this._parseJson.bind(this)); }; +Resolver.prototype.hasNew = function (oldResolution) { + return Q.resolve(true); +}; + Resolver.prototype.isCacheable = function () { return false; }; diff --git a/lib/resolve/resolvers/FsResolver.js b/lib/resolve/resolvers/FsResolver.js index 1907b768..2f11201b 100644 --- a/lib/resolve/resolvers/FsResolver.js +++ b/lib/resolve/resolvers/FsResolver.js @@ -10,11 +10,18 @@ util.inherits(FsResolver, Resolver); // ----------------- +FsResolver.prototype.hasNew = function (oldResolution) { + // TODO: should we store latest modified files in the resolution and compare? + return Q.resolve(true); +}; + FsResolver.prototype._resolveSelf = function () { return this._copy() .then(this._extract.bind(this)); }; +// ----------------- + FsResolver.prototype._copy = function () { }; diff --git a/lib/resolve/resolvers/UrlResolver.js b/lib/resolve/resolvers/UrlResolver.js index edfcc94d..c3529da7 100644 --- a/lib/resolve/resolvers/UrlResolver.js +++ b/lib/resolve/resolvers/UrlResolver.js @@ -10,11 +10,18 @@ util.inherits(UrlResolver, Resolver); // ----------------- +UrlResolver.prototype.hasNew = function (oldResolution) { + // Store cache expiration headers in the resolution and compare them afterwards + Q.resolve(true); +}; + UrlResolver.prototype._resolveSelf = function () { return this._download() .then(this._extract.bind(this)); }; +// ----------------- + UrlResolver.prototype._download = function () { };