Enable more rubocop cops (#9980)

* Remove self.check in python3.rb as tests were not actuallly being run

* Enable Lint/ImplicitStringConcatenation cop

* Enable Layout/CommentIndentation cop

* Remove unnecessary configuration of Layout/IndentationStyle to EnforcedStyle: spaces, as this is already the default

* Enable Layout/LeadingCommentSpace cop

* Enable Layout/SpaceInsideBlockBraces cop

* Enable Layout/SpaceInsideParens cop

* Enable Layout/TrailingEmptyLines cop

* Enable Lint/LiteralAsCondition cop

* Document the current issue stopping us from enabling Style/OptionalBooleanParameter

* Stop downloading our rubocop config when installing ruby_rubocop

.rubocop.yml

@@ -20,9 +20,6 @@ AllCops:
 Security/Eval:
   Enabled: false
 
-Lint/ImplicitStringConcatenation:
-  Enabled: false
-
 Lint/ShadowingOuterLocalVariable:
   Enabled: false
 
@@ -39,9 +36,6 @@ Layout/HashAlignment:
 
 # End temporarily disabled cops
 
-Layout/CommentIndentation:
-  Enabled: false
-
 Layout/EmptyLineAfterGuardClause:
   Enabled: false
 
@@ -49,27 +43,9 @@ Layout/FirstHashElementIndentation:
   Enabled: false
 # EnforcedStyle: consistent
 
-Layout/IndentationStyle:
-  EnforcedStyle: spaces
-
-Layout/LeadingCommentSpace:
-  Enabled: false
-
 Layout/LineLength:
   Enabled: false
 
-Layout/SpaceInsideBlockBraces:
-  Enabled: false
-
-Layout/SpaceInsideParens:
-  Enabled: false
-
-Layout/TrailingEmptyLines:
-  Enabled: false
-
-Lint/LiteralAsCondition:
-  Enabled: false
-
 Style/RedundantReturn:
   Enabled: false
 
@@ -88,6 +64,7 @@ Style/GuardClause:
 Style/DocumentDynamicEvalDefinition:
   Enabled: false
 
+# https://github.com/rubocop/rubocop/issues/12132
 Style/OptionalBooleanParameter:
   Enabled: false