Confirm upload to GitLab with sha256sum check during crew upload (#9355)

Don't offer to install dependencies for incompatible package builds

Change logic for error conditions

Add verbose messages to downloader
This commit is contained in:
Ed Reel
2024-02-18 17:53:10 -06:00
committed by GitHub
parent 113b169a08
commit 3703dd55cb
3 changed files with 39 additions and 17 deletions

View File

@@ -28,15 +28,18 @@ def downloader(url, sha256sum, filename = File.basename(url), verbose = false)
# <filename>: (Optional) Output path/filename
# <verbose>: (Optional) Verbose output
#
puts "downloader(#{url}, #{sha256sum}, #{filename}, #{verbose})" if verbose
uri = URI(url)
if CREW_USE_CURL || !ENV['CREW_DOWNLOADER'].to_s.empty?
# force using external downloader if either CREW_USE_CURL or ENV['CREW_DOWNLOADER'] is set
puts "external_downloader(#{uri}, #{filename}, #{verbose})" if verbose
external_downloader(uri, filename, verbose)
else
case uri.scheme
when 'http', 'https'
# use net/http if the url protocol is http(s)://
puts "http_downloader(#{uri}, #{filename}, #{verbose})" if verbose
http_downloader(uri, filename, verbose)
when 'file'
# use FileUtils to copy if it is a local file (the url protocol is file://)
@@ -47,6 +50,7 @@ def downloader(url, sha256sum, filename = File.basename(url), verbose = false)
end
else
# use external downloader (curl by default) if the url protocol is not http(s):// or file://
puts "external_downloader(#{uri}, #{filename}, #{verbose})" if verbose
external_downloader(uri, filename, verbose)
end
end
@@ -70,6 +74,7 @@ rescue StandardError => e
warn e.full_message
# fallback to curl if error occurred
puts "external_downloader(#{uri}, #{filename}, #{verbose})" if verbose
external_downloader(uri, filename, verbose)
end