Adjust ruby buildsystem to use Gem::Version.new to sanitize gem version numbers, adjust activesupport package dependencies. (#10624)

* Adjust ruby buildsystem to use Gem::Version.new to sanitize gem version numbers, adjust activesupport package dependencies.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Have linting workflows fail on warning.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Lint now that we know the checks fail appropriately when they are tripped.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

.github/workflows/Markdown-lint.yml

@@ -4,11 +4,15 @@ on: workflow_call
 jobs:
   markdown-lint:
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: write
     steps:
       - uses: actions/checkout@v4
       - name: Markdown-lint
         uses: reviewdog/action-markdownlint@v0
         with:
-          reporter: github-pr-review
           fail_on_error: true
           markdownlint_flags: '-s .mdl_style.rb'
+          reporter: github-pr-check
+          reviewdog_flags: '-fail-level=any'

.github/workflows/Rubocop.yml

@@ -1,12 +1,12 @@
 ---
 name: Rubocop
 on: workflow_call
-permissions:
-  contents: read
-  pull-requests: write
 jobs:
   rubocop:
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: write
     steps:
       - uses: actions/checkout@v4
       - uses: ruby/setup-ruby@v1
@@ -15,6 +15,8 @@ jobs:
       - name: Rubocop
         uses: reviewdog/action-rubocop@v2
         with:
-          reporter: github-pr-review
           fail_on_error: true
           filter_mode: nofilter
+          only_changed: true
+          reporter: github-pr-check
+          reviewdog_flags: '-fail-level=any'

.github/workflows/ShellCheck.yml

@@ -4,11 +4,15 @@ on: workflow_call
 jobs:
   shellcheck:
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: write
     steps:
       - uses: actions/checkout@v4
       - name: ShellCheck
         uses: reviewdog/action-shellcheck@v1
         with:
-          reporter: github-pr-review
-          fail_on_error: true
           exclude: './tools/*'
+          fail_on_error: true
+          reporter: github-pr-check
+          reviewdog_flags: '-fail-level=any'

.github/workflows/YAMLlint.yml

@@ -4,10 +4,14 @@ on: workflow_call
 jobs:
   yamllint:
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      pull-requests: write
     steps:
       - uses: actions/checkout@v4
       - name: YAMLLint
         uses: reviewdog/action-yamllint@v1
         with:
-          reporter: github-pr-review
           fail_on_error: true
+          reporter: github-pr-check
+          reviewdog_flags: '-fail-level=any'