github/chromebrew
1
1
Fork 0
mirror of https://github.com/chromebrew/chromebrew.git synced 2026-01-09 23:48:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix Ruby Gem Upgrades and detect missing rubocop. (#11474)

Browse Source 
Fixes: #11473

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
This commit is contained in:
Satadru Pramanik, DO, MPH, MEng
2025-03-05 13:08:24 -05:00
committed by GitHub
parent ece9c8a2a0
commit a1aab44dbf
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
commands/check.rb
View File

@@ -16,12 +16,12 @@ class Command
end
# Use rubocop to sanitize package file, and let errors get flagged.
if PackageUtils.installed?('ruby_rubocop')
if Kernel.system('rubocop --version', %i[out err] => File::NULL)
puts "Using rubocop to sanitize #{local_package}".orange
system "rubocop -c #{File.join(CREW_LOCAL_REPO_ROOT, '.rubocop.yml')} -A #{local_package}", exception: true
else
puts "Rubocop is not installed, and thus will not be used to sanitize #{local_package}".lightred
puts 'To install Rubocop, run the following command: '.lightred + 'crew install ruby_rubocop'.lightblue
puts 'To install Rubocop, run the following command: '.lightred + "crew #{PackageUtils.installed?('ruby_rubocop') ? 're' : ''}install ruby_rubocop".lightblue
end
to_copy = force

8
lib/buildsystems/ruby.rb
View File

@@ -111,6 +111,8 @@ class RUBY < Package
end
def self.install
# @install_gem will always be true during upgrades since we remove
# the old gem during the upgrade.
unless @install_gem
puts "#{@gem_name} #{@gem_installed_version} is properly installed.".lightgreen
return
@@ -122,6 +124,12 @@ class RUBY < Package
@gem_outdated = (Gem::Version.new(@gem_version) > Gem::Version.new(@gem_installed_version))
@gem_latest_version_installed = Gem::Version.new(@gem_version) <= Gem::Version.new(@gem_installed_version)
crewlog "@gem_version: #{@gem_version} @gem_installed_version: #{@gem_installed_version} @gem_outdated: #{@gem_outdated} @gem_latest_version_installed: #{@gem_latest_version_installed}"
else
# If the current gem being installed is not installed this should
# be false. This will also handle cases of the current installed
# gem as per 'gem list' being the same version as the version
# being upgraded to.
@gem_latest_version_installed = false
end
crewlog "no_compile_needed?: #{no_compile_needed?} @gem_binary_build_needed.blank?: #{@gem_binary_build_needed.blank?}, gem_compile_needed?: #{gem_compile_needed?}"