Properly separate ConvenienceFunctions out of PackageUtils and move additional functions into MiscFunctions, and document the various roles of each class (#10343)

This commit is contained in:
Maximilian Downey Twiss
2024-08-27 02:08:45 +10:00
committed by GitHub
parent e84b0cca05
commit ecf7885ebc
13 changed files with 128 additions and 116 deletions

View File

@@ -1,6 +1,6 @@
require 'minitest/autorun'
require_relative '../../commands/list'
require_relative '../../lib/package_utils'
require_relative '../../lib/convenience_functions'
# Add lib to LOAD_PATH
$LOAD_PATH << File.join(CREW_LIB_PATH, 'lib')
@@ -9,7 +9,7 @@ String.use_color = false
class ListCommandTest < Minitest::Test
def setup
@essential_deps = PackageUtils.load_json[:essential_deps].join("\n") + "\n".to_s
@essential_deps = ConvenienceFunctions.load_symbolized_json[:essential_deps].join("\n") + "\n".to_s
end
def test_list_essential_deps

View File

@@ -1,6 +1,7 @@
require 'minitest/autorun'
require_relative '../../commands/remove'
require_relative '../../lib/const'
require_relative '../../lib/convenience_functions'
require_relative '../../lib/package_utils'
# Add lib to LOAD_PATH
@@ -11,7 +12,7 @@ String.use_color = false
class RemoveCommandTest < Minitest::Test
def setup
essential_deps = PackageUtils.load_json[:essential_deps]
essential_deps = ConvenienceFunctions.load_symbolized_json[:essential_deps]
@random_essential_package_name = essential_deps[rand(0...(essential_deps.length - 1))]
puts <<~ESSENTIAL_PACKAGE_REMOVAL_TEST_EOF