Enable additional temporarily disabled cops (#9394)

.rubocop.yml

@@ -20,101 +20,15 @@ AllCops:
 Security/Eval:
   Enabled: false
 
-Naming/ClassAndModuleCamelCase:
-  # Disable this cop for every file in packages/
-  Enabled: false
-
-Naming/MethodParameterName:
-  Enabled: false
-
-Naming/MethodName:
-  Enabled: false
-
-Naming/VariableName:
-  Enabled: false
-
-Naming/PredicateName:
-  Enabled: false
-
-Metrics/AbcSize:
-  Enabled: false
-
-Metrics/MethodLength:
-  Enabled: false
-
-Metrics/ModuleLength:
-  Enabled: false
-
-Metrics/BlockLength:
-  Enabled: false
-
-Metrics/ClassLength:
-  Enabled: false
-
-Metrics/CyclomaticComplexity:
-  Enabled: false
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-Metrics/BlockNesting:
-  Enabled: false
-
-Metrics/ParameterLists:
-  Enabled: false
-
-Layout/LineContinuationLeadingSpace:
-  Enabled: false
-
-Lint/ConstantDefinitionInBlock:
-  Enabled: false
-
-Lint/EmptyBlock:
-  Enabled: false
-
 Lint/ImplicitStringConcatenation:
   Enabled: false
 
-Lint/UnreachableCode:
-  Enabled: false
-
-Lint/DuplicateBranch:
-  Enabled: false
-
-Lint/AssignmentInCondition:
-  Enabled: false
-
-Lint/LiteralAsCondition:
-  Enabled: false
-
-Lint/UnderscorePrefixedVariableName:
-  Enabled: false
-
-Lint/EmptyWhen:
-  Enabled: false
-
-Lint/UselessAssignment:
-  Enabled: false
-
-Lint/MissingSuper:
-  Enabled: false
-
 Lint/ShadowingOuterLocalVariable:
   Enabled: false
 
 Lint/SuppressedException:
   Enabled: false
 
-Lint/RedundantSafeNavigation:
-  Enabled: false
-
-Layout/LineLength:
-  AllowedPatterns:
-    - '#'
-    - 'description'
-  # When this is reenabled, keep the AllowedPatterns configuration
-  Enabled: false
-
 Layout/HashAlignment:
   EnforcedHashRocketStyle:
     - separator
@@ -141,6 +55,9 @@ Layout/IndentationStyle:
 Layout/LeadingCommentSpace:
   Enabled: false
 
+Layout/LineLength:
+  Enabled: false
+
 Layout/SpaceInsideBlockBraces:
   Enabled: false
 
@@ -150,6 +67,9 @@ Layout/SpaceInsideParens:
 Layout/TrailingEmptyLines:
   Enabled: false
 
+Lint/LiteralAsCondition:
+  Enabled: false
+
 Style/RedundantReturn:
   Enabled: false
 
@@ -195,12 +115,25 @@ Style/RedundantLineContinuation:
 Style/RedundantStringEscape:
   Enabled: false
 
+Metrics:
+  Enabled: false
+
 Naming/AccessorMethodName:
   Enabled: false
 
 Naming/BlockParameterName:
   Enabled: false
 
+Naming/ClassAndModuleCamelCase:
+  Exclude:
+    - 'packages/*'
+
+Naming/VariableName:
+  EnforcedStyle: snake_case
+  # Allow variable names which are in all caps (with optional numbers and underscores)
+  AllowedPatterns:
+    - '^@?[A-Z0-9_]+$'
+
 Naming/VariableNumber:
   Enabled: false