4 Commits

Author SHA1 Message Date
Maximilian Downey Twiss
0c86288d24 Clean up rubocop configuration pt.1 (#11566) 2025-03-17 22:42:05 +00:00
Maximilian Downey Twiss
33901368d7 Enable more rubocop cops (#9980)
* Remove self.check in python3.rb as tests were not actuallly being run

* Enable Lint/ImplicitStringConcatenation cop

* Enable Layout/CommentIndentation cop

* Remove unnecessary configuration of Layout/IndentationStyle to EnforcedStyle: spaces, as this is already the default

* Enable Layout/LeadingCommentSpace cop

* Enable Layout/SpaceInsideBlockBraces cop

* Enable Layout/SpaceInsideParens cop

* Enable Layout/TrailingEmptyLines cop

* Enable Lint/LiteralAsCondition cop

* Document the current issue stopping us from enabling Style/OptionalBooleanParameter

* Stop downloading our rubocop config when installing ruby_rubocop
2024-06-17 16:19:11 -04:00
Satadru Pramanik, DO, MPH, MEng
43c334de5f Autosource ~/.bashrc (#9649)
* Autosource ~/.bashrc

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add exitmessage...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Use env variable to gate USR1

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add logging

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust logging, add more documentation

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* move env sourced variable in const.rb

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update flag variable to be CREW_SOURCE_BASHRC_ACTIVATED

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Remove need for CREW_SOURCE_BASHRC_ACTIVATED env variable

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix logic for trap detection

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* revert to using env variable as flag for bash trap enablement

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add reversion to env based crew_profile_base trap detection

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* move SOURCE_BASHRC code block

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* use fd instead of env variable, check for interactive terminal in selector

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix fd check

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add exit to shell for installer so that bashrc does not have to be sourced manually after install is run.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* do not use @pkg unless defined

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Do not tread on #9654

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup selector and progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* remove debug code from progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* refactor to use changed bash process name

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust comment

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* disable more debug code

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix comparison

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix unit test

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add some debugging to selector

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* move crewlog to separate file

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* use global verbose

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust timeout to 1 for selector

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* "workaround" using a global variable

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix CREW_VERBOSE

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Use CREW_VERBOSE

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* switch all @opt_verbose to CREW_VERBOSE

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* try to work around missing constant on update

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add print_source_bashrc to ccache

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* uncommented crewlog lines in crew

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* remove debug crewlog lines

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-04-15 21:28:42 -05:00
supechicken
4f840557db lib/selector: Add selector library, apply to jdk and hunspell (#7473)
* Add selector library, apply to `jdk` and `hunspell`

* Make rubocop happy

* Fix syntax error

* jdk: Fetch version from packages

* Auto update version number

* hunspell: wrap with `ARGV.include?`

* Fix syntax error

* Make rubocop happy

* jdk: use `Dir[]`

* Generate options dynamically
2022-10-16 00:32:23 -05:00