6 Commits

Author SHA1 Message Date
Maximilian Downey Twiss
33901368d7 Enable more rubocop cops (#9980)
* Remove self.check in python3.rb as tests were not actuallly being run

* Enable Lint/ImplicitStringConcatenation cop

* Enable Layout/CommentIndentation cop

* Remove unnecessary configuration of Layout/IndentationStyle to EnforcedStyle: spaces, as this is already the default

* Enable Layout/LeadingCommentSpace cop

* Enable Layout/SpaceInsideBlockBraces cop

* Enable Layout/SpaceInsideParens cop

* Enable Layout/TrailingEmptyLines cop

* Enable Lint/LiteralAsCondition cop

* Document the current issue stopping us from enabling Style/OptionalBooleanParameter

* Stop downloading our rubocop config when installing ruby_rubocop
2024-06-17 16:19:11 -04:00
Maximilian Downey Twiss
b8bed724e5 Remove basic miscellaneous uses of @_ver (#8429) 2023-06-22 10:47:09 -04:00
supechicken
35907d56f5 jdk*: Make prompt more clearly + add openjdk detection (#7498)
* jdk8 => 8u341

* Redirect to stdout

* Add newline

* Update message

* Fix variable name

* Update jdk8.rb

* Remove archive after installed

* jdk11 => 11.0.16.1

* Update all available oracle jdk versions

* Fix url  type

* Fix version detection

* Make rubocop happy

* Fix openjdk detection

* Use `@_ver` on jdk*, fix rubocop
2022-10-15 23:31:15 -05:00
Maximilian Downey Twiss
de24923ee8 Add Rubocop CI (#7083)
* Rename IgnoredPatterns to AllowedPatterns.

* Exclude docopt.rb (not our code) from Rubocop

* Disable Style/RedundantReturn

* Disable Style/MutableConstant

* Disable Style/NumericLiterals

* Set Layout/IndentationStyle to spaces

* Temporarily disable various cops.

* Add Rubocop CI via Octocop

* Lint tree with rubocop -A -c .rubocop.yml

Co-authored-by: Satadru Pramanik <satadru@gmail.com>
2022-08-22 13:31:25 -04:00
Ed Reel
94076352b7 Update jdk packages (#7095)
* Revert d3038e0805

* Update jdk packages 8u333-18.0.1.1

Remove jdk15 and jdk16 (no longer available)
2022-05-30 11:27:13 -04:00
Ed Reel
c6625ef080 Update jdk packages 8u321-17.0.2 => 8u331-18.0.1 (#7009) 2022-04-25 15:15:27 -04:00