Commit Graph

58 Commits

Author SHA1 Message Date
Maximilian Downey Twiss
20bb5f0340 Refactor tests/commands/remove.rb (#11365) 2025-02-19 08:23:13 +00:00
Maximilian Downey Twiss
b0491e9cde Remove need for essential_deps field in device.json (#10394) 2025-02-08 00:14:55 +00:00
Maximilian Downey Twiss
a4bd2f417a Enable rubocop-chromebrew extension (#10000) 2025-02-03 12:07:38 +00:00
github-actions[bot]
dce18d8dd9 Ruby => 3.4.1 (#11066)
* Ruby => 3.4.0, and remove old kernel workarounds.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add built packages for linux/386 to ruby

* Add built packages for linux/amd64 to ruby

* Add built packages for linux/arm/v7 to ruby

* dep adjustment for Ruby 3.4

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add gem adjustment for ruby 3.4.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update ruby gems deps.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust ruby_resolv_replace requirements.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update rubygems package name.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add repl_type_completor package.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update ruby => 3.4.1

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust build to prevent breakage.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust build workflow script.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add workaround for broken rubocop from ruby upgrade.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Handle case of gem compiler not being installed.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add built packages for linux/386 to ruby

* Add built packages for linux/amd64 to ruby

* Add built packages for linux/arm/v7 to ruby

* Update lib/downloader.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update packages/ruby_repl_type_completor.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update tools/build_updated_packages.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update packages/ruby_repl_type_completor.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update tools/build_updated_packages.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add broken rake invocation workaround.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update Rubygems.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update gems and fix gem updater to account for rubygems.org/versions appending updates during the month to the bottom of the file.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Sync up logic in buildsystems/ruby.rb and tools/update_ruby_gem_packages.rb

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
Co-authored-by: Satadru Pramanik <satadru@gmail.com>
Co-authored-by: satmandu <satmandu@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-12-31 19:00:07 +00:00
Satadru Pramanik
eed71f031e Use M130 containers for unit tests, and use unit_test_stub.sh to invoke unit tests.
Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-11-07 19:22:21 +00:00
Satadru Pramanik
b7843ab3e3 Use last modification time for unit_test_stub.sh age reporting.
Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-11-06 19:07:48 +00:00
Satadru Pramanik
3159f9affa Add more verbiage.
Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-11-06 18:49:06 +00:00
Satadru Pramanik
8a9ef0b194 Add unit test stub for storage inside container images.
Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-11-06 18:49:06 +00:00
Maximilian Downey Twiss
3106ff0a2c Add test for removed dependencies (#10464)
* Add test for removed dependencies

* Fix the reported issues
2024-09-12 22:00:32 -05:00
Maximilian Downey Twiss
26e6c168bb Refactor prop_test and buildsystem_test to not rely on instance variables, and do not use grep in buildsystem_test (significant performance boost from doing so) (#10461) 2024-09-12 15:51:31 -05:00
Maximilian Downey Twiss
2fcf2cb590 Revert "Revert #10453 (#10456)" (#10460)
This reverts commit 679c419673.
2024-09-11 16:21:26 -05:00
Ed Reel
679c419673 Revert #10453 (#10456) 2024-09-11 13:33:24 -04:00
Maximilian Downey Twiss
7325468db2 More python cleanups (#10452)
* Add unit tests for conflicting package properties

* Fix the reported issues
2024-09-11 10:36:58 -04:00
Maximilian Downey Twiss
1fc45a2322 Add Rakefile to replace crew test and simplify unit testing. (#10453) 2024-09-11 09:28:59 -04:00
Maximilian Downey Twiss
a532c3fc47 Reland: Download the correct file when there are multiple versions of a package binary (#10336) 2024-09-03 01:23:40 -05:00
Satadru Pramanik, DO, MPH, MEng
34e6887026 Fix regex in crew whatprovides. (#10387)
* Fix regex in crew whatprovides.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add regex test.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-08-31 17:01:55 -05:00
Satadru Pramanik, DO, MPH, MEng
68f183bdfb Whatprovides unittest (#10385)
* Fix whatprovides: handle case of manifest filelist not corresponding to a package file.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add unit test for whatprovides.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Bump version

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Remove arm manifest for deprecated imagemagick6 package.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-08-31 16:30:39 -05:00
Satadru Pramanik, DO, MPH, MEng
386f42ff6e Fix for require issues with highline and glibc 2.37 refactor (#10363)
* Adjust highline requires.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Refactor glibc_build237.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust cmake logic for cmake_build_relative_dir.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update buildsystems...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Rebuild glibc 2.37 packages.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust fixup for case of loading from much older crew.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Try to handle loading fixup on older crew update.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Handle older crew setups.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Use rubocop exclusion for only const.rb and fixup.rb.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Remove attr_accessor from buildsystems.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Force update compatible if coming from an older crew.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* remove require_gem from package.rb

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add fallback for remove.rb

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* const tweaks...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust const.rb & fixup.rb to remove error messages on load after require.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Make remove run crew update compatible if being run on a newer underlying chromebrew.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* lint

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust fixup to be more resilient to being loaded in an older crew.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Switch from symbolized json import.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Revert most changes.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust essential deps handling in fixup.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Cleanup save_json in fixup.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update highline

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* save json more.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* save json more.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* test remove changes

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add more remove debug code.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add more remove debug code.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add debug to fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add debug to fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add debug to fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Refresh crew json when calling crew functions or exiting fixup.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Refresh crew json when calling crew functions or exiting fixup.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix json string usage in remove

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* essential package debugging

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust remove debugging...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more remove debugging

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Remove debugging code from commands/remove.rb

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Remove more debugging code from lib/fixup.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust remove test to test both remove with and without debug argument.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update const.rb to not set x86 constants when not on x86.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Set x86 constants to nil when not on x86.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Bump crew version.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-08-31 14:06:18 -05:00
Maximilian Downey Twiss
ecf7885ebc Properly separate ConvenienceFunctions out of PackageUtils and move additional functions into MiscFunctions, and document the various roles of each class (#10343) 2024-08-26 12:08:45 -04:00
Maximilian Downey Twiss
5abbff1218 Refactor unit tests (#10340) 2024-08-23 09:25:41 -04:00
Satadru Pramanik, DO, MPH, MEng
9f18d1f48a Fix remove such that files from essential packages are not removed. (#10342)
* Fix remove such that essential files are not removed.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* bump version

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* lint

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-08-23 16:29:18 +10:00
Satadru Pramanik, DO, MPH, MEng
66ca77930b Add libc version and chromeos milestone to container bash prompts (#10335)
* Use agree_to_remove in ruby_pry.rb.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add cmake options for build_relative_dir

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust cmake buildsystems.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Alphabetize properties in buildsystems/python.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add updated crew_profile_base.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add missing filelists, add glibc fallback to gcc packages.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add milestone to container git prompt.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Use more heredocs for the git commands.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust git postinstall.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add binaries.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust unit test to do build test right after crew upgrade.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* lint

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Suggested changes.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-08-22 21:26:03 -05:00
Satadru Pramanik, DO, MPH, MEng
f2c6237d49 Cleanup glibc packages, rebuild glibc 2.32, fix broken git repo clone in installs, rebuild OpenSSL to fix pkgconfig breakage in 3.3.1 (#10328)
* Cleanup glibc packages, rebuild glibc 2.32.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fixup adjustments to allow it to run standalone.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust const.rb to ignore git errors.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Make initial branch error go away like in install.sh.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Make fix of chromebrew git checkout appropriately verbose.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust for reinstalling installed packages during testing.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust unit test messages.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fix typo.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Rebuild OpenSSL to use ARCH_LIB for --libdir to fix pkgconfig libdir regression in OpenSSL 3.3.1.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* More glibc compaction, remove executable bit from lib/fixup.rb.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Removeruby shebang from fixup.rb.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Suggested changes to glibc version comparisons.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Move git commands to heredoc.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Use Gem::Version.new in glibc packages.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Move most other git commands to heredoc.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add more fixup commenting.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix typo...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-08-21 14:36:15 -05:00
Satadru Pramanik, DO, MPH, MEng
d10bc9f6e6 Fixes #9524, adjusts compatibility for glibc packages and adds file lists for glibc_build232, and adds max_glibc property (#10319)
* Fixes #9524, adjusts compatibility for glibc packages and adds filelists for glibc_build232

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust logic to add max_glibc.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update packages.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust reason reporting logic.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Temporarily adjust unit test to avoid neweer armv7l container.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Modify unit test...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust unit test...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust unit test...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust unit test...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust unit test...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust unit test...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fix indentation.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* lint

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-08-18 21:24:10 -05:00
Satadru Pramanik, DO, MPH, MEng
c6b102fece Use grep better to speed up crew remove of packages. (#10309)
* use grep to speed up crew remove

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* bump version

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust logic

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add back CREW_ESSENTIAL_FILES to handle files like libC.so.6

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust CREW_ESSENTIAL_FILES logic

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix package_files_that_overlap

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* cleanup output of package_files_that_overlap

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* debug

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Back out CREW_ESSENTIAL_FILES change, and use Package.load_package('pkg.rb').get_deps_list to find dependent packages of CREW_ESSENTIAL_PACKAGES in commands/remove.rb, and also fix Package.load_package('pkg.rb').get_deps_list to enable using it from commands/remove.rb

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust removal message in crew.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust some punctuation and capitalization.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix pkg_file path detection

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Only use CREW_LOCAL_REPO_ROOT file if it exists.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* suggested changes

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fix ESSENTIAL_PACKAGE dependency expansion.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fix essential_deps logic.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust remove logic to return quietly if in_upgrade, else exit 1, and also properly figure out essential_packages list.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fix docopt so options like '-d' work.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add suggested changes for testing, add testing file for remove.rb, also in testing.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more testing

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Move recursive package function to package.rb

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust function name.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* simplify

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* simplify

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Use File.mtime for @last_update_check as per suggestion by @Zopolis4.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Move essential package determination to crew:generate_compatible.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Move load_json and save_json to package_utils and just use symbols for the json array in remove and package_utils.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Unify json usage globally.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fix one remove test.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* lint

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update remove.rb test.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* cleanup

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust remove test.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Try to use new Unit Tests...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fix installsh: git config --local commands cannot be run unless the git repo is already setup.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Move json functions to package_utils.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fix docopt for real, add docopt unit test, have install.sh generate ruby gem filelists just like a regular buildsystems/ruby gem install.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Use CREW_META_PATH in install.sh.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Cleanup remove.rb tests.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add 'crew list essential'.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add unit test for list command.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Cleanup remove.rb test.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Cleanup wording.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Move print_deps_tree to lib/package.rb.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* lint

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Return changes from #10317

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-08-17 14:09:09 -05:00
Satadru Pramanik, DO, MPH, MEng
2f745cc5f0 Update gtk4, libdrm, mesa, test buildsystems changes, make unit tests easier to debug (#10311)
* Update gtk4, test buildsystems changes, test unit test changes

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* continue testing

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* continue testing

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* try to fix unit-test

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more testing

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more testing

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more testing

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more testing

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more testing

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more testing

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Move container unit tests to a script for easier debugging.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix paths

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Use simpler unit test script for arm too.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix unit test yaml

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* debugging...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* debugging...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add git settings for when GitHub is down.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix Unit-Test.yml

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust Unit-Test.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* more unit test adjustments

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add missing &&

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust unit tests further...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fix armv7l unit test, update libdrm.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add mesa builds

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update mesa package

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* lint

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* debugging

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add early exit from arm unit test if no arm packages have changed.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Fix path and suffix removal.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add more reporting.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust escaping in grep...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust git configs for network connectivity locally only.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Make git changes local not global.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* make git changes local

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* update changed-files actions

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* suggested changes

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-08-16 13:11:57 -05:00
Ed Reel
48326918e5 Revert "Download the correct file when there are multiple versions of a package binary (#10152)" (#10253)
This reverts commit 2249eee24e.
2024-08-05 12:17:26 -04:00
Maximilian Downey Twiss
2249eee24e Download the correct file when there are multiple versions of a package binary (#10152) 2024-08-04 23:24:48 -05:00
Maximilian Downey Twiss
cbd2d8f282 Add get_clean_version in PackageUtils and use it in json.rb and version.rb (#10249) 2024-08-04 23:09:32 -05:00
SupeChicken666
91f0f2ac98 lib/package: Get rid of eval strings (#10117)
* lib/package: Cleanup functions, get rid of `eval` strings

Signed-off-by: supechicken <me@supechicken666.dev>

* Fix error

Signed-off-by: supechicken <me@supechicken666.dev>

* Fix error

Signed-off-by: supechicken <me@supechicken666.dev>

* Add comments

Signed-off-by: supechicken <me@supechicken666.dev>

* Make rubocop happy

Signed-off-by: supechicken <me@supechicken666.dev>

* Fix error

Signed-off-by: supechicken <me@supechicken666.dev>

* Simplify

Signed-off-by: supechicken <me@supechicken666.dev>

* Bump crew version

Signed-off-by: supechicken <me@supechicken666.dev>

---------

Signed-off-by: supechicken <me@supechicken666.dev>
2024-07-10 14:49:10 -05:00
Maximilian Downey Twiss
48e3bd316e Rework load_package, set_package, search and copy_package (#9658) 2024-04-20 19:09:30 -05:00
Maximilian Downey Twiss
8b19dcd05a Add lib/package_utils.rb to provide a number of package convenience functions. (#9617) 2024-04-10 13:00:04 -05:00
Ed Reel
c141f4631d Update CREW_COMMANDS constant and replace hardcoded Available commmands (#9604) 2024-04-05 18:56:58 +11:00
Maximilian Downey Twiss
d13b6dbf9b Split prop command into separate file (#9514) 2024-04-03 02:23:27 -05:00
Ed Reel
9ab7decb17 Move constants from bin/crew to lib/const.rb (#9533)
Update help_test to include crew commands help test
2024-03-24 21:40:37 -04:00
Ed Reel
a27c54b793 Add help_test (#9531) 2024-03-23 20:55:39 -04:00
Ed Reel
95b40b3c24 Add buildsystem_test and check (#9530) 2024-03-23 19:08:23 +11:00
Ed Reel
7c17beeee7 Add check command (#9501) 2024-03-20 08:46:01 -04:00
Maximilian Downey Twiss
5d0af28461 Make prop_test and cycle_test cwd-agnostic (#9498) 2024-03-16 20:22:22 -04:00
Maximilian Downey Twiss
f675bcffef Correct dependencies of prop_test (#9455) 2024-03-08 20:22:57 -06:00
Maximilian Downey Twiss
2a48058428 Split const command out into separate file (#9445) 2024-03-06 21:43:13 -05:00
Maximilian Downey Twiss
925a461efb Split out help command to separate file (#9392) 2024-02-26 16:21:11 -06:00
Satadru Pramanik, DO, MPH, MEng
ac52769bad Revert "Miscellaneous crew changes (#9311)" (#9315)
This reverts commit 7a5eff8945.
2024-02-12 12:31:07 -06:00
Maximilian Downey Twiss
7a5eff8945 Miscellaneous crew changes (#9311)
* Make greater use of File.join when loading device.json

* Remove redundant check that the compatibility property exists (already checked by prop_test as part of CI)

* Don't pass architecture to lib/package.rb

* Replace @device[:architecture] with ARCH, do not create architecture section in device.json

* Refactor getting urls and sha256s in package.rb

* Use inplace sort on installed_packages instead of creating sorted_installed_packages

* Rework load_package to always only take one argument

* Only rescue package loading errors in set_package

* Remove generate_compatible

* Replace all calls to load_package with set_package

* Use _args instead of _ in prop_command

* Merge @short_verbose and @verbose

* Simplify filename detection in download

* Bump crew version
2024-02-12 12:38:18 -05:00
Maximilian Downey Twiss
d105a9c058 Run Rubocop 1.58 on tree (#9041) 2023-12-03 19:35:18 -05:00
Maximilian Downey Twiss
2e6eb61dc1 Remove spellcheck_test and rework load_test into prop_test (#8987) 2023-11-27 20:01:51 -05:00
Maximilian Downey Twiss
af1b3a3c3f Fix markdown-lint issues (#8419)
* Update markdown-lint configuration

* Fix markdown-lint issues

* remove outdated info

---------

Co-authored-by: Satadru Pramanik <satadru@gmail.com>
2023-06-22 10:30:08 -05:00
Maximilian Downey Twiss
de24923ee8 Add Rubocop CI (#7083)
* Rename IgnoredPatterns to AllowedPatterns.

* Exclude docopt.rb (not our code) from Rubocop

* Disable Style/RedundantReturn

* Disable Style/MutableConstant

* Disable Style/NumericLiterals

* Set Layout/IndentationStyle to spaces

* Temporarily disable various cops.

* Add Rubocop CI via Octocop

* Lint tree with rubocop -A -c .rubocop.yml

Co-authored-by: Satadru Pramanik <satadru@gmail.com>
2022-08-22 13:31:25 -04:00
supechicken
7ed76d1845 crew: Isolate package classes from global scope (#7283)
* crew: Isolate package classes from global scope

* Use `require_relative`

* Fix typo

* Prevent duplicate loading packages

* Bump version
2022-08-17 13:51:07 -05:00
Ed Reel
dc15b244f1 Add spellcheck_test script (#5655) 2021-04-18 15:37:19 +08:00