Commit Graph

12 Commits

Author SHA1 Message Date
Maximilian Downey Twiss
ecf7885ebc Properly separate ConvenienceFunctions out of PackageUtils and move additional functions into MiscFunctions, and document the various roles of each class (#10343) 2024-08-26 12:08:45 -04:00
Satadru Pramanik, DO, MPH, MEng
57a68748b5 installer fix for docker images (#9656)
* Add extra IO.console.console_mode check to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add i686 workaround for curl during installs

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* bump version

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add system curl check

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix logic

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-04-16 10:30:28 -05:00
Satadru Pramanik, DO, MPH, MEng
43c334de5f Autosource ~/.bashrc (#9649)
* Autosource ~/.bashrc

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add exitmessage...

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Use env variable to gate USR1

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add logging

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust logging, add more documentation

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* move env sourced variable in const.rb

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Update flag variable to be CREW_SOURCE_BASHRC_ACTIVATED

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Remove need for CREW_SOURCE_BASHRC_ACTIVATED env variable

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix logic for trap detection

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* revert to using env variable as flag for bash trap enablement

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add reversion to env based crew_profile_base trap detection

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* move SOURCE_BASHRC code block

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* use fd instead of env variable, check for interactive terminal in selector

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix fd check

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add exit to shell for installer so that bashrc does not have to be sourced manually after install is run.

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* do not use @pkg unless defined

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Do not tread on #9654

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Add some debug code to progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fixup selector and progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* remove debug code from progress_bar

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* refactor to use changed bash process name

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Adjust comment

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* disable more debug code

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix comparison

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix unit test

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add some debugging to selector

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* move crewlog to separate file

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* use global verbose

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* adjust timeout to 1 for selector

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* "workaround" using a global variable

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* fix CREW_VERBOSE

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* Use CREW_VERBOSE

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* switch all @opt_verbose to CREW_VERBOSE

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* try to work around missing constant on update

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* add print_source_bashrc to ccache

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* uncommented crewlog lines in crew

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

* remove debug crewlog lines

Signed-off-by: Satadru Pramanik <satadru@gmail.com>

---------

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
2024-04-15 21:28:42 -05:00
Maximilian Downey Twiss
eddca7e0e8 Enable additional temporarily disabled cops (#9394) 2024-03-01 12:24:31 -05:00
supechicken
1b9266e84f [downloader]: Fix broken progress bar when content-length not provided (#8010)
* downloader: Fix broken progress bar

* Fix syntax error

* Fix variable scope

* Revert last changes

* Remove redundant space
2023-02-28 08:47:05 -06:00
supechicken
2f24f701cc downloader: Fix endless download (#7933) 2023-02-13 15:51:27 -05:00
supechicken
43381ba173 lib/downloader: Fix progress bar length on older CrOS terminals (#7482)
* Fix progress bar on older CrOS terminals

* Make rubocop happy

* Use new color code functions

* Make rubocop happy

* Align variables

* Fix typo

* Remove extra space
2022-10-14 11:43:44 -05:00
Maximilian Downey Twiss
b5e4cedb0d Re-enable And/Or cop, lint tree (#7457) 2022-10-05 20:16:53 -05:00
Maximilian Downey Twiss
de24923ee8 Add Rubocop CI (#7083)
* Rename IgnoredPatterns to AllowedPatterns.

* Exclude docopt.rb (not our code) from Rubocop

* Disable Style/RedundantReturn

* Disable Style/MutableConstant

* Disable Style/NumericLiterals

* Set Layout/IndentationStyle to spaces

* Temporarily disable various cops.

* Add Rubocop CI via Octocop

* Lint tree with rubocop -A -c .rubocop.yml

Co-authored-by: Satadru Pramanik <satadru@gmail.com>
2022-08-22 13:31:25 -04:00
supechicken
777e9177f0 lib/progress_bar: Fix non-interactive terminal fallback logic (#7276) 2022-08-16 15:41:44 -04:00
supechicken
de5bf96d41 lib/downloader: Add fix for invalid file size recieved from server (#7271)
* Add fix for github raw links

* lib/downloader: Add fix for github raw links

* Update comment
2022-08-14 13:02:32 -05:00
supechicken
64ba6d7ab5 lib/downloader: New progress bar style, disappear after download complete (#7270)
* lib/downloader: New progress bar design, with more info

* Reduce progress bar update time

* Clear progress bar when success only

* Update progress_bar.rb

* Update downloader.rb
2022-08-14 09:53:36 -05:00