From 1e8c0df381cb57346b18b533cc7c0c98fddcfc03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Test=C3=A9?= Date: Wed, 23 Nov 2022 13:26:02 +0100 Subject: [PATCH] chore(ci): change benchmark parser input name The use of "schema" was incorrect since it's meant to be used as database name when sending data to Slab. --- .github/workflows/benchmark.yml | 2 +- .github/workflows/ml_benchmark_subset.yml | 2 +- ci/benchmark_parser.py | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 3ed10b48c..631e691e3 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -130,7 +130,7 @@ jobs: COMMIT_DATE="$(git --no-pager show -s --format=%cd --date=iso8601-strict ${{ github.sha }})" COMMIT_HASH="$(git describe --tags --dirty)" python3 ./ci/benchmark_parser.py compiler/benchmarks_results.json ${{ env.RESULTS_FILENAME }} \ - --schema compiler_benchmarks \ + --database compiler_benchmarks \ --hardware ${{ env.EC2_INSTANCE_TYPE }} \ --project-version ${COMMIT_HASH} \ --branch ${{ github.ref_name }} \ diff --git a/.github/workflows/ml_benchmark_subset.yml b/.github/workflows/ml_benchmark_subset.yml index 1c92771c7..7c3f2c8bb 100644 --- a/.github/workflows/ml_benchmark_subset.yml +++ b/.github/workflows/ml_benchmark_subset.yml @@ -100,7 +100,7 @@ jobs: COMMIT_DATE="$(git --no-pager show -s --format=%cd --date=iso8601-strict ${{ github.sha }})" COMMIT_HASH="$(git describe --tags --dirty)" python3 ./ci/benchmark_parser.py compiler/benchmarks_results.json ${{ env.RESULTS_FILENAME }} \ - --schema compiler_benchmarks \ + --database compiler_benchmarks \ --hardware ${{ inputs.instance_type }} \ --project-version ${COMMIT_HASH} \ --branch ${{ github.ref_name }} \ diff --git a/ci/benchmark_parser.py b/ci/benchmark_parser.py index c1869c1da..7388cef5f 100644 --- a/ci/benchmark_parser.py +++ b/ci/benchmark_parser.py @@ -16,8 +16,8 @@ parser.add_argument('results_path', 'In a case of a directory, this script will attempt to parse all the' 'files containing a .json extension')) parser.add_argument('output_file', help='File storing parsed results') -parser.add_argument('-s', '--schema', dest='schema', required=True, - help='Name of the database schema used to store results') +parser.add_argument('-d', '--database', dest='database', required=True, + help='Name of the database used to store results') parser.add_argument('-w', '--hardware', dest='hardware', required=True, help='Hardware reference used to perform benchmark') parser.add_argument('-V', '--project-version', dest='project_version', required=True, @@ -74,7 +74,7 @@ def dump_results(parsed_results, filename, input_args): """ filename.parent.mkdir(parents=True, exist_ok=True) series = { - "schema": input_args.schema, + "database": input_args.database, "hardware": input_args.hardware, "project_version": input_args.project_version, "branch": input_args.branch,