From 29c1641f48bcfb90eb0031e593ad2e3f59f19ab6 Mon Sep 17 00:00:00 2001 From: Arthur Meyre Date: Wed, 21 Jul 2021 10:38:59 +0200 Subject: [PATCH] dev: remove unique_id system, not needed for now - wrong assumption when reading hnp's code, for now unique ids are not needed --- hdk/__init__.py | 2 +- hdk/utils/__init__.py | 3 --- hdk/utils/misc.py | 18 ------------------ tests/utils/test_misc.py | 17 ----------------- 4 files changed, 1 insertion(+), 39 deletions(-) delete mode 100644 hdk/utils/__init__.py delete mode 100644 hdk/utils/misc.py delete mode 100644 tests/utils/test_misc.py diff --git a/hdk/__init__.py b/hdk/__init__.py index 44b5d6169..fb269a812 100644 --- a/hdk/__init__.py +++ b/hdk/__init__.py @@ -1,2 +1,2 @@ """HDK's top import""" -from . import common, utils +from . import common diff --git a/hdk/utils/__init__.py b/hdk/utils/__init__.py deleted file mode 100644 index 314ca624d..000000000 --- a/hdk/utils/__init__.py +++ /dev/null @@ -1,3 +0,0 @@ -"""HDK's utils module""" -from . import misc -from .misc import * diff --git a/hdk/utils/misc.py b/hdk/utils/misc.py deleted file mode 100644 index 197ea760c..000000000 --- a/hdk/utils/misc.py +++ /dev/null @@ -1,18 +0,0 @@ -"""Misc. utils for hdk""" -from typing import Iterator - - -def get_unique_id() -> int: - """Function to get a unique ID""" - - if not hasattr(get_unique_id, "generator"): - - def generator() -> Iterator[int]: - current_id = 0 - while True: - yield current_id - current_id += 1 - - setattr(get_unique_id, "generator", generator()) - - return next(getattr(get_unique_id, "generator")) diff --git a/tests/utils/test_misc.py b/tests/utils/test_misc.py deleted file mode 100644 index e7438adbd..000000000 --- a/tests/utils/test_misc.py +++ /dev/null @@ -1,17 +0,0 @@ -"""Test file for HDK's misc utils""" -import random - -import hdk - - -def test_get_unique_id(): - """Test get_unique_id""" - how_many_ids = random.randint(2, 100) - generated_ids = [hdk.utils.get_unique_id() for __ in range(how_many_ids)] - - len_generated_ids = len(generated_ids) - len_unique_ids = len(set(generated_ids)) - - assert ( - len_generated_ids == len_unique_ids - ), f"Expected to have uniques ids, generated {len_generated_ids}, only had {len_unique_ids}"