From 34f114cda9041db892e9d4d4223c33a0f41a9fb0 Mon Sep 17 00:00:00 2001
From: youben11 <ayoub.benaissa@zama.ai>
Date: Thu, 7 Oct 2021 16:13:13 +0100
Subject: [PATCH] ci: fix compatibility checks

---
 .github/workflows/concrete-lib-compatibility.yml | 9 +++------
 .github/workflows/llvm-compatibility.yml         | 3 +++
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/concrete-lib-compatibility.yml b/.github/workflows/concrete-lib-compatibility.yml
index 4c93ff489..1082fb054 100644
--- a/.github/workflows/concrete-lib-compatibility.yml
+++ b/.github/workflows/concrete-lib-compatibility.yml
@@ -14,18 +14,16 @@ jobs:
       - uses: actions/checkout@v2
 
       - name: Compare image timestamps
-        continue-on-error: true
         run: |
           ./.github/workflows/scripts/container_timestamp_check.sh \
           --base_img_url \
           https://api.github.com/orgs/zama-ai/packages/container/concrete-api-env/versions \
           --env_img_url \
           https://api.github.com/orgs/zama-ai/packages/container/zamalang-compiler/versions \
-          --token ${{ secrets.BOT_TOKEN }}
+          --token ${{ secrets.GH_TOKEN }}
       
       - name: Send Slack Notification 
-        if: ${{ failure() }}
-        continue-on-error: true
+        if: ${{ always() && failure() }}
         uses: rtCamp/action-slack-notify@12e36fc18b0689399306c2e0b3e0f2978b7f1ee7
         env:
           SLACK_CHANNEL: ${{ secrets.SLACK_CHANNEL }}
@@ -47,11 +45,10 @@ jobs:
           run: mkdir -p /workspace/concrete/target && cp -r /target/release /workspace/concrete/target
 
       - name: Test compiler with latest concrete-ffi
-        if: ${{ success() }}
         uses: addnab/docker-run-action@v3
         with:
           image: ghcr.io/zama-ai/zamalang-compiler
-          options: -v /workspace/concrete:/concrete
+          options: -v ${{ github.workspace }}/concrete:/concrete
           run: |
             cd /compiler
             pip install pytest
diff --git a/.github/workflows/llvm-compatibility.yml b/.github/workflows/llvm-compatibility.yml
index 912e956fd..e8b16a4ad 100644
--- a/.github/workflows/llvm-compatibility.yml
+++ b/.github/workflows/llvm-compatibility.yml
@@ -21,6 +21,9 @@ jobs:
       - name: Log LLVM commit
         run: echo "LLVM commit" && cd ${{ github.workspace }}/llvm-project && git log -1
 
+      - name: login
+        run: echo "${{ secrets.GHCR_PASSWORD }}" | docker login -u ${{ secrets.GHCR_LOGIN }} --password-stdin ghcr.io
+
       - name: Build
         run: docker image build --no-cache -t compiler-latest-llvm -f builders/Dockerfile.zamalang-env .