From 468f8aba625a9cd1dcd2a7cbcf1e2ed632c3e666 Mon Sep 17 00:00:00 2001 From: Arthur Meyre Date: Wed, 22 Sep 2021 09:37:50 +0200 Subject: [PATCH] fix: correct a mistake done when fixing shellcheck lints - we must not exit right away if sourcing fails - recreate the venv only if the source fails --- .../benchmark_and_publish_findings_in_docker.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/script/progress_tracker_utils/benchmark_and_publish_findings_in_docker.sh b/script/progress_tracker_utils/benchmark_and_publish_findings_in_docker.sh index 31e245a5e..52b73f02c 100755 --- a/script/progress_tracker_utils/benchmark_and_publish_findings_in_docker.sh +++ b/script/progress_tracker_utils/benchmark_and_publish_findings_in_docker.sh @@ -3,10 +3,10 @@ # Run benchmarks while logging the intermediate results # Publish findings in the progress tracker -set -e +set +e # shellcheck disable=SC1091 -if source /src/.docker_venv/bin/activate; then +if ! source /src/.docker_venv/bin/activate; then python3 -m venv /src/.docker_venv # shellcheck disable=SC1091 source /src/.docker_venv/bin/activate