diff --git a/.github/workflows/continuous-integration.yaml b/.github/workflows/continuous-integration.yaml index aa4a51884..88081520c 100644 --- a/.github/workflows/continuous-integration.yaml +++ b/.github/workflows/continuous-integration.yaml @@ -54,10 +54,9 @@ jobs: - name: Conformance id: conformance if: ${{ success() && !cancelled() }} - # keep going registers errors in the intermediate targets but executes them all - # Nicer to have pcc complete for the dev and have all the relevant conformance issues + # pcc launches an internal target with proper flags run: | - make --keep-going pcc + make pcc - name: PyTest id: pytest if: ${{ steps.conformance.outcome == 'success' && !cancelled() }} diff --git a/Makefile b/Makefile index 762cfd062..df67344ca 100644 --- a/Makefile +++ b/Makefile @@ -34,9 +34,13 @@ python_linting: pylint flake8 conformance: python_format .PHONY: conformance -pcc: check_python_format python_linting mypy_ci pydocstyle +pcc: + @$(MAKE) --keep-going --jobs $$(nproc) --output-sync --no-print-directory pcc_internal .PHONY: pcc +pcc_internal: check_python_format python_linting mypy_ci pydocstyle +.PHONY: pcc_internal + pytest: poetry run pytest --cov=hdk -vv --cov-report=xml tests/ .PHONY: pytest @@ -60,7 +64,10 @@ mypy_benchmark: find ./benchmarks/ -name "*.py" | xargs poetry run mypy --ignore-missing-imports .PHONY: mypy_benchmark -mypy_ci: mypy mypy_test mypy_benchmark +mypy_ci: + @$(MAKE) --no-print-directory mypy + @$(MAKE) --no-print-directory mypy_test + @$(MAKE) --no-print-directory mypy_benchmark .PHONY: mypy_ci pytest_and_coverage: pytest coverage