From 8422a0ea2c2d6d97b3796cab23296b5977b7756d Mon Sep 17 00:00:00 2001 From: rudy Date: Mon, 6 Feb 2023 16:06:24 +0100 Subject: [PATCH] fix: solo_key::analyse, rm unused field was used only to prevent too conservatives pre-cuts, we no longer have pre-cuts --- .../src/optimization/dag/solo_key/analyze.rs | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/compilers/concrete-optimizer/concrete-optimizer/src/optimization/dag/solo_key/analyze.rs b/compilers/concrete-optimizer/concrete-optimizer/src/optimization/dag/solo_key/analyze.rs index c7bd94f21..958f75461 100644 --- a/compilers/concrete-optimizer/concrete-optimizer/src/optimization/dag/solo_key/analyze.rs +++ b/compilers/concrete-optimizer/concrete-optimizer/src/optimization/dag/solo_key/analyze.rs @@ -104,8 +104,6 @@ pub struct OperationDag { // Collect all operators ouput variances pub out_variances: Vec, pub nb_luts: u64, - // True if all luts have noise with origin VarianceOrigin::Input - pub has_only_luts_with_inputs: bool, // The full dag levelled complexity pub levelled_complexity: LevelledComplexity, // Dominating variances and bounds per precision @@ -413,16 +411,12 @@ pub fn analyze( &in_luts_variance, noise_config, ); - let has_only_luts_with_inputs = in_luts_variance - .iter() - .all(|(_, _, sb)| sb.origin() == VarianceOrigin::Input); let result = OperationDag { operators: dag.operators.clone(), out_variances, nb_luts, levelled_complexity, constraints_by_precisions, - has_only_luts_with_inputs, }; assert_properties_correctness(&result); result @@ -866,24 +860,4 @@ mod tests { prev_safe_noise_bound = ns.safe_variance_bound; } } - - #[test] - fn test_1_layer_lut() { - let mut graph = unparametrized::OperationDag::new(); - let input1 = graph.add_input(1, Shape::number()); - let _lut1 = graph.add_lut(input1, FunctionTable::UNKWOWN, 1); - let _lut2 = graph.add_lut(input1, FunctionTable::UNKWOWN, 1); - let analysis = analyze(&graph); - assert!(analysis.has_only_luts_with_inputs); - } - - #[test] - fn test_2_layer_lut() { - let mut graph = unparametrized::OperationDag::new(); - let input1 = graph.add_input(1, Shape::number()); - let lut1 = graph.add_lut(input1, FunctionTable::UNKWOWN, 1); - let _lut2 = graph.add_lut(lut1, FunctionTable::UNKWOWN, 1); - let analysis = analyze(&graph); - assert!(!analysis.has_only_luts_with_inputs); - } }